SchildiChat-android/.github/PULL_REQUEST_TEMPLATE.md

17 lines
1.3 KiB
Markdown
Raw Normal View History

2019-03-13 17:00:30 +01:00
### Pull Request Checklist
<!--
Please read [CONTRIBUTING.md](https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md) before submitting your pull request
Depending on the Pull Request content, it can be acceptable if some of the following checkboxes stay unchecked.
-->
2019-03-13 17:00:30 +01:00
2020-08-03 17:29:07 +02:00
- [ ] Changes has been tested on an Android device or Android emulator with API 21
2019-03-13 17:00:30 +01:00
- [ ] UI change has been tested on both light and dark themes
- [ ] Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
2019-03-13 17:00:30 +01:00
- [ ] Pull request is based on the develop branch
- [ ] Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
2019-03-13 17:00:30 +01:00
- [ ] Pull request includes screenshots or videos if containing UI changes
- [ ] Pull request includes a [sign off](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off)
- [ ] You've made a self review of your PR
- [ ] If you have modified the screen flow, or added new screens to the application, you have updated the test [UiAllScreensSanityTest.allScreensTest()](https://github.com/vector-im/element-android/blob/main/vector/src/androidTest/java/im/vector/app/ui/UiAllScreensSanityTest.kt#L73)