From 3073ceec1a7d0fca61bc39a5cc893747d83c3ac4 Mon Sep 17 00:00:00 2001
From: nobody <info@localcdn.org>
Date: Mon, 5 Dec 2022 06:30:47 +0100
Subject: [PATCH] Sync: settings are not saved locally (#1236)

---
 pages/options/options.js   | 5 +++--
 pages/updates/updates.html | 3 ++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/pages/options/options.js b/pages/options/options.js
index bdf12e58..0bdc530d 100644
--- a/pages/options/options.js
+++ b/pages/options/options.js
@@ -36,7 +36,7 @@ options._renderContents = function () {
     document.body.setAttribute('dir', options._scriptDirection);
     translationComplete = helpers.insertI18nContentIntoDocument(document);
 
-    options._determineOptionValues().then(options._determineLocalOptionValues).then(options._renderOptionsPanel);
+    options._determineLocalOptionValues().then(options._determineOptionValues).then(options._renderOptionsPanel);
 
     if (!translationComplete) {
         options._renderLocaleNotice();
@@ -152,6 +152,7 @@ options._determineOptionValues = function () {
         for (let element of nodeList) {
             optionList[element.getAttribute('data-option')] = true;
         }
+        delete optionList.internalStatistics;
 
         optionKeys = Object.keys(optionList);
 
@@ -285,7 +286,7 @@ options.onOptionChanged = function ({target}) {
             break;
     }
 
-    if (options._storageType === 'sync') {
+    if (options._storageType === 'sync' && optionKey !== 'internalStatistics') {
         chrome.storage.sync.set({
             [optionKey]: optionValue,
         });
diff --git a/pages/updates/updates.html b/pages/updates/updates.html
index 9b5260d3..55df7830 100644
--- a/pages/updates/updates.html
+++ b/pages/updates/updates.html
@@ -25,8 +25,9 @@
                         <h2>New in LocalCDN:</h2>
                     </div>
                     <div class="release-notes-area">
-                        <p></p>
+                        <p>Fixed</p>
                         <ul>
+                            <li>Sync: settings are not saved locally (<a href="https://codeberg.org/nobody/LocalCDN/issues/1236">#1236</a>)</li>
                         </ul>
                     </div>
                     <div id="generator-section">