1
0
mirror of https://github.com/yt-dlp/yt-dlp.git synced 2024-12-24 05:32:33 +01:00
yt-dlp/youtube_dl/postprocessor
Yen Chi Hsuan 23495d6a39
Revert "[ffmpeg] Fix embedding subtitles (#9063)"
This reverts commit ccff2c404d.

Fixes #10081.

The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:

opts = [
    '-map', '0:v?',
    '-c:v', 'copy',
    '-map', '0:a?',
    '-c:a', 'copy',
    # other options...
]

Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
2016-07-15 20:02:36 +08:00
..
__init__.py
common.py
embedthumbnail.py
execafterdownload.py
ffmpeg.py Revert "[ffmpeg] Fix embedding subtitles (#9063)" 2016-07-15 20:02:36 +08:00
metadatafromtitle.py
xattrpp.py