fenix
/
yt-dlp
mirror of https://github.com/yt-dlp/yt-dlp.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
21,162 Commits 3 Branches 100 Tags 202 MiB
Commit Graph

179 Commits

Author SHA1 Message Date
pukkandan a44ca5a470
[cleanup] Misc fixes 
Closes https://github.com/yt-dlp/yt-dlp/pull/3213, Closes https://github.com/yt-dlp/yt-dlp/pull/3117

Related: https://github.com/yt-dlp/yt-dlp/issues/3146#issuecomment-1077323114, https://github.com/yt-dlp/yt-dlp/pull/3277#discussion_r841019671, a825ffbffa (commitcomment-68538986), https://github.com/yt-dlp/yt-dlp/issues/2360, 5fa3c9a88f (r70393519), 5fa3c9a88f (r70393254)
 2022-04-05 18:12:18 +05:30
pukkandan af4944d84b
Fix bug in 8a7f68d0b1 
Closes #3241
 2022-03-30 12:22:36 +05:30
pukkandan 8a7f68d0b1
[ffmpeg] Cache version data 
Related: https://github.com/dasl-/pifi/issues/9
 2022-03-29 03:44:51 +05:30
pukkandan 4a3175fc4c
[VideoConvertor] Ensure all streams are copied 
Closes #3200
 2022-03-27 09:28:58 +05:30
pukkandan 5cf34021f5
[Concat] Ensure final directory exists 
Fixes https://github.com/yt-dlp/yt-dlp/issues/3181#issuecomment-1079622589
 2022-03-27 04:52:11 +05:30
pukkandan a3f2445e29
[postprocessor,cleanup] Create `_download_json` 2022-03-25 08:45:35 +05:30
pukkandan 5ca764c506
[FFmpegVideoConvertor] Add more formats to `--remux-video` 2022-03-13 22:26:03 +05:30
pukkandan 2b38f7b2bc
[MetadataParser] Validate outtmpl early 2022-03-11 19:29:43 +05:30
pukkandan d1b5f70bc9
[cleanup] Refactor `__init__.py` (#2570) 
* Split `__init__` code into multiple functions
* Clean up validation code by grouping similar types of options
* Expose `parse_options` to third parties
 2022-03-08 12:03:31 -08:00
pukkandan 72073451be
[ThumbnailsConvertor] Support `webp` 
Closes #2226
 2022-02-23 03:51:13 +05:30
Nil Admirari 7a34b5d628
[SponsorBlock] Fixes for highlight and "full video labels" (#2849) 
Authored by: nihil-admirari
 2022-02-22 06:18:44 -08:00
pukkandan ed66a17ef0
[FFmpegConcat] Abort on `--simulate` 2022-02-18 23:17:37 +05:30
Nil Admirari ae419aa94f
[Sponsorblock] minor fixes (#2793) 
* preserve mtime - Closes #2769
* keep concat spec on failure

Authored by: nihil-admirari
 2022-02-17 09:10:34 -08:00
pukkandan 460a1c08b9
[FFmpegConcat] Abort on --skip-download and download errors 
Closes #2470
 2022-02-03 21:00:38 +05:30
pukkandan 88f23a18e0
[docs,cleanup] Fix linter and misc cleanup 
Closes #2419
 2022-01-24 03:24:23 +05:30
pukkandan 6970b6005e
[cleanup] Minor fixes 
Closes #2334
 2022-01-21 13:27:44 +05:30
pukkandan 3b603dbdf1
Add option `--concat-playlist` 
Closes #1855, related: #382
 2022-01-13 16:32:23 +05:30
pukkandan 5df1ac92bd
[ffmpeg] Ignore unknown streams 
Closes #2307
 2022-01-13 16:32:22 +05:30
pukkandan ed8d87f911
[cleanup, docs] Minor fixes 
Closes #2230
 2022-01-12 09:00:21 +05:30
pukkandan 397235c52b
[ffmpeg] Standardize use of `-map 0` 
Closes #2182
 2022-01-12 08:52:09 +05:30
pukkandan 61e9d9268c
Fix bug in 8896899216 
Closes #2215
 2022-01-03 20:45:55 +05:30
pukkandan 1e43a6f733
Allow `--exec` to be run at any post-processing stage 
Deprecates `--exec-before-download`
 2022-01-03 19:40:02 +05:30
pukkandan 8896899216
[FfmpegMetadata] Allow setting metadata of individual streams 
Closes #877
 2022-01-02 03:33:15 +05:30
pukkandan 77cee0f188
[EmbedThumbnail] Prefer AtomicParsley over ffmpeg if available 2021-12-27 03:49:43 +05:30
pukkandan 6a17677577
[ThumbnailsConvertor] Fix for when there are no thumbnails 
Closes #2125
 2021-12-27 03:18:31 +05:30
pukkandan 8eb4b1bb8e
[ffmpeg] Fix position of `--ppa` 
Bug in ca5db158ae
Closes #2112
 2021-12-25 08:42:08 +05:30
pukkandan b69fd25c25
[cleanup] Misc cleanup 
Closes #1942 #1976 #2020 #2058 #1984
 2021-12-23 07:12:46 +05:30
The Hatsune Daishi adbc4ec4bb
[dash,youtube] Download live from start to end (#888) 
* Add option `--live-from-start` to enable downloading live videos from start
* Add key `is_from_start` in formats to identify formats (of live videos) that downloads from start
* [dash] Create protocol `http_dash_segments_generator` that allows a function to be passed instead of fragments
* [fragment] Allow multiple live dash formats to download simultaneously
* [youtube] Implement fragment re-fetching for the live dash formats
* [youtube] Re-extract dash manifest every 5 hours (manifest expires in 6hrs)
* [postprocessor/ffmpeg] Add `FFmpegFixupDuplicateMoovPP` to fixup duplicated moov atoms

Known issue: Ctrl+C doesn't work on Windows when downloading multiple formats

Closes #1521
Authored by: nao20010128nao, pukkandan
 2021-12-20 11:36:46 +05:30
pukkandan ca5db158ae
[postprocessor/ffmpeg] Always add `faststart` 
Closes #1491
 2021-12-20 08:52:34 +05:30
Nil Admirari 8157a09d22
[SponsorBlock] Add Filler and Highlight categories (#1664) 
Authored by: nihil-admirari, pukkandan
 2021-12-09 18:10:31 +05:30
pukkandan 9bdd99cf39
[EmbedSubtitle] Disable duration check temporarily 
Closes #1870, #1385
 2021-12-02 19:54:01 +05:30
pukkandan a804f6d89c
[cleanup Fix some typos 
* `MetadataFromFieldPP` is not deprecated!
* Wrong args to `MetadataFromFieldPP`
* Some mistakes in change log
* Type in build.yml causing release tag to be placed on wrong commit
 2021-12-01 10:15:01 +05:30
pukkandan ee8dd27a73
[cleanup] Add deprecation warnings 2021-11-29 23:34:33 +05:30
pukkandan f304da8a29
[cleanup] Misc cleanup 
Closes #1805, closes #1800
 2021-11-29 23:34:33 +05:30
pukkandan 5ce1d13eba
[EmbedSubtitles] Slightly relax duration check 
and related cleanup
Closes #1385
 2021-11-27 19:21:47 +05:30
pukkandan e04b003e64
[FixupM3u8] Fixup MPEG-TS in MP4 container 
Closes #1701, https://github.com/ytdl-org/youtube-dl/issues/26410
 2021-11-27 19:21:47 +05:30
pukkandan 467b6b8387
[ExtractAudio] Support `alac` 
Closes #1707
 2021-11-19 05:20:13 +05:30
pukkandan dac5df5a98
Add option `--embed-info-json` to embed info-json in mkv 
Closes #1644
 2021-11-15 04:51:11 +05:30
pukkandan f279aaee8e
Add compat-option embed-metadata 2021-11-15 01:25:47 +05:30
pukkandan 39c04074e7
[ExtractAudio] Fix conversion to `wav` 
Closes #1645
 2021-11-13 15:15:23 +05:30
pukkandan c586f9e8de
[cleanup] minor fixes 2021-11-10 04:19:54 +05:30
pukkandan 8913ef74d7
[ffmpeg] Detect libavformat version for `aac_adtstoasc` 
and print available features in verbose head
Based on https://github.com/ytdl-org/youtube-dl/pull/29581
 2021-11-04 03:13:37 +05:30
pukkandan 832e9000c7
[ffmpeg] Accurately detect presence of setts 
Closes #1237
 2021-11-04 02:24:12 +05:30
CrypticSignal 673c0057e8
[ExtractAudio] Use `libfdk_aac` if available 
Closes #1502
Authored by: CrypticSignal
 2021-11-04 02:23:45 +05:30
pukkandan 9af98e17bd
[ffmpeg] Framework for feature detection 
Related: #1502, #1237, https://github.com/ytdl-org/youtube-dl/pull/29581
 2021-11-04 02:16:39 +05:30
pukkandan 31c49255bf
[ExtractAudio] Rescale --audio-quality correctly 
Authored by: CrypticSignal, pukkandan
 2021-11-04 00:05:53 +05:30
pukkandan abad800058
[downloader/ffmpeg] Fix vtt download with ffmpeg 2021-10-26 20:27:09 +05:30
pukkandan ef58c47637
[SponsorBlock] Obey `extractor-retries` and `sleep-requests` 2021-10-22 04:42:44 +05:30
pukkandan d3c93ec2b7
Don't create console for subprocesses on Windows (#1261) 
Closes #1251
 2021-10-20 21:49:40 +05:30
Nil Admirari e619d8a752
[ModifyChapters] Do not mutate original chapters (#1322) 
Closes #1295 
Authored by: nihil-admirari
 2021-10-19 14:21:05 +05:30
pukkandan 2d9ec70423
[ModifyChapters] Allow removing sections by timestamp 
Eg: --remove-chapters "*10:15-15:00".
The `*` prefix is used so as to avoid any conflicts with other valid regex
 2021-10-18 16:06:51 +05:30
pukkandan b11d210156
[EmbedMetadata] Allow overwriting all default metadata 
with `meta_default` key
 2021-10-18 10:31:56 +05:30
pukkandan 03b4de722a
[downloader] Fix slow progress hooks 
Closes #1301
 2021-10-16 20:02:40 +05:30
pukkandan 9dda99f2fc [Merger] Do not add `aac_adtstoasc` to non-hls audio 2021-10-11 17:09:28 +05:30
pukkandan 91b6c884c9
Revert "[ffmpeg] Set max probesize to workaround AAC HLS stream issues (#1109)" 
This reverts commit 250a938de8.

This is no longer necessary since 7687c8ac6e
 2021-10-10 04:47:48 +05:30
pukkandan aa9a92fdbb
[downloader/ffmpeg] Fix bug in initializing `FFmpegPostProcessor` 
When `FFmpegFD` initializes the PP, it passes `self` as the `downloader`
But it does not have a `_postprocessor_hooks` attribute

Closes #1211
 2021-10-10 02:23:50 +05:30
pukkandan 819e05319b
Improved progress reporting (See desc) (#1125) 
* Separate `--console-title` and `--no-progress`
* Add option `--progress` to show progress-bar even in quiet mode
* Fix and refactor `minicurses`
* Use `minicurses` for all progress reporting
* Standardize use of terminal sequences and enable color support for windows 10
* Add option `--progress-template` to customize progress-bar and console-title
* Add postprocessor hooks and progress reporting

Closes: #906, #901, #1085, #1170
 2021-10-09 00:41:59 +05:30
pukkandan a1c3967307
[EmbedSubtitle, SubtitlesConvertor] Fix error when subtitle file is missing 
Closes #1152, #1134
Bug from 8e25d624df
 2021-10-04 03:08:26 +05:30
pukkandan e6f21b3d92
[docs,cleanup] Some minor refactoring and improve docs 2021-09-30 03:32:52 +05:30
pukkandan 3ae5e79774
[postprocessor] Add plugin support 
Adds option `--use-postprocessor` to enable them
 2021-09-30 03:32:46 +05:30
pukkandan 1f2a268bd3
[embedsubtitle] Fix error when duration is unknown 2021-09-30 03:32:41 +05:30
shirt 250a938de8
[ffmpeg] Set max probesize to workaround AAC HLS stream issues (#1109) 
Fixes: #618, #998, #1039

Authored by: shirt-dev
 2021-09-28 04:12:33 +05:30
pukkandan 51ff9ca0b0
[xattr] bugfix for b19404591a 2021-09-24 06:20:42 +05:30
pukkandan b19404591a
Separate the options `--ignore-errors` and `--no-abort-on-error` 
In youtube-dl, `-i` ignores both download and post-processing error, and
treats the download as successful even if the post-processor fails.

yt-dlp used to skip the entire video on either error and there was no
option to ignore the post-processing errors like youtube-dl does.

By splitting the option into two, now either just the download errors
(--no-abort-on-error, default on CLI) or all errors (--ignore-errors)
can be ignored as per the users' needs

Closes #893
 2021-09-24 06:05:35 +05:30
pukkandan 50eff38c1c
bugfix for a21e0ab1a1 
Closes #1061
 2021-09-23 11:49:00 +05:30
pukkandan a21e0ab1a1
[ffmpeg] Add `aac_adtstoasc` when merging if needed 
Related: #1039
 2021-09-22 19:51:58 +05:30
Nil Admirari c6af2dd8e5
[SponsorBlock] Improve merge algorithm (#999) 
Authored by: nihil-admirari
 2021-09-19 08:38:50 +05:30
pukkandan 165efb823b
[ModifyChapters] fixes (See desc) 
* [docs] Fix typo
* Do not enable `sponskrub` by default
* Fix `--force-keyframes-at-cuts`
* Don't embed subtitles if the video has been cut. Previously, running `--remove-chapters` with `--embed-subs` multiple times caused repeated cuts and out-of-sync subtitles
* Store `_real_duration` to prevent running ffprobe multiple times
 2021-09-04 01:39:31 +05:30
Nil Admirari 7a340e0df3
Native SponsorBlock implementation and related improvements (#360) 
SponsorBlock options:
* The fetched sponsor sections are written to infojson
* `--sponsorblock-remove` removes specified chapters from file
* `--sponsorblock-mark` marks the specified sponsor sections as chapters
* `--sponsorblock-chapter-title` to specify sponsor chapter template
* `--sponsorblock-api` to use a different API

Related improvements:
* Split `--embed-chapters` from `--embed-metadata`
* Add `--remove-chapters` to remove arbitrary chapters
* Add `--force-keyframes-at-cuts` for more accurate cuts when removing and splitting chapters

Deprecates all `--sponskrub` options

Authored by: nihil-admirari, pukkandan
 2021-09-02 02:25:16 +05:30
pukkandan 8e25d624df
[EmbedSubtitle] Continue even if some files are missing 2021-09-01 08:51:22 +05:30
Paul Wrubel d75201a873
Use `os.replace` where applicable (#793) 
When using 
```py
os.remove(encodeFilename(filename))
os.rename(encodeFilename(temp_filename), encodeFilename(filename))
```
the `os.remove` need not be atomic and so can be executed arbitrarily compared to the immediately following rename call. It is better to use `os.replace` instead

Authored by: paulwrubel
 2021-08-27 07:57:20 +05:30
pukkandan 330690a214
[downloader/ffmpeg] Allow passing custom arguments before -i 
Closes #686
 2021-08-24 04:24:12 +05:30
pukkandan 37242e56f2
Fix bug during subtitle conversion 2021-08-15 00:26:33 +05:30
pukkandan a8731fcc1d minor bugfixes 
bugs due to be2fc5b212, e9f4ccd19e
 2021-08-11 20:27:30 +05:30
pukkandan ad3dc496bb Misc fixes - See desc 
* Remove unnecessary uses of _list_from_options_callback
* Fix download tests - Bug from 6e84b21559
* Rename ExecAfterDownloadPP to ExecPP and refactor its tests
* Ensure _write_ytdl_file closes file handle on error - Potential fix for #517
 2021-08-10 01:22:55 +05:30
pukkandan 8c0ae192a4 [ffmpeg] Fix `--ffmpeg-location` when directory is given 
Bug introduced in 89efdc15dd
Closes #654
 2021-08-10 01:22:55 +05:30
pukkandan e9f4ccd19e
Add option `--replace-in-metadata` 2021-08-10 01:22:55 +05:30
pukkandan c681cb5d93 Allow multiple `--exec` and `--exec-before-download` 2021-08-07 21:17:07 +05:30
pukkandan 89efdc15dd [ffpmeg] Allow `--ffmpeg-location` to be a file with different name 2021-08-05 03:37:18 +05:30
pukkandan 901130bbcf Expand and escape environment variables correctly in outtmpl 
Fixes: https://www.reddit.com/r/youtubedl/comments/otfmq3/ytdlp_same_parameters_different_results
 2021-07-29 08:38:18 +05:30
pukkandan 5520aa2dc9
Add option `--exec-before-download` 
Closes #530
 2021-07-19 23:47:45 +05:30
pukkandan 501dd1ad55
[metadatafromfield] Do not detect numbers as field names 
Related: https://github.com/yt-dlp/yt-dlp/issues/486#issuecomment-877820394
 2021-07-12 05:20:12 +05:30
pukkandan 00034c146a
[embedthumbnail] Fix `_get_thumbnail_resolution` 2021-07-11 04:46:53 +05:30
pukkandan 7dde84f3c9
[FFmpegMetadata] Add language of each stream 
and some refactoring
 2021-07-11 04:46:52 +05:30
pukkandan 6606817a86
[utils] Add `variadic` 2021-07-11 04:46:51 +05:30
pukkandan 15a4fd53d3
[thumbnailsconvertor] Treat `jpeg` as `jpg` 2021-06-25 05:36:35 +05:30
pukkandan e36d50c5dd
[websockets] Add `WebSocketFragmentFD` (#399) 
Necessary for #392

Co-authored by: nao20010128nao, pukkandan
 2021-06-21 22:56:36 +05:30
pukkandan f89b3e2d7a
Skip fixup of existing files and add `--fixup force` to force it 2021-06-20 04:59:34 +05:30
pukkandan fd7cfb6444
[cleanup] Refactor fixup 2021-06-20 04:26:11 +05:30
pukkandan e858a9d6d3
[EmbedThumbnail] Add compat-option `embed-thumbnail-atomicparsley` 
to force use of atomicparsley for embedding thumbnails in mp4

Related: #411
 2021-06-16 22:33:32 +05:30
pukkandan 7e87e27c52
[postprocessor] Fix `_restrict_to` when a codec is not set 2021-06-14 14:09:22 +05:30
pukkandan 4d85fbbdbb
Fix bug in 8326b00aab 2021-06-13 14:36:13 +05:30
pukkandan 8326b00aab
Allow `images` formats 
Necessary for #343.

* They are identified by `vcodec=acodec='none'`
* These formats show as the worst in `-F`
* Any postprocessor that expects audio/video will be skipped
* `b*` and all related selectors will skip such formats
* This commit also does not add any selector for downloading such formats. They have to be explicitly requested by the `format_id`. Implementation of a selector is left for when #389 is resolved
 2021-06-13 03:45:53 +05:30
pukkandan 324ad82006
[utils] Generalize `traverse_dict` to `traverse_obj` 2021-06-08 19:26:44 +05:30
pukkandan 752cda3880
Fix and refactor `prepare_outtmpl` 
The following tests would have failed previously:
%(id)d %(id)r
%(ext)s-%(ext|def)d
%(width|)d
%(id)r %(height)r
%(formats.0)r
%s
 2021-06-06 00:59:04 +05:30
pukkandan 337e0c62f8
[embedthumbnail] Correctly escape filename 
Closes #352
The approach in [1] is faulty as can be seen in the test cases
1. bff857a8af
 2021-05-29 02:31:14 +05:30
pukkandan 885cc0b75c
[embedthumbnail] Embed if any thumbnail was downloaded, not just the best 2021-05-29 02:31:14 +05:30
Oliver Freyermuth f17c702270
[ard] Allow URLs without `-` before id 
https://github.com/ytdl-org/youtube-dl/pull/29091

Authored by: olifre
 2021-05-23 23:03:08 +05:30
pukkandan acdecdfaef
[embedthumbnail] Embed in `mp4`/`m4a` using mutagen 
Code from: https://github.com/ytdl-org/youtube-dl/pull/23525
Co-authored by: tripulse , pukkandan
 2021-05-23 22:16:35 +05:30
pukkandan 81a23040eb
[cleanup] Refactor ffmpeg convertors 2021-05-22 15:20:42 +05:30