Fix `--abort-on-error` for subtitles

Closes #3163
This commit is contained in:
pukkandan 2022-03-23 08:26:36 +05:30
parent b9c7b1e9b4
commit c70c418d33
No known key found for this signature in database
GPG Key ID: 7EEE9E1E817D0A39
1 changed files with 5 additions and 2 deletions

View File

@ -3859,9 +3859,12 @@ class YoutubeDL(object):
sub_info['filepath'] = sub_filename sub_info['filepath'] = sub_filename
ret.append((sub_filename, sub_filename_final)) ret.append((sub_filename, sub_filename_final))
except (DownloadError, ExtractorError, IOError, OSError, ValueError) + network_exceptions as err: except (DownloadError, ExtractorError, IOError, OSError, ValueError) + network_exceptions as err:
msg = f'Unable to download video subtitles for {sub_lang!r}: {err}'
if self.params.get('ignoreerrors') is not True: # False or 'only_download' if self.params.get('ignoreerrors') is not True: # False or 'only_download'
raise DownloadError(f'Unable to download video subtitles for {sub_lang!r}: {err}', err) if not self.params.get('ignoreerrors'):
self.report_warning(f'Unable to download video subtitles for {sub_lang!r}: {err}') self.report_error(msg)
raise DownloadError(msg)
self.report_warning(msg)
return ret return ret
def _write_thumbnails(self, label, info_dict, filename, thumb_filename_base=None): def _write_thumbnails(self, label, info_dict, filename, thumb_filename_base=None):