fenix
/
fdk-aac
mirror of https://github.com/mstorsjo/fdk-aac.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Add MPEG-D DRC sanity checks 

Test: atest DecoderTestXheAac ; atest DecoderTestAacDrc

Change-Id: I5413e43d5cfc895b8c3171f8857ca6feab6c269e
This commit is contained in:
Fraunhofer IIS FDK 2018-12-20 15:52:46 +01:00 committed by Jean-Michel Trivi
parent f164a97189
commit 1f908ac9b0
4 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libDRCdec/src/drcDec_reader.cpp
View File

@ -1130,7 +1130,7 @@ static DRC_ERROR _readDrcCoefficientsUniDrc(HANDLE_FDK_BITSTREAM hBs,
drcCharacteristicLeftPresent = FDKreadBits(hBs, 1);
if (drcCharacteristicLeftPresent) {
pCoef->characteristicLeftCount = FDKreadBits(hBs, 4);
if ((pCoef->characteristicLeftCount + 1) > 8) return DE_MEMORY_ERROR;
if ((pCoef->characteristicLeftCount + 1) > 16) return DE_MEMORY_ERROR;
for (i = 0; i < pCoef->characteristicLeftCount; i++) {
err = _readCustomDrcCharacteristic(
hBs, CS_LEFT, &(pCoef->characteristicLeftFormat[i + 1]),
@ -1141,7 +1141,7 @@ static DRC_ERROR _readDrcCoefficientsUniDrc(HANDLE_FDK_BITSTREAM hBs,
drcCharacteristicRightPresent = FDKreadBits(hBs, 1);
if (drcCharacteristicRightPresent) {
pCoef->characteristicRightCount = FDKreadBits(hBs, 4);
if ((pCoef->characteristicRightCount + 1) > 8) return DE_MEMORY_ERROR;
if ((pCoef->characteristicRightCount + 1) > 16) return DE_MEMORY_ERROR;
for (i = 0; i < pCoef->characteristicRightCount; i++) {
err = _readCustomDrcCharacteristic(
hBs, CS_RIGHT, &(pCoef->characteristicRightFormat[i + 1]),

5
libDRCdec/src/drcDec_selectionProcess.cpp
View File

@ -2173,6 +2173,9 @@ static DRCDEC_SELECTION_PROCESS_RETURN _selectDownmixMatrix(
if (hSelProcOutput->activeDownmixId != 0) {
for (i = 0; i < hUniDrcConfig->downmixInstructionsCount; i++) {
DOWNMIX_INSTRUCTIONS* pDown = &(hUniDrcConfig->downmixInstructions[i]);
if (pDown->targetChannelCount > 8) {
continue;
}
if (hSelProcOutput->activeDownmixId == pDown->downmixId) {
hSelProcOutput->targetChannelCount = pDown->targetChannelCount;
@ -2825,6 +2828,8 @@ static int _downmixCoefficientsArePresent(HANDLE_UNI_DRC_CONFIG hUniDrcConfig,
for (i = 0; i < hUniDrcConfig->downmixInstructionsCount; i++) {
if (hUniDrcConfig->downmixInstructions[i].downmixId == downmixId) {
if (hUniDrcConfig->downmixInstructions[i].downmixCoefficientsPresent) {
if (hUniDrcConfig->downmixInstructions[i].targetChannelCount > 8)
return 0;
*pIndex = i;
return 1;
}

8
libDRCdec/src/drcDec_types.h
View File

@ -249,11 +249,11 @@ typedef struct {
UCHAR drcFrameSizePresent;
USHORT drcFrameSize;
UCHAR characteristicLeftCount;
UCHAR characteristicLeftFormat[8];
CUSTOM_DRC_CHAR customCharacteristicLeft[8];
UCHAR characteristicLeftFormat[16];
CUSTOM_DRC_CHAR customCharacteristicLeft[16];
UCHAR characteristicRightCount;
UCHAR characteristicRightFormat[8];
CUSTOM_DRC_CHAR customCharacteristicRight[8];
UCHAR characteristicRightFormat[16];
CUSTOM_DRC_CHAR customCharacteristicRight[16];
UCHAR
gainSequenceCount; /* unsaturated value, i.e. as provided in bitstream */
UCHAR gainSetCount; /* saturated to 12 */

6
libDRCdec/src/drcGainDec_init.cpp
View File

@ -336,9 +336,11 @@ initActiveDrcOffset(HANDLE_DRC_GAIN_DECODER hGainDec) {
for (a = 0; a < hGainDec->nActiveDrcs; a++) {
hGainDec->activeDrc[a].activeDrcOffset = accGainElementCount;
accGainElementCount += hGainDec->activeDrc[a].gainElementCount;
if (accGainElementCount > 12) {
hGainDec->nActiveDrcs = a;
return DE_NOT_OK;
}
}
if (accGainElementCount > 12) return DE_NOT_OK;
return DE_OK;
}