Remove needless background thread and main thread wrappers in setupAdapter

This commit is contained in:
Ensar Sarajčić
2023-07-27 10:50:04 +02:00
parent 68166c318c
commit a0278914ee
2 changed files with 54 additions and 66 deletions

View File

@ -12,7 +12,6 @@ import android.provider.DocumentsContract
import android.util.AttributeSet import android.util.AttributeSet
import android.widget.SeekBar import android.widget.SeekBar
import com.simplemobiletools.commons.extensions.* import com.simplemobiletools.commons.extensions.*
import com.simplemobiletools.commons.helpers.ensureBackgroundThread
import com.simplemobiletools.commons.helpers.isQPlus import com.simplemobiletools.commons.helpers.isQPlus
import com.simplemobiletools.voicerecorder.R import com.simplemobiletools.voicerecorder.R
import com.simplemobiletools.voicerecorder.activities.SimpleActivity import com.simplemobiletools.voicerecorder.activities.SimpleActivity
@ -138,8 +137,6 @@ class PlayerFragment(context: Context, attributeSet: AttributeSet) : MyViewPager
} }
private fun setupAdapter(recordings: ArrayList<Recording>) { private fun setupAdapter(recordings: ArrayList<Recording>) {
ensureBackgroundThread {
Handler(Looper.getMainLooper()).post {
recordings_fastscroller.beVisibleIf(recordings.isNotEmpty()) recordings_fastscroller.beVisibleIf(recordings.isNotEmpty())
recordings_placeholder.beVisibleIf(recordings.isEmpty()) recordings_placeholder.beVisibleIf(recordings.isEmpty())
if (recordings.isEmpty()) { if (recordings.isEmpty()) {
@ -176,8 +173,6 @@ class PlayerFragment(context: Context, attributeSet: AttributeSet) : MyViewPager
adapter.updateItems(recordings) adapter.updateItems(recordings)
} }
} }
}
}
private fun getRecordings(): ArrayList<Recording> { private fun getRecordings(): ArrayList<Recording> {
return context.getAllRecordings().apply { return context.getAllRecordings().apply {

View File

@ -1,11 +1,8 @@
package com.simplemobiletools.voicerecorder.fragments package com.simplemobiletools.voicerecorder.fragments
import android.content.Context import android.content.Context
import android.os.Handler
import android.os.Looper
import android.util.AttributeSet import android.util.AttributeSet
import com.simplemobiletools.commons.extensions.* import com.simplemobiletools.commons.extensions.*
import com.simplemobiletools.commons.helpers.ensureBackgroundThread
import com.simplemobiletools.voicerecorder.R import com.simplemobiletools.voicerecorder.R
import com.simplemobiletools.voicerecorder.activities.SimpleActivity import com.simplemobiletools.voicerecorder.activities.SimpleActivity
import com.simplemobiletools.voicerecorder.adapters.TrashAdapter import com.simplemobiletools.voicerecorder.adapters.TrashAdapter
@ -63,8 +60,6 @@ class TrashFragment(context: Context, attributeSet: AttributeSet) : MyViewPagerF
override fun playRecording(recording: Recording, playOnPrepared: Boolean) {} override fun playRecording(recording: Recording, playOnPrepared: Boolean) {}
private fun setupAdapter(recordings: ArrayList<Recording>) { private fun setupAdapter(recordings: ArrayList<Recording>) {
ensureBackgroundThread {
Handler(Looper.getMainLooper()).post {
recordings_fastscroller.beVisibleIf(recordings.isNotEmpty()) recordings_fastscroller.beVisibleIf(recordings.isNotEmpty())
recordings_placeholder.beVisibleIf(recordings.isEmpty()) recordings_placeholder.beVisibleIf(recordings.isEmpty())
if (recordings.isEmpty()) { if (recordings.isEmpty()) {
@ -91,8 +86,6 @@ class TrashFragment(context: Context, attributeSet: AttributeSet) : MyViewPagerF
adapter.updateItems(recordings) adapter.updateItems(recordings)
} }
} }
}
}
private fun getRecordings(): ArrayList<Recording> { private fun getRecordings(): ArrayList<Recording> {
return context.getAllRecordings(trashed = true).apply { return context.getAllRecordings(trashed = true).apply {