From 414e491661520cb90adcfb0455e0bf46c4ea799a Mon Sep 17 00:00:00 2001
From: Agnieszka C <85929121+Aga-C@users.noreply.github.com>
Date: Sun, 2 Apr 2023 18:54:23 +0200
Subject: [PATCH] Added Opus to ogg name on the UI (#189)
---
.../voicerecorder/activities/SettingsActivity.kt | 2 +-
.../com/simplemobiletools/voicerecorder/helpers/Config.kt | 8 ++++++++
.../voicerecorder/services/RecorderService.kt | 2 +-
app/src/main/res/values/donottranslate.xml | 1 +
4 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/activities/SettingsActivity.kt
index b4ffd91..abae0f9 100644
--- a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/activities/SettingsActivity.kt
+++ b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/activities/SettingsActivity.kt
@@ -146,7 +146,7 @@ class SettingsActivity : SimpleActivity() {
)
if (isQPlus()) {
- items.add(RadioItem(EXTENSION_OGG, getString(R.string.ogg)))
+ items.add(RadioItem(EXTENSION_OGG, getString(R.string.ogg_opus)))
}
RadioGroupDialog(this@SettingsActivity, items, config.extension) {
diff --git a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/helpers/Config.kt b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/helpers/Config.kt
index 8c43862..c0a9055 100644
--- a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/helpers/Config.kt
+++ b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/helpers/Config.kt
@@ -48,6 +48,14 @@ class Config(context: Context) : BaseConfig(context) {
set(recordAfterLaunch) = prefs.edit().putBoolean(RECORD_AFTER_LAUNCH, recordAfterLaunch).apply()
fun getExtensionText() = context.getString(
+ when (extension) {
+ EXTENSION_M4A -> R.string.m4a
+ EXTENSION_OGG -> R.string.ogg_opus
+ else -> R.string.mp3
+ }
+ )
+
+ fun getExtension() = context.getString(
when (extension) {
EXTENSION_M4A -> R.string.m4a
EXTENSION_OGG -> R.string.ogg
diff --git a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/services/RecorderService.kt b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/services/RecorderService.kt
index 335e34c..b2cc9cc 100644
--- a/app/src/main/kotlin/com/simplemobiletools/voicerecorder/services/RecorderService.kt
+++ b/app/src/main/kotlin/com/simplemobiletools/voicerecorder/services/RecorderService.kt
@@ -86,7 +86,7 @@ class RecorderService : Service() {
defaultFolder.absolutePath
}
- currFilePath = "$baseFolder/${getCurrentFormattedDateTime()}.${config.getExtensionText()}"
+ currFilePath = "$baseFolder/${getCurrentFormattedDateTime()}.${config.getExtension()}"
try {
recorder = if (recordMp3()) {
diff --git a/app/src/main/res/values/donottranslate.xml b/app/src/main/res/values/donottranslate.xml
index afa2959..fbc4b65 100644
--- a/app/src/main/res/values/donottranslate.xml
+++ b/app/src/main/res/values/donottranslate.xml
@@ -4,6 +4,7 @@
m4a
mp3
ogg
+ ogg (Opus)
%d kbps