From ffc44a88818c7f0d8220f6d3c879bab774136ad7 Mon Sep 17 00:00:00 2001 From: tibbi Date: Fri, 30 Nov 2018 21:00:11 +0100 Subject: [PATCH] updating Commons, min required Android OS version to 5 --- app/build.gradle | 6 +-- .../thankyou/activities/SettingsActivity.kt | 9 ---- app/src/main/res/layout/activity_settings.xml | 42 ++++--------------- build.gradle | 4 +- 4 files changed, 14 insertions(+), 47 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index cef380b..fe5b18e 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -8,10 +8,10 @@ android { defaultConfig { applicationId "com.simplemobiletools.thankyou" - minSdkVersion 16 + minSdkVersion 21 targetSdkVersion 28 versionCode 11 - versionName "4.1.0" + versionName "5.0.0" setProperty("archivesBaseName", "thank-you") } @@ -41,7 +41,7 @@ android { } dependencies { - implementation 'com.simplemobiletools:commons:4.8.8' + implementation 'com.simplemobiletools:commons:5.5.1' } Properties props = new Properties() diff --git a/app/src/main/kotlin/com/simplemobiletools/thankyou/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/thankyou/activities/SettingsActivity.kt index 39f8858..2580c7b 100644 --- a/app/src/main/kotlin/com/simplemobiletools/thankyou/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/thankyou/activities/SettingsActivity.kt @@ -23,7 +23,6 @@ class SettingsActivity : SimpleActivity() { setupCustomizeColors() setupUseEnglish() - setupAvoidWhatsNew() setupHideLauncherIcon() updateTextColors(settings_holder) } @@ -44,14 +43,6 @@ class SettingsActivity : SimpleActivity() { } } - private fun setupAvoidWhatsNew() { - settings_avoid_whats_new.isChecked = config.avoidWhatsNew - settings_avoid_whats_new_holder.setOnClickListener { - settings_avoid_whats_new.toggle() - config.avoidWhatsNew = settings_avoid_whats_new.isChecked - } - } - private fun setupHideLauncherIcon() { settings_hide_launcher_icon.isChecked = config.hideLauncherIcon settings_hide_launcher_icon_holder.setOnClickListener { diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml index b529194..836e01c 100644 --- a/app/src/main/res/layout/activity_settings.xml +++ b/app/src/main/res/layout/activity_settings.xml @@ -18,18 +18,18 @@ android:layout_height="wrap_content" android:layout_marginTop="@dimen/medium_margin" android:background="?attr/selectableItemBackground" - android:paddingBottom="@dimen/activity_margin" android:paddingLeft="@dimen/normal_margin" + android:paddingTop="@dimen/activity_margin" android:paddingRight="@dimen/normal_margin" - android:paddingTop="@dimen/activity_margin"> + android:paddingBottom="@dimen/activity_margin"> @@ -40,10 +40,10 @@ android:layout_height="wrap_content" android:layout_marginTop="@dimen/medium_margin" android:background="?attr/selectableItemBackground" - android:paddingBottom="@dimen/activity_margin" android:paddingLeft="@dimen/normal_margin" + android:paddingTop="@dimen/activity_margin" android:paddingRight="@dimen/normal_margin" - android:paddingTop="@dimen/activity_margin"> + android:paddingBottom="@dimen/activity_margin"> - - - - - - + android:paddingBottom="@dimen/activity_margin"> diff --git a/build.gradle b/build.gradle index 5aab4c3..1cfbb3a 100644 --- a/build.gradle +++ b/build.gradle @@ -1,7 +1,7 @@ // Top-level build file where you can add configuration options common to all sub-projects/modules. buildscript { - ext.kotlin_version = '1.2.71' + ext.kotlin_version = '1.3.10' repositories { google() @@ -9,7 +9,7 @@ buildscript { } dependencies { - classpath 'com.android.tools.build:gradle:3.2.0' + classpath 'com.android.tools.build:gradle:3.2.1' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version" // NOTE: Do not place your application dependencies here; they belong