From ca1ad0043b32e776a493bbe4e858e8e383f77a27 Mon Sep 17 00:00:00 2001 From: Naveen Date: Fri, 18 Nov 2022 01:01:10 +0530 Subject: [PATCH] Minor messaging code improvement --- .../smsmessenger/helpers/Messaging.kt | 12 ++++-------- .../receivers/ScheduledMessageReceiver.kt | 6 +++++- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Messaging.kt b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Messaging.kt index e4e2ce63..a29b01ae 100644 --- a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Messaging.kt +++ b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/helpers/Messaging.kt @@ -4,8 +4,6 @@ import android.app.AlarmManager import android.app.PendingIntent import android.content.Context import android.content.Intent -import android.os.Handler -import android.os.Looper import androidx.core.app.AlarmManagerCompat import com.klinker.android.send_message.Settings import com.klinker.android.send_message.Transaction @@ -71,12 +69,10 @@ fun Context.sendMessage(text: String, addresses: List, subscriptionId: I transaction.setExplicitBroadcastForSentSms(smsSentIntent) transaction.setExplicitBroadcastForDeliveredSms(deliveredIntent) - Handler(Looper.getMainLooper()).post { - try { - transaction.sendNewMessage(message) - } catch (e: Exception) { - showErrorToast(e) - } + try { + transaction.sendNewMessage(message) + } catch (e: Exception) { + showErrorToast(e) } } diff --git a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/receivers/ScheduledMessageReceiver.kt b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/receivers/ScheduledMessageReceiver.kt index 53c9e020..1b32ca2c 100644 --- a/app/src/main/kotlin/com/simplemobiletools/smsmessenger/receivers/ScheduledMessageReceiver.kt +++ b/app/src/main/kotlin/com/simplemobiletools/smsmessenger/receivers/ScheduledMessageReceiver.kt @@ -3,6 +3,8 @@ package com.simplemobiletools.smsmessenger.receivers import android.content.BroadcastReceiver import android.content.Context import android.content.Intent +import android.os.Handler +import android.os.Looper import android.os.PowerManager import com.simplemobiletools.commons.extensions.showErrorToast import com.simplemobiletools.commons.helpers.ensureBackgroundThread @@ -43,7 +45,9 @@ class ScheduledMessageReceiver : BroadcastReceiver() { val attachments = message.attachment?.attachments ?: emptyList() try { - context.sendMessage(message.body, addresses, message.subscriptionId, attachments) + Handler(Looper.getMainLooper()).post { + context.sendMessage(message.body, addresses, message.subscriptionId, attachments) + } // delete temporary conversation and message as it's already persisted to the telephony db now context.deleteScheduledMessage(messageId)