fenix/Simple-SMS-Messenger
1
0
Fork 0
mirror of https://github.com/SimpleMobileTools/Simple-SMS-Messenger.git synced 2025-06-05 21:49:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

Retain scroll position when deleting messages

Browse Source 
Removed the call to `refreshMessages()` as it's not really needed here and also because it'll reset the scroll position in some cases
This commit is contained in:
Naveen
2022-11-19 22:46:18 +05:30
parent c6d453f5ab
commit 398c2237bc
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/ThreadActivity.kt
View File

@@ -408,6 +408,7 @@ class ThreadActivity : SimpleActivity() {
} }
private fun deleteMessages(messagesToRemove: List<Message>) { private fun deleteMessages(messagesToRemove: List<Message>) {
val deletePosition = threadItems.indexOf(messagesToRemove.first())
messages.removeAll(messagesToRemove.toSet()) messages.removeAll(messagesToRemove.toSet())
threadItems = getThreadItems() threadItems = getThreadItems()
@@ -416,7 +417,7 @@ class ThreadActivity : SimpleActivity() {
finish() finish()
} else { } else {
getOrCreateThreadAdapter().apply { getOrCreateThreadAdapter().apply {
updateMessages(threadItems) updateMessages(threadItems, scrollPosition = deletePosition)
finishActMode() finishActMode()
} }
} }
@@ -441,7 +442,6 @@ class ThreadActivity : SimpleActivity() {
updateScheduledMessagesThreadId(messages, fakeThreadId) updateScheduledMessagesThreadId(messages, fakeThreadId)
threadId = fakeThreadId threadId = fakeThreadId
} }
refreshMessages()
} }
private fun fetchNextMessages() { private fun fetchNextMessages() {

2
app/src/main/kotlin/com/simplemobiletools/smsmessenger/adapters/ThreadAdapter.kt
View File

@@ -230,9 +230,11 @@ class ThreadAdapter(
fun updateMessages(newMessages: ArrayList<ThreadItem>, scrollPosition: Int = newMessages.lastIndex) { fun updateMessages(newMessages: ArrayList<ThreadItem>, scrollPosition: Int = newMessages.lastIndex) {
val latestMessages = newMessages.toMutableList() val latestMessages = newMessages.toMutableList()
submitList(latestMessages) { submitList(latestMessages) {
if (scrollPosition != -1) {
recyclerView.scrollToPosition(scrollPosition) recyclerView.scrollToPosition(scrollPosition)
} }
} }
}
private fun setupView(holder: ViewHolder, view: View, message: Message) { private fun setupView(holder: ViewHolder, view: View, message: Message) {
view.apply { view.apply {