Merge branch 'SimpleMobileTools:master' into rewrite_sms

CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog
 ==========
 
+Version 5.17.1 *(2023-01-06)*
+----------------------------
+
+ * Fixed a glitch with the top Search menu on some devices
+
 Version 5.17.0 *(2023-01-03)*
 ----------------------------
 

app/build.gradle

@@ -16,8 +16,8 @@ android {
         applicationId "com.simplemobiletools.smsmessenger"
         minSdkVersion 23
         targetSdkVersion 33
-        versionCode 68
+        versionCode 69
-        versionName "5.17.0"
+        versionName "5.17.1"
         setProperty("archivesBaseName", "sms-messenger")
     }
 
@@ -63,7 +63,7 @@ android {
 }
 
 dependencies {
-    implementation 'com.github.SimpleMobileTools:Simple-Commons:ae8c57858f'
+    implementation 'com.github.SimpleMobileTools:Simple-Commons:71f9297e2e'
     implementation 'org.greenrobot:eventbus:3.3.1'
     implementation 'com.github.tibbi:IndicatorFastScroll:4524cd0b61'
     implementation 'com.github.tibbi:android-smsmms:33fcaf94d9'

app/src/main/kotlin/com/simplemobiletools/smsmessenger/activities/MainActivity.kt

@@ -141,21 +141,19 @@ class MainActivity : SimpleActivity() {
         main_menu.getToolbar().inflateMenu(R.menu.menu_main)
         main_menu.toggleHideOnScroll(true)
         main_menu.setupMenu()
-        main_menu.onSearchOpenListener = {
-            search_holder.fadeIn()
-            conversations_fab.beGone()
-        }
 
         main_menu.onSearchClosedListener = {
-            search_holder.animate().alpha(0f).setDuration(SHORT_ANIMATION_DURATION).withEndAction {
+            fadeOutSearch()
-                search_holder.beGone()
-                searchTextChanged("", true)
-            }.start()
-
-            conversations_fab.beVisible()
         }
 
         main_menu.onSearchTextChangedListener = { text ->
+            if (text.isNotEmpty()) {
+                if (search_holder.alpha < 1f) {
+                    search_holder.fadeIn()
+                }
+            } else {
+                fadeOutSearch()
+            }
             searchTextChanged(text)
         }
 
@@ -380,6 +378,13 @@ class MainActivity : SimpleActivity() {
         }
     }
 
+    private fun fadeOutSearch() {
+        search_holder.animate().alpha(0f).setDuration(SHORT_ANIMATION_DURATION).withEndAction {
+            search_holder.beGone()
+            searchTextChanged("", true)
+        }.start()
+    }
+
     @SuppressLint("NotifyDataSetChanged")
     private fun notifyDatasetChanged() {
         getOrCreateConversationsAdapter().notifyDataSetChanged()

fastlane/metadata/android/en-US/changelogs/69.txt

@@ -0,0 +1 @@
+* Fixed a glitch with the top Search menu on some devices