fenix
/
Simple-SMS-Messenger
mirror of https://github.com/SimpleMobileTools/Simple-SMS-Messenger.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid modifying items while list is being updated 

`performFiltering` is always called on a worker thread. UI should only be updated in `publishResults`.
This commit is contained in:
Naveen 2023-08-22 18:04:08 +05:30
parent 7135ca44bf
commit 1089d838db
No known key found for this signature in database
GPG Key ID: 0E155DAD31671DA3
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/src/main/kotlin/com/simplemobiletools/smsmessenger/adapters/AutoCompleteTextViewAdapter.kt
View File

@ -51,24 +51,27 @@ class AutoCompleteTextViewAdapter(val activity: SimpleActivity, val contacts: Ar
override fun performFiltering(constraint: CharSequence?): FilterResults { override fun performFiltering(constraint: CharSequence?): FilterResults {
val filterResults = FilterResults() val filterResults = FilterResults()
if (constraint != null) { if (constraint != null) {
resultList.clear() val results = mutableListOf<SimpleContact>()
val searchString = constraint.toString().normalizeString() val searchString = constraint.toString().normalizeString()
contacts.forEach { contacts.forEach {
if (it.doesContainPhoneNumber(searchString) || it.name.contains(searchString, true)) { if (it.doesContainPhoneNumber(searchString) || it.name.contains(searchString, true)) {
resultList.add(it) results.add(it)
} }
} }
resultList.sortWith(compareBy { !it.name.startsWith(searchString, true) }) results.sortWith(compareBy { !it.name.startsWith(searchString, true) })
filterResults.values = resultList filterResults.values = results
filterResults.count = resultList.size filterResults.count = results.size
} }
return filterResults return filterResults
} }
override fun publishResults(constraint: CharSequence?, results: FilterResults?) { override fun publishResults(constraint: CharSequence?, results: FilterResults?) {
if ((results?.count ?: -1) > 0) { if (results != null && results.count > 0) {
resultList.clear()
@Suppress("UNCHECKED_CAST")
resultList.addAll(results.values as List<SimpleContact>)
notifyDataSetChanged() notifyDataSetChanged()
} else { } else {
notifyDataSetInvalidated() notifyDataSetInvalidated()