From f5ccdc45b92baa4edd9219795a92e5446a1c769c Mon Sep 17 00:00:00 2001 From: Tibor Kaputa Date: Sun, 3 Oct 2021 22:54:49 +0200 Subject: [PATCH] avoid calling isCurrentItemChecklist() multiple times --- .../notes/pro/activities/MainActivity.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt index 61e3d0c2..214bbdd4 100644 --- a/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt @@ -156,14 +156,16 @@ class MainActivity : SimpleActivity() { override fun onPrepareOptionsMenu(menu: Menu): Boolean { val multipleNotesExist = mNotes.size > 1 + val isCurrentItemChecklist = isCurrentItemChecklist() + menu.apply { findItem(R.id.rename_note).isVisible = multipleNotesExist findItem(R.id.open_note).isVisible = multipleNotesExist findItem(R.id.delete_note).isVisible = multipleNotesExist findItem(R.id.export_all_notes).isVisible = multipleNotesExist && hasPermission(PERMISSION_WRITE_STORAGE) - findItem(R.id.open_search).isVisible = !isCurrentItemChecklist() - findItem(R.id.remove_done_items).isVisible = isCurrentItemChecklist() - findItem(R.id.sort_checklist).isVisible = isCurrentItemChecklist() + findItem(R.id.open_search).isVisible = !isCurrentItemChecklist + findItem(R.id.remove_done_items).isVisible = isCurrentItemChecklist + findItem(R.id.sort_checklist).isVisible = isCurrentItemChecklist findItem(R.id.import_folder).isVisible = hasPermission(PERMISSION_READ_STORAGE) findItem(R.id.lock_note).isVisible = mNotes.isNotEmpty() && !mCurrentNote.isLocked() findItem(R.id.unlock_note).isVisible = mNotes.isNotEmpty() && mCurrentNote.isLocked()