From bfaee46fc42475f4687ad8d633eea1110519385e Mon Sep 17 00:00:00 2001
From: tibbi <tibor@kaputa.sk>
Date: Sun, 29 Mar 2020 19:56:11 +0200
Subject: [PATCH] do not require any Storage permission at handling intents

---
 .../notes/pro/activities/MainActivity.kt      | 68 +++++++++++++++----
 1 file changed, 54 insertions(+), 14 deletions(-)

diff --git a/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt
index 42a02dcb..b6d7bb06 100644
--- a/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt
+++ b/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt
@@ -234,7 +234,7 @@ class MainActivity : SimpleActivity() {
 
             if (action == Intent.ACTION_VIEW) {
                 val realPath = intent.getStringExtra(REAL_FILE_PATH)
-                if (realPath != null) {
+                if (realPath != null && hasPermission(PERMISSION_READ_STORAGE)) {
                     val file = File(realPath)
                     handleUri(Uri.fromFile(file))
                 } else {
@@ -280,13 +280,9 @@ class MainActivity : SimpleActivity() {
                 return@getNoteIdWithPath
             }
 
-            handlePermission(PERMISSION_WRITE_STORAGE) {
-                if (it) {
-                    NotesHelper(this).getNotes {
-                        mNotes = it
-                        importUri(uri)
-                    }
-                }
+            NotesHelper(this).getNotes {
+                mNotes = it
+                importUri(uri)
             }
         }
     }
@@ -507,7 +503,7 @@ class MainActivity : SimpleActivity() {
 
     private fun openFile() {
         FilePickerDialog(this, canAddShowHiddenButton = true) {
-            openFile(it, true) {
+            checkFile(it, true) {
                 ensureBackgroundThread {
                     val fileText = it.readText().trim()
                     val checklistItems = fileText.parseChecklistItems()
@@ -527,7 +523,7 @@ class MainActivity : SimpleActivity() {
         }
     }
 
-    private fun openFile(path: String, checkTitle: Boolean, onChecksPassed: (file: File) -> Unit) {
+    private fun checkFile(path: String, checkTitle: Boolean, onChecksPassed: (file: File) -> Unit) {
         val file = File(path)
         if (path.isMediaFile()) {
             toast(R.string.invalid_file_format)
@@ -540,6 +536,15 @@ class MainActivity : SimpleActivity() {
         }
     }
 
+    private fun checkUri(uri: Uri, onChecksPassed: () -> Unit) {
+        val inputStream = contentResolver.openInputStream(uri) ?: return
+        if (inputStream.available() > 1000 * 1000) {
+            toast(R.string.file_too_large)
+        } else {
+            onChecksPassed()
+        }
+    }
+
     private fun openFolder(path: String, onChecksPassed: (file: File) -> Unit) {
         val file = File(path)
         if (file.isDirectory) {
@@ -552,17 +557,40 @@ class MainActivity : SimpleActivity() {
             "file" -> openPath(uri.path!!)
             "content" -> {
                 val realPath = getRealPathFromURI(uri)
-                if (realPath != null) {
-                    openPath(realPath)
+                if (hasPermission(PERMISSION_READ_STORAGE)) {
+                    if (realPath != null) {
+                        openPath(realPath)
+                    } else {
+                        R.string.unknown_error_occurred
+                    }
+                } else if (realPath != null && realPath != "") {
+                    checkFile(realPath, false) {
+                        addNoteFromUri(uri, realPath.getFilenameFromPath())
+                    }
                 } else {
-                    R.string.unknown_error_occurred
+                    checkUri(uri) {
+                        addNoteFromUri(uri)
+                    }
                 }
             }
         }
     }
 
+    private fun addNoteFromUri(uri: Uri, filename: String? = null) {
+        val noteTitle = if (filename?.isEmpty() == true) {
+            getNewNoteTitle()
+        } else {
+            filename!!
+        }
+
+        val inputStream = contentResolver.openInputStream(uri)
+        val content = inputStream?.bufferedReader().use { it!!.readText() }
+        val note = Note(null, noteTitle, content, NoteType.TYPE_TEXT.value, "")
+        addNewNote(note)
+    }
+
     private fun openPath(path: String) {
-        openFile(path, false) {
+        checkFile(path, false) {
             val title = path.getFilenameFromPath()
             try {
                 val fileText = it.readText().trim()
@@ -598,6 +626,18 @@ class MainActivity : SimpleActivity() {
         }
     }
 
+    private fun getNewNoteTitle(): String {
+        val base = getString(R.string.text_note)
+        var i = 1
+        while (true) {
+            val tryTitle = "$base $i"
+            if (mNotes.none { it.title == tryTitle }) {
+                return tryTitle
+            }
+            i++
+        }
+    }
+
     private fun tryExportAsFile() {
         handlePermission(PERMISSION_WRITE_STORAGE) {
             if (it) {