From 79285a197ca0a1969b74aea4ad2d6b70a7a1f8eb Mon Sep 17 00:00:00 2001 From: tibbi Date: Mon, 6 Mar 2017 22:07:24 +0100 Subject: [PATCH] fix #69, weird behaviour at renaming note --- .../notes/dialogs/RenameNoteDialog.kt | 2 +- .../notes/fragments/NoteFragment.kt | 2 +- .../simplemobiletools/notes/helpers/DBHelper.kt | 15 ++++++++++++--- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/app/src/main/kotlin/com/simplemobiletools/notes/dialogs/RenameNoteDialog.kt b/app/src/main/kotlin/com/simplemobiletools/notes/dialogs/RenameNoteDialog.kt index a229f931..f4a7dd1f 100644 --- a/app/src/main/kotlin/com/simplemobiletools/notes/dialogs/RenameNoteDialog.kt +++ b/app/src/main/kotlin/com/simplemobiletools/notes/dialogs/RenameNoteDialog.kt @@ -32,7 +32,7 @@ class RenameNoteDialog(val activity: Activity, val db: DBHelper, val note: Note, activity.toast(R.string.title_taken) } else { note.title = title - db.updateNote(note) + db.updateNoteTitle(note) dismiss() callback.invoke(note) } diff --git a/app/src/main/kotlin/com/simplemobiletools/notes/fragments/NoteFragment.kt b/app/src/main/kotlin/com/simplemobiletools/notes/fragments/NoteFragment.kt index 31e7dc42..6cadc6c8 100644 --- a/app/src/main/kotlin/com/simplemobiletools/notes/fragments/NoteFragment.kt +++ b/app/src/main/kotlin/com/simplemobiletools/notes/fragments/NoteFragment.kt @@ -62,7 +62,7 @@ class NoteFragment : Fragment() { val oldText = note.value if (newText != oldText) { note.value = newText - mDb.updateNote(note) + mDb.updateNoteValue(note) context.updateWidget() } } diff --git a/app/src/main/kotlin/com/simplemobiletools/notes/helpers/DBHelper.kt b/app/src/main/kotlin/com/simplemobiletools/notes/helpers/DBHelper.kt index 3d3e7df9..8159cef4 100644 --- a/app/src/main/kotlin/com/simplemobiletools/notes/helpers/DBHelper.kt +++ b/app/src/main/kotlin/com/simplemobiletools/notes/helpers/DBHelper.kt @@ -125,10 +125,19 @@ class DBHelper private constructor(private val mContext: Context) : SQLiteOpenHe return note } - fun updateNote(note: Note) { - val values = fillContentValues(note) + fun updateNoteValue(note: Note) { + val values = ContentValues().apply { put(COL_VALUE, note.value) } + updateNote(note.id, values) + } + + fun updateNoteTitle(note: Note) { + val values = ContentValues().apply { put(COL_TITLE, note.title) } + updateNote(note.id, values) + } + + fun updateNote(id: Int, values: ContentValues) { val selection = "$COL_ID = ?" - val selectionArgs = arrayOf(note.id.toString()) + val selectionArgs = arrayOf(id.toString()) mDb.update(TABLE_NAME, values, selection, selectionArgs) } }