diff --git a/app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/SettingsActivity.kt index 5d80c2fb..758e1e76 100644 --- a/app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/filemanager/pro/activities/SettingsActivity.kt @@ -42,8 +42,29 @@ class SettingsActivity : SimpleActivity() { setupDeleteConfirmation() setupEnableRootAccess() updateTextColors(settings_holder) - setupSectionColors() invalidateOptionsMenu() + + arrayOf( + settings_color_customization_label, + settings_general_settings_label, + settings_visibility_label, + settings_scrolling_label, + settings_file_operations_label, + settings_security_label + ).forEach { + it.setTextColor(getAdjustedPrimaryColor()) + } + + arrayOf( + settings_color_customization_holder, + settings_general_settings_holder, + settings_visibility_holder, + settings_scrolling_holder, + settings_file_operations_holder, + settings_security_holder + ).forEach { + it.background.applyColorFilter(baseConfig.backgroundColor.getContrastColor()) + } } override fun onCreateOptionsMenu(menu: Menu): Boolean { @@ -51,13 +72,6 @@ class SettingsActivity : SimpleActivity() { return super.onCreateOptionsMenu(menu) } - private fun setupSectionColors() { - val adjustedPrimaryColor = getAdjustedPrimaryColor() - arrayListOf(visibility_label, scrolling_label, file_operations_label, security_label).forEach { - it.setTextColor(adjustedPrimaryColor) - } - } - private fun setupCustomizeColors() { settings_customize_colors_holder.setOnClickListener { startCustomizationActivity() @@ -67,6 +81,11 @@ class SettingsActivity : SimpleActivity() { private fun setupUseEnglish() { settings_use_english_holder.beVisibleIf(config.wasUseEnglishToggled || Locale.getDefault().language != "en") settings_use_english.isChecked = config.useEnglish + + if (settings_use_english_holder.isGone()) { + settings_manage_favorites_holder.background = resources.getDrawable(R.drawable.ripple_top_corners, theme) + } + settings_use_english_holder.setOnClickListener { settings_use_english.toggle() config.useEnglish = settings_use_english.isChecked @@ -99,7 +118,8 @@ class SettingsActivity : SimpleActivity() { RadioItem(FONT_SIZE_SMALL, getString(R.string.small)), RadioItem(FONT_SIZE_MEDIUM, getString(R.string.medium)), RadioItem(FONT_SIZE_LARGE, getString(R.string.large)), - RadioItem(FONT_SIZE_EXTRA_LARGE, getString(R.string.extra_large))) + RadioItem(FONT_SIZE_EXTRA_LARGE, getString(R.string.extra_large)) + ) RadioGroupDialog(this@SettingsActivity, items, config.fontSize) { config.fontSize = it as Int @@ -227,6 +247,15 @@ class SettingsActivity : SimpleActivity() { private fun setupEnableRootAccess() { settings_enable_root_access_holder.beVisibleIf(config.isRootAvailable) settings_enable_root_access.isChecked = config.enableRootAccess + + settings_file_deletion_password_protection_holder.background = resources.getDrawable( + if (settings_enable_root_access_holder.isGone()) { + R.drawable.ripple_bottom_corners + } else { + R.drawable.ripple_background + }, theme + ) + settings_enable_root_access_holder.setOnClickListener { if (!config.enableRootAccess) { RootHelpers(this).askRootIfNeeded { diff --git a/app/src/main/res/layout/activity_settings.xml b/app/src/main/res/layout/activity_settings.xml index 85a33d33..6cd80756 100644 --- a/app/src/main/res/layout/activity_settings.xml +++ b/app/src/main/res/layout/activity_settings.xml @@ -1,6 +1,6 @@ @@ -11,390 +11,348 @@ android:layout_height="wrap_content" android:orientation="vertical"> - + android:text="@string/color_customization" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_all_corners"> - + - + + + + android:text="@string/general_settings" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_top_corners"> - + - + - - - - - - - + android:background="@drawable/ripple_background"> - + - + - - - + android:background="@drawable/ripple_background"> - + - + - - - + android:background="@drawable/ripple_background"> - + - + - - - + android:background="@drawable/ripple_background"> - + - + - + - + android:background="@drawable/ripple_bottom_corners"> - + - + + + + android:text="@string/visibility" /> - - - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_all_corners"> - + - + + + + android:text="@string/scrolling" /> - - - - - + android:layout_margin="@dimen/medium_margin" + android:background="@drawable/section_holder_stroke" + android:orientation="vertical"> - + android:background="@drawable/ripple_all_corners"> - + - + + + + android:text="@string/file_operations" /> - + + + android:background="@drawable/ripple_top_corners"> - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +