fenix/Simple-Dialer
1
0
Fork 0
mirror of https://github.com/SimpleMobileTools/Simple-Dialer.git synced 2025-06-05 21:49:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

Avoid overlapping views

Browse Source 
Also removed the unnecessary parent layout
This commit is contained in:
Naveen
2022-11-19 01:34:46 +05:30
parent 7c9d31e159
commit ecc2c18f4d
2 changed files with 114 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/kotlin/com/simplemobiletools/dialer/adapters/RecentCallsAdapter.kt
View File

@@ -274,7 +274,7 @@ class RecentCallsAdapter(
private fun setupView(view: View, call: RecentCall) { private fun setupView(view: View, call: RecentCall) {
view.apply { view.apply {
item_recents_frame.isSelected = selectedKeys.contains(call.id) item_recents_holder.isSelected = selectedKeys.contains(call.id)
var nameToShow = SpannableString(call.name) var nameToShow = SpannableString(call.name)
if (call.specificType.isNotEmpty()) { if (call.specificType.isNotEmpty()) {
nameToShow = SpannableString("${call.name} - ${call.specificType}") nameToShow = SpannableString("${call.name} - ${call.specificType}")

227
app/src/main/res/layout/item_recent_call.xml
View File

@@ -1,132 +1,131 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android" <androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/item_recents_frame" android:id="@+id/item_recents_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:clickable="true" android:clickable="true"
android:focusable="true" android:focusable="true"
android:foreground="@drawable/selector"> android:foreground="@drawable/selector"
android:paddingTop="@dimen/medium_margin"
android:paddingBottom="@dimen/medium_margin">
<androidx.constraintlayout.widget.ConstraintLayout <ImageView
android:id="@+id/item_recents_holder" android:id="@+id/item_recents_image"
android:layout_width="match_parent" android:layout_width="@dimen/normal_icon_size"
android:layout_height="@dimen/normal_icon_size"
android:layout_centerVertical="true"
android:layout_marginStart="@dimen/small_margin"
android:layout_marginEnd="@dimen/small_margin"
android:padding="@dimen/small_margin"
android:src="@drawable/ic_person_vector"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
<TextView
android:id="@+id/item_recents_name"
android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingTop="@dimen/medium_margin" android:layout_marginStart="@dimen/small_margin"
android:paddingBottom="@dimen/medium_margin"> android:layout_marginEnd="@dimen/small_margin"
android:ellipsize="end"
android:maxLines="1"
android:textSize="@dimen/bigger_text_size"
app:layout_constraintBottom_toTopOf="@id/item_recents_date_time"
app:layout_constraintEnd_toStartOf="@+id/overflow_menu_icon"
app:layout_constraintStart_toEndOf="@+id/item_recents_image"
app:layout_constraintTop_toTopOf="parent"
app:layout_constraintVertical_chainStyle="spread_inside"
tools:text="John Doe" />
<ImageView <ImageView
android:id="@+id/item_recents_image" android:id="@+id/item_recents_sim_image"
android:layout_width="@dimen/normal_icon_size" android:layout_width="0dp"
android:layout_height="@dimen/normal_icon_size" android:layout_height="0dp"
android:layout_centerVertical="true" android:layout_marginStart="@dimen/tiny_margin"
android:layout_marginStart="@dimen/small_margin" android:alpha="0.6"
android:layout_marginEnd="@dimen/small_margin" android:padding="@dimen/tiny_margin"
android:padding="@dimen/small_margin" android:src="@drawable/ic_sim_vector"
android:src="@drawable/ic_person_vector" android:visibility="gone"
app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintBottom_toBottomOf="@+id/item_recents_date_time"
app:layout_constraintStart_toStartOf="parent" app:layout_constraintDimensionRatio="1:1"
app:layout_constraintTop_toTopOf="parent" /> app:layout_constraintStart_toEndOf="@+id/item_recents_image"
app:layout_constraintTop_toTopOf="@id/item_recents_date_time"
tools:visibility="visible" />
<TextView <TextView
android:id="@+id/item_recents_name" android:id="@+id/item_recents_sim_id"
android:layout_width="0dp" android:layout_width="0dp"
android:layout_height="wrap_content" android:layout_height="0dp"
android:layout_marginStart="@dimen/small_margin" android:gravity="center"
android:layout_marginEnd="@dimen/small_margin" android:textColor="@color/md_grey_black"
android:ellipsize="end" android:textSize="@dimen/small_text_size"
android:maxLines="1" android:visibility="gone"
android:textSize="@dimen/bigger_text_size" app:layout_constraintBottom_toBottomOf="@+id/item_recents_sim_image"
app:layout_constraintEnd_toStartOf="@+id/overflow_menu_icon" app:layout_constraintEnd_toEndOf="@+id/item_recents_sim_image"
app:layout_constraintStart_toEndOf="@+id/item_recents_image" app:layout_constraintStart_toStartOf="@+id/item_recents_sim_image"
app:layout_constraintTop_toTopOf="parent" app:layout_constraintTop_toTopOf="@+id/item_recents_sim_image"
tools:text="John Doe" /> tools:text="1"
tools:visibility="visible" />
<ImageView <ImageView
android:id="@+id/item_recents_sim_image" android:id="@+id/item_recents_type"
android:layout_width="@dimen/activity_margin" android:layout_width="0dp"
android:layout_height="@dimen/activity_margin" android:layout_height="0dp"
android:layout_marginStart="@dimen/small_margin" android:layout_marginStart="@dimen/tiny_margin"
android:alpha="0.6" android:alpha="0.6"
android:paddingTop="@dimen/tiny_margin" android:padding="@dimen/tiny_margin"
android:paddingBottom="@dimen/tiny_margin" android:src="@drawable/ic_incoming_call_vector"
android:src="@drawable/ic_sim_vector" app:layout_constraintBottom_toBottomOf="@+id/item_recents_date_time"
android:visibility="gone" app:layout_constraintDimensionRatio="1:1"
app:layout_constraintBottom_toBottomOf="@+id/item_recents_date_time" app:layout_constraintEnd_toStartOf="@id/item_recents_date_time"
app:layout_constraintStart_toEndOf="@+id/item_recents_image" app:layout_constraintStart_toEndOf="@+id/item_recents_sim_image"
app:layout_constraintTop_toTopOf="@+id/item_recents_date_time" app:layout_constraintTop_toTopOf="@+id/item_recents_date_time" />
tools:visibility="visible" />
<TextView <TextView
android:id="@+id/item_recents_sim_id" android:id="@+id/item_recents_date_time"
android:layout_width="0dp" android:layout_width="wrap_content"
android:layout_height="0dp" android:layout_height="wrap_content"
android:gravity="center" android:layout_marginStart="@dimen/tiny_margin"
android:textColor="@color/md_grey_black" android:alpha="0.6"
android:textSize="@dimen/small_text_size" android:maxLines="1"
android:visibility="gone" android:textSize="@dimen/normal_text_size"
app:layout_constraintBottom_toBottomOf="@+id/item_recents_sim_image" app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="@+id/item_recents_sim_image" app:layout_constraintStart_toEndOf="@+id/item_recents_type"
app:layout_constraintStart_toStartOf="@+id/item_recents_sim_image" app:layout_constraintTop_toBottomOf="@id/item_recents_name"
app:layout_constraintTop_toTopOf="@+id/item_recents_sim_image" tools:text="18.11.2022" />
tools:text="1" />
<ImageView <TextView
android:id="@+id/item_recents_type" android:id="@+id/item_recents_duration"
android:layout_width="@dimen/activity_margin" android:layout_width="wrap_content"
android:layout_height="@dimen/activity_margin" android:layout_height="wrap_content"
android:layout_marginStart="@dimen/small_margin" android:layout_below="@+id/item_recents_name"
android:alpha="0.6" android:layout_marginEnd="@dimen/small_margin"
android:scaleType="fitStart" android:alpha="0.6"
android:src="@drawable/ic_incoming_call_vector" android:gravity="end"
app:layout_constraintBottom_toBottomOf="@+id/item_recents_date_time" android:textSize="@dimen/normal_text_size"
app:layout_constraintStart_toEndOf="@+id/item_recents_sim_image" app:layout_constraintBottom_toBottomOf="@id/item_recents_date_time"
app:layout_constraintTop_toTopOf="@+id/item_recents_date_time" /> app:layout_constraintEnd_toStartOf="@+id/overflow_menu_icon"
app:layout_constraintTop_toTopOf="@id/item_recents_date_time"
tools:text="00:10" />
<TextView <ImageView
android:id="@+id/item_recents_date_time" android:id="@+id/overflow_menu_icon"
android:layout_width="wrap_content" style="@style/OverflowMenuIconStyle"
android:layout_height="wrap_content" android:layout_width="wrap_content"
android:layout_marginStart="@dimen/small_margin" android:layout_height="wrap_content"
android:alpha="0.6" app:layout_constraintBottom_toBottomOf="parent"
android:maxLines="1" app:layout_constraintEnd_toEndOf="parent"
android:textSize="@dimen/normal_text_size" app:layout_constraintTop_toTopOf="parent" />
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/item_recents_duration"
app:layout_constraintHorizontal_bias="0"
app:layout_constraintStart_toEndOf="@+id/item_recents_type"
tools:text="0123 456 789" />
<TextView <View
android:id="@+id/item_recents_duration" android:id="@+id/overflow_menu_anchor"
android:layout_width="wrap_content" style="@style/OverflowMenuAnchorStyle"
android:layout_height="wrap_content" app:layout_constraintBottom_toBottomOf="parent"
android:layout_below="@+id/item_recents_name" app:layout_constraintEnd_toEndOf="parent"
android:layout_marginEnd="@dimen/small_margin" app:layout_constraintTop_toTopOf="parent" />
android:alpha="0.6"
android:gravity="end"
android:textSize="@dimen/normal_text_size"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toStartOf="@+id/overflow_menu_icon"
tools:text="00:10" />
<ImageView </androidx.constraintlayout.widget.ConstraintLayout>
android:id="@+id/overflow_menu_icon"
style="@style/OverflowMenuIconStyle"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" />
<View
android:id="@+id/overflow_menu_anchor"
style="@style/OverflowMenuAnchorStyle"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintTop_toTopOf="parent" />
</androidx.constraintlayout.widget.ConstraintLayout>
</FrameLayout>