fixing some crashes and ANRs

This commit is contained in:
tibbi 2020-11-04 14:34:55 +01:00
parent b42fc83f8c
commit ad9710cef0
3 changed files with 38 additions and 26 deletions

View File

@ -189,7 +189,9 @@ class ContactsAdapter(activity: SimpleActivity, var contacts: ArrayList<SimpleCo
} }
SimpleContactsHelper(context).loadContactImage(contact.photoUri, findViewById(R.id.item_contact_image), contact.name) if (!activity.isDestroyed) {
SimpleContactsHelper(context).loadContactImage(contact.photoUri, findViewById(R.id.item_contact_image), contact.name)
}
} }
} }
} }

View File

@ -124,9 +124,13 @@ class ContactsFragment(context: Context, attributeSet: AttributeSet) : MyViewPag
} }
} }
} else { } else {
val lookupKey = SimpleContactsHelper(activity!!).getContactLookupKey((contact).rawId.toString()) ensureBackgroundThread {
val publicUri = Uri.withAppendedPath(ContactsContract.Contacts.CONTENT_LOOKUP_URI, lookupKey) val lookupKey = SimpleContactsHelper(activity!!).getContactLookupKey((contact).rawId.toString())
activity!!.launchViewContactIntent(publicUri) val publicUri = Uri.withAppendedPath(ContactsContract.Contacts.CONTENT_LOOKUP_URI, lookupKey)
activity?.runOnUiThread {
activity!!.launchViewContactIntent(publicUri)
}
}
} }
}.apply { }.apply {
fragment_list.adapter = this fragment_list.adapter = this

View File

@ -3,6 +3,8 @@ package com.simplemobiletools.dialer.helpers
import android.annotation.SuppressLint import android.annotation.SuppressLint
import android.content.Context import android.content.Context
import android.net.Uri import android.net.Uri
import android.os.Handler
import android.os.Looper
import android.telecom.Call import android.telecom.Call
import android.telecom.InCallService import android.telecom.InCallService
import android.telecom.VideoProfile import android.telecom.VideoProfile
@ -55,30 +57,34 @@ class CallManager {
} }
fun getCallContact(context: Context, callback: (CallContact?) -> Unit) { fun getCallContact(context: Context, callback: (CallContact?) -> Unit) {
val callContact = CallContact("", "", "") ensureBackgroundThread {
if (call == null || call!!.details == null || call!!.details!!.handle == null) { val callContact = CallContact("", "", "")
callback(callContact) if (call == null || call!!.details == null || call!!.details!!.handle == null) {
return
}
val uri = Uri.decode(call!!.details.handle.toString())
if (uri.startsWith("tel:")) {
val number = uri.substringAfter("tel:")
callContact.number = number
callContact.name = SimpleContactsHelper(context).getNameFromPhoneNumber(number)
callContact.photoUri = SimpleContactsHelper(context).getPhotoUriFromPhoneNumber(number)
if (callContact.name != callContact.number) {
callback(callContact) callback(callContact)
} else { return@ensureBackgroundThread
val privateCursor = context.getMyContactsCursor().loadInBackground() }
ensureBackgroundThread {
val privateContacts = MyContactsContentProvider.getSimpleContacts(context, privateCursor) val uri = Uri.decode(call!!.details.handle.toString())
val privateContact = privateContacts.firstOrNull { it.doesContainPhoneNumber(callContact.number) } if (uri.startsWith("tel:")) {
if (privateContact != null) { val number = uri.substringAfter("tel:")
callContact.name = privateContact.name callContact.number = number
} callContact.name = SimpleContactsHelper(context).getNameFromPhoneNumber(number)
callContact.photoUri = SimpleContactsHelper(context).getPhotoUriFromPhoneNumber(number)
if (callContact.name != callContact.number) {
callback(callContact) callback(callContact)
} else {
Handler(Looper.getMainLooper()).post {
val privateCursor = context.getMyContactsCursor().loadInBackground()
ensureBackgroundThread {
val privateContacts = MyContactsContentProvider.getSimpleContacts(context, privateCursor)
val privateContact = privateContacts.firstOrNull { it.doesContainPhoneNumber(callContact.number) }
if (privateContact != null) {
callContact.name = privateContact.name
}
callback(callContact)
}
}
} }
} }
} }