From 0ddaaceed147606c15070f1007a75e940f7ec6f7 Mon Sep 17 00:00:00 2001 From: Naveen Date: Fri, 2 Sep 2022 18:07:14 +0530 Subject: [PATCH] Minor readability improvement --- .../dialer/activities/DialpadActivity.kt | 6 +----- .../com/simplemobiletools/dialer/extensions/View.kt | 8 ++++++++ 2 files changed, 9 insertions(+), 5 deletions(-) create mode 100644 app/src/main/kotlin/com/simplemobiletools/dialer/extensions/View.kt diff --git a/app/src/main/kotlin/com/simplemobiletools/dialer/activities/DialpadActivity.kt b/app/src/main/kotlin/com/simplemobiletools/dialer/activities/DialpadActivity.kt index 0ca18c9a..fe59ab9c 100644 --- a/app/src/main/kotlin/com/simplemobiletools/dialer/activities/DialpadActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/dialer/activities/DialpadActivity.kt @@ -4,7 +4,6 @@ import android.annotation.SuppressLint import android.annotation.TargetApi import android.content.Intent import android.database.Cursor -import android.graphics.Rect import android.net.Uri import android.os.Build import android.os.Bundle @@ -355,10 +354,7 @@ class DialpadActivity : SimpleActivity() { } } MotionEvent.ACTION_MOVE -> { - val outLocation = IntArray(2) - view.getLocationOnScreen(outLocation) - val rect = Rect(outLocation[0], outLocation[1], outLocation[0] + view.width, outLocation[1] + view.height) - val viewContainsTouchEvent = rect.contains(event.rawX.roundToInt(), event.rawY.roundToInt()) + val viewContainsTouchEvent = view.boundingBox.contains(event.rawX.roundToInt(), event.rawY.roundToInt()) if (!viewContainsTouchEvent) { stopDialpadTone(char) if (longClickable) { diff --git a/app/src/main/kotlin/com/simplemobiletools/dialer/extensions/View.kt b/app/src/main/kotlin/com/simplemobiletools/dialer/extensions/View.kt new file mode 100644 index 00000000..60980027 --- /dev/null +++ b/app/src/main/kotlin/com/simplemobiletools/dialer/extensions/View.kt @@ -0,0 +1,8 @@ +package com.simplemobiletools.dialer.extensions + +import android.graphics.Rect +import android.view.View + +val View.boundingBox + get() = Rect().also { getGlobalVisibleRect(it) } +