fenix/Simple-Contacts
1
0
Fork 0
mirror of https://github.com/SimpleMobileTools/Simple-Contacts.git synced 2025-06-05 21:59:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix #460, removing dividers to make the UI fresher

Browse Source
This commit is contained in:
tibbi
2019-12-05 11:29:46 +01:00
parent 2410669e2d
commit b1e7ab9c63
12 changed files with 65 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/DialpadActivity.kt
View File

@ -187,7 +187,6 @@ class DialpadActivity : SimpleActivity() {
ContactsAdapter(this, filtered, null, LOCATION_DIALPAD, null, dialpad_list, dialpad_fastscroller, text) { ContactsAdapter(this, filtered, null, LOCATION_DIALPAD, null, dialpad_list, dialpad_fastscroller, text) {
callContact(it as Contact) callContact(it as Contact)
}.apply { }.apply {
addVerticalDividers(true)
dialpad_list.adapter = this dialpad_list.adapter = this
} }

1
app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/GroupContactsActivity.kt
View File

@ -106,7 +106,6 @@ class GroupContactsActivity : SimpleActivity(), RemoveFromGroupListener, Refresh
ContactsAdapter(this, contacts, this, LOCATION_GROUP_CONTACTS, this, group_contacts_list, group_contacts_fastscroller) { ContactsAdapter(this, contacts, this, LOCATION_GROUP_CONTACTS, this, group_contacts_list, group_contacts_fastscroller) {
contactClicked(it as Contact) contactClicked(it as Contact)
}.apply { }.apply {
addVerticalDividers(true)
group_contacts_list.adapter = this group_contacts_list.adapter = this
} }

1
app/src/main/kotlin/com/simplemobiletools/contacts/pro/activities/InsertOrEditContactActivity.kt
View File

@ -73,7 +73,6 @@ class InsertOrEditContactActivity : SimpleActivity() {
startActivityForResult(this, START_EDIT_ACTIVITY) startActivityForResult(this, START_EDIT_ACTIVITY)
} }
}.apply { }.apply {
addVerticalDividers(true)
existing_contact_list.adapter = this existing_contact_list.adapter = this
} }

6
app/src/main/kotlin/com/simplemobiletools/contacts/pro/adapters/SelectContactsAdapter.kt
View File

@ -4,7 +4,6 @@ import android.graphics.drawable.Drawable
import android.util.SparseArray import android.util.SparseArray
import android.view.View import android.view.View
import android.view.ViewGroup import android.view.ViewGroup
import androidx.recyclerview.widget.DividerItemDecoration
import androidx.recyclerview.widget.RecyclerView import androidx.recyclerview.widget.RecyclerView
import com.bumptech.glide.Glide import com.bumptech.glide.Glide
import com.bumptech.glide.load.engine.DiskCacheStrategy import com.bumptech.glide.load.engine.DiskCacheStrategy
@ -46,11 +45,6 @@ class SelectContactsAdapter(val activity: SimpleActivity, val contacts: List<Con
if (recyclerView.itemDecorationCount > 0) { if (recyclerView.itemDecorationCount > 0) {
recyclerView.removeItemDecorationAt(0) recyclerView.removeItemDecorationAt(0)
} }
DividerItemDecoration(activity, DividerItemDecoration.VERTICAL).apply {
setDrawable(activity.resources.getDrawable(R.drawable.divider))
recyclerView.addItemDecoration(this)
}
} }
private fun toggleItemSelection(select: Boolean, pos: Int) { private fun toggleItemSelection(select: Boolean, pos: Int) {

2
app/src/main/kotlin/com/simplemobiletools/contacts/pro/fragments/MyViewPagerFragment.kt
View File

@ -162,7 +162,6 @@ abstract class MyViewPagerFragment(context: Context, attributeSet: AttributeSet)
activity!!.startActivity(this) activity!!.startActivity(this)
} }
}.apply { }.apply {
addVerticalDividers(true)
fragment_list.adapter = this fragment_list.adapter = this
} }
@ -191,7 +190,6 @@ abstract class MyViewPagerFragment(context: Context, attributeSet: AttributeSet)
ContactsAdapter(activity as SimpleActivity, contacts, activity, location, null, fragment_list, fragment_fastscroller) { ContactsAdapter(activity as SimpleActivity, contacts, activity, location, null, fragment_list, fragment_fastscroller) {
activity?.contactClicked(it as Contact) activity?.contactClicked(it as Contact)
}.apply { }.apply {
addVerticalDividers(true)
fragment_list.adapter = this fragment_list.adapter = this
} }

15
app/src/main/res/layout/activity_insert_edit_contact.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<RelativeLayout <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/insert_edit_contact_holder" android:id="@+id/insert_edit_contact_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -11,25 +10,28 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:background="?attr/selectableItemBackground" android:background="?attr/selectableItemBackground"
android:paddingEnd="@dimen/activity_margin"> android:paddingTop="@dimen/medium_margin"
android:paddingEnd="@dimen/activity_margin"
android:paddingBottom="@dimen/medium_margin">
<ImageView <ImageView
android:id="@+id/new_contact_tmb" android:id="@+id/new_contact_tmb"
android:layout_width="@dimen/normal_icon_size" android:layout_width="@dimen/normal_icon_size"
android:layout_height="@dimen/normal_icon_size" android:layout_height="@dimen/normal_icon_size"
android:layout_alignTop="@+id/new_contact_name" android:layout_centerVertical="true"
android:layout_alignBottom="@+id/new_contact_name"
android:padding="@dimen/medium_margin" android:padding="@dimen/medium_margin"
android:src="@drawable/ic_new_contact_vector" /> android:src="@drawable/ic_new_contact_vector" />
<com.simplemobiletools.commons.views.MyTextView <com.simplemobiletools.commons.views.MyTextView
android:id="@+id/new_contact_name" android:id="@+id/new_contact_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/create_new_contact_height" android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_toEndOf="@+id/new_contact_tmb" android:layout_toEndOf="@+id/new_contact_tmb"
android:ellipsize="end" android:ellipsize="end"
android:gravity="center_vertical" android:gravity="center_vertical"
android:maxLines="1" android:maxLines="1"
android:paddingStart="@dimen/small_margin"
android:text="@string/create_new_contact" android:text="@string/create_new_contact"
android:textSize="@dimen/big_text_size" /> android:textSize="@dimen/big_text_size" />
@ -42,6 +44,7 @@
android:layout_below="@+id/new_contact_holder" android:layout_below="@+id/new_contact_holder"
android:layout_marginStart="@dimen/bigger_margin" android:layout_marginStart="@dimen/bigger_margin"
android:layout_marginLeft="@dimen/bigger_margin" android:layout_marginLeft="@dimen/bigger_margin"
android:layout_marginTop="@dimen/small_margin"
android:layout_marginBottom="@dimen/activity_margin" android:layout_marginBottom="@dimen/activity_margin"
android:text="@string/add_to_existing_contact" android:text="@string/add_to_existing_contact"
android:textAllCaps="true" android:textAllCaps="true"

15
app/src/main/res/layout/item_add_favorite_with_number.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/contact_frame" android:id="@+id/contact_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -12,8 +11,10 @@
<RelativeLayout <RelativeLayout
android:id="@+id/contact_holder" android:id="@+id/contact_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:paddingEnd="@dimen/normal_margin"> android:paddingTop="@dimen/medium_margin"
android:paddingEnd="@dimen/normal_margin"
android:paddingBottom="@dimen/medium_margin">
<ImageView <ImageView
android:id="@+id/contact_tmb" android:id="@+id/contact_tmb"
@ -27,13 +28,11 @@
android:id="@+id/contact_name" android:id="@+id/contact_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignTop="@+id/contact_tmb"
android:layout_toStartOf="@+id/contact_checkbox" android:layout_toStartOf="@+id/contact_checkbox"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:ellipsize="end" android:ellipsize="end"
android:maxLines="1" android:maxLines="1"
android:paddingStart="@dimen/small_margin" android:paddingStart="@dimen/small_margin"
android:paddingTop="@dimen/small_margin"
android:paddingEnd="@dimen/small_margin" android:paddingEnd="@dimen/small_margin"
android:textSize="@dimen/bigger_text_size" android:textSize="@dimen/bigger_text_size"
tools:text="John Doe" /> tools:text="John Doe" />
@ -46,6 +45,7 @@
android:layout_alignStart="@+id/contact_name" android:layout_alignStart="@+id/contact_name"
android:layout_toStartOf="@+id/contact_checkbox" android:layout_toStartOf="@+id/contact_checkbox"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:alpha="0.6"
android:maxLines="1" android:maxLines="1"
android:textSize="@dimen/bigger_text_size" android:textSize="@dimen/bigger_text_size"
tools:text="0123 456 789" /> tools:text="0123 456 789" />
@ -53,8 +53,9 @@
<com.simplemobiletools.commons.views.MyAppCompatCheckbox <com.simplemobiletools.commons.views.MyAppCompatCheckbox
android:id="@+id/contact_checkbox" android:id="@+id/contact_checkbox"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:layout_centerVertical="true"
android:clickable="false" android:clickable="false"
android:gravity="center_vertical" /> android:gravity="center_vertical" />

13
app/src/main/res/layout/item_add_favorite_without_number.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/contact_frame" android:id="@+id/contact_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -13,7 +12,9 @@
android:id="@+id/contact_holder" android:id="@+id/contact_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingEnd="@dimen/normal_margin"> android:paddingTop="@dimen/tiny_margin"
android:paddingEnd="@dimen/normal_margin"
android:paddingBottom="@dimen/tiny_margin">
<ImageView <ImageView
android:id="@+id/contact_tmb" android:id="@+id/contact_tmb"
@ -26,7 +27,8 @@
<TextView <TextView
android:id="@+id/contact_name" android:id="@+id/contact_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_toStartOf="@+id/contact_checkbox" android:layout_toStartOf="@+id/contact_checkbox"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:ellipsize="end" android:ellipsize="end"
@ -38,8 +40,9 @@
<com.simplemobiletools.commons.views.MyAppCompatCheckbox <com.simplemobiletools.commons.views.MyAppCompatCheckbox
android:id="@+id/contact_checkbox" android:id="@+id/contact_checkbox"
android:layout_width="wrap_content" android:layout_width="wrap_content"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:layout_alignParentEnd="true" android:layout_alignParentEnd="true"
android:layout_centerVertical="true"
android:clickable="false" android:clickable="false"
android:gravity="center_vertical" /> android:gravity="center_vertical" />

15
app/src/main/res/layout/item_contact_with_number.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/contact_frame" android:id="@+id/contact_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -13,14 +12,16 @@
<RelativeLayout <RelativeLayout
android:id="@+id/contact_holder" android:id="@+id/contact_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/contact_item_with_number_height" android:layout_height="wrap_content"
android:paddingTop="@dimen/tiny_margin" android:paddingTop="@dimen/medium_margin"
android:paddingEnd="@dimen/activity_margin"> android:paddingEnd="@dimen/activity_margin"
android:paddingBottom="@dimen/medium_margin">
<ImageView <ImageView
android:id="@+id/contact_tmb" android:id="@+id/contact_tmb"
android:layout_width="@dimen/normal_icon_size" android:layout_width="@dimen/normal_icon_size"
android:layout_height="match_parent" android:layout_height="@dimen/normal_icon_size"
android:layout_centerVertical="true"
android:padding="@dimen/medium_margin" android:padding="@dimen/medium_margin"
android:src="@drawable/ic_person_vector" /> android:src="@drawable/ic_person_vector" />
@ -28,7 +29,6 @@
android:id="@+id/contact_name" android:id="@+id/contact_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignTop="@+id/contact_tmb"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:ellipsize="end" android:ellipsize="end"
android:maxLines="1" android:maxLines="1"
@ -42,6 +42,7 @@
android:layout_below="@+id/contact_name" android:layout_below="@+id/contact_name"
android:layout_alignStart="@+id/contact_name" android:layout_alignStart="@+id/contact_name"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:alpha="0.6"
android:maxLines="1" android:maxLines="1"
android:textSize="@dimen/bigger_text_size" android:textSize="@dimen/bigger_text_size"
tools:text="0123 456 789" /> tools:text="0123 456 789" />

12
app/src/main/res/layout/item_contact_without_number.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/contact_frame" android:id="@+id/contact_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -14,20 +13,23 @@
android:id="@+id/contact_holder" android:id="@+id/contact_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingEnd="@dimen/activity_margin"> android:paddingTop="@dimen/small_margin"
android:paddingEnd="@dimen/activity_margin"
android:paddingBottom="@dimen/small_margin">
<ImageView <ImageView
android:id="@+id/contact_tmb" android:id="@+id/contact_tmb"
android:layout_width="@dimen/normal_icon_size" android:layout_width="@dimen/normal_icon_size"
android:layout_height="@dimen/normal_icon_size" android:layout_height="@dimen/normal_icon_size"
android:layout_marginTop="@dimen/tiny_margin" android:layout_centerVertical="true"
android:padding="@dimen/medium_margin" android:padding="@dimen/medium_margin"
android:src="@drawable/ic_person_vector" /> android:src="@drawable/ic_person_vector" />
<TextView <TextView
android:id="@+id/contact_name" android:id="@+id/contact_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_toEndOf="@+id/contact_tmb" android:layout_toEndOf="@+id/contact_tmb"
android:ellipsize="end" android:ellipsize="end"
android:gravity="center_vertical" android:gravity="center_vertical"

10
app/src/main/res/layout/item_group.xml
View File

@ -1,6 +1,5 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<FrameLayout <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools" xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/group_frame" android:id="@+id/group_frame"
android:layout_width="match_parent" android:layout_width="match_parent"
@ -14,7 +13,9 @@
android:id="@+id/group_holder" android:id="@+id/group_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:paddingEnd="@dimen/activity_margin"> android:paddingTop="@dimen/tiny_margin"
android:paddingEnd="@dimen/activity_margin"
android:paddingBottom="@dimen/tiny_margin">
<ImageView <ImageView
android:id="@+id/group_tmb" android:id="@+id/group_tmb"
@ -27,7 +28,8 @@
<TextView <TextView
android:id="@+id/group_name" android:id="@+id/group_name"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="@dimen/contact_item_height" android:layout_height="wrap_content"
android:layout_centerVertical="true"
android:layout_toEndOf="@+id/group_tmb" android:layout_toEndOf="@+id/group_tmb"
android:ellipsize="end" android:ellipsize="end"
android:gravity="center_vertical" android:gravity="center_vertical"

3
app/src/main/res/values/dimens.xml
View File

@ -3,9 +3,6 @@
<dimen name="contact_photo_size">88dp</dimen> <dimen name="contact_photo_size">88dp</dimen>
<dimen name="contact_actions_size">48dp</dimen> <dimen name="contact_actions_size">48dp</dimen>
<dimen name="contact_icons_size">40dp</dimen> <dimen name="contact_icons_size">40dp</dimen>
<dimen name="contact_item_height">52dp</dimen>
<dimen name="contact_item_with_number_height">56dp</dimen>
<dimen name="create_new_contact_height">68dp</dimen>
<dimen name="dialpad_button_size">60dp</dimen> <dimen name="dialpad_button_size">60dp</dimen>
<dimen name="dialpad_text_size">34sp</dimen> <dimen name="dialpad_text_size">34sp</dimen>