From c69e34a9b4832456041a843c6e5a32f1251b2376 Mon Sep 17 00:00:00 2001 From: tibbi Date: Wed, 30 May 2018 11:10:56 +0200 Subject: [PATCH] make sure flashlight changes are ignored if the device has no flashlight --- .../com/simplemobiletools/camera/activities/MainActivity.kt | 1 - .../com/simplemobiletools/camera/views/PreviewCameraTwo.kt | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt index d26e3896..f3190670 100644 --- a/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt @@ -453,7 +453,6 @@ class MainActivity : SimpleActivity(), PreviewListener, PhotoProcessor.MediaSave showToggleCameraIfNeeded() if (mPreview?.resumeCamera() == true) { hideNavigationBarIcons() - mPreview?.checkFlashlight() if (!mIsInPhotoMode) { initVideoButtons() diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/views/PreviewCameraTwo.kt b/app/src/main/kotlin/com/simplemobiletools/camera/views/PreviewCameraTwo.kt index c81ffa8c..336afb91 100644 --- a/app/src/main/kotlin/com/simplemobiletools/camera/views/PreviewCameraTwo.kt +++ b/app/src/main/kotlin/com/simplemobiletools/camera/views/PreviewCameraTwo.kt @@ -444,6 +444,7 @@ class PreviewCameraTwo : ViewGroup, TextureView.SurfaceTextureListener, MyPrevie } override fun toggleFrontBackCamera() { + mUseFrontCamera = !mUseFrontCamera } override fun toggleFlashlight() { @@ -472,7 +473,7 @@ class PreviewCameraTwo : ViewGroup, TextureView.SurfaceTextureListener, MyPrevie } override fun checkFlashlight() { - if (mCameraState == STATE_PREVIEW) { + if (mCameraState == STATE_PREVIEW && mIsFlashSupported) { mPreviewRequestBuilder!!.set(CaptureRequest.FLASH_MODE, getFlashlightMode(mFlashlightState)) mCaptureSession!!.setRepeatingRequest(mPreviewRequestBuilder!!.build(), mCaptureCallback, mBackgroundHandler) mActivity.updateFlashlightState(mFlashlightState)