fix warnings in activity_main

- add contentDescription attribute on the ImageView icons for accessibility
This commit is contained in:
darthpaul 2022-07-13 16:16:17 +01:00
parent 44223d4ba9
commit 6bc74d8066
2 changed files with 23 additions and 7 deletions

View File

@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/view_holder" android:id="@+id/view_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
@ -10,7 +11,7 @@
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" /> android:layout_height="match_parent" />
<ImageView <View
android:id="@+id/capture_black_screen" android:id="@+id/capture_black_screen"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="match_parent" android:layout_height="match_parent"
@ -21,7 +22,8 @@
android:id="@+id/settings" android:id="@+id/settings"
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_alignParentRight="true" android:layout_alignParentEnd="true"
android:contentDescription="@string/settings"
android:padding="@dimen/normal_margin" android:padding="@dimen/normal_margin"
android:src="@drawable/ic_settings_cog_vector" /> android:src="@drawable/ic_settings_cog_vector" />
@ -30,7 +32,8 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_below="@+id/settings" android:layout_below="@+id/settings"
android:layout_alignParentRight="true" android:layout_alignParentEnd="true"
android:contentDescription="@string/toggle_photo_video"
android:padding="@dimen/normal_margin" android:padding="@dimen/normal_margin"
android:src="@drawable/ic_video_vector" /> android:src="@drawable/ic_video_vector" />
@ -39,7 +42,8 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_below="@+id/toggle_photo_video" android:layout_below="@+id/toggle_photo_video"
android:layout_alignParentRight="true" android:layout_alignParentEnd="true"
android:contentDescription="@string/resolution"
android:padding="@dimen/normal_margin" android:padding="@dimen/normal_margin"
android:src="@drawable/ic_resolution_vector" /> android:src="@drawable/ic_resolution_vector" />
@ -48,13 +52,15 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_below="@+id/change_resolution" android:layout_below="@+id/change_resolution"
android:layout_alignParentRight="true" android:layout_alignParentEnd="true"
android:contentDescription="@string/view_last_media"
android:padding="@dimen/medium_margin" /> android:padding="@dimen/medium_margin" />
<LinearLayout <LinearLayout
android:id="@+id/btn_holder" android:id="@+id/btn_holder"
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignParentBottom="true" android:layout_alignParentBottom="true"
android:gravity="center_horizontal|bottom"> android:gravity="center_horizontal|bottom">
@ -63,6 +69,7 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_weight="1" android:layout_weight="1"
android:contentDescription="@string/toggle_camera"
android:padding="@dimen/normal_margin" android:padding="@dimen/normal_margin"
android:src="@drawable/ic_camera_front_vector" /> android:src="@drawable/ic_camera_front_vector" />
@ -71,6 +78,7 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_weight="1" android:layout_weight="1"
android:contentDescription="@string/shutter"
android:src="@drawable/ic_shutter_vector" /> android:src="@drawable/ic_shutter_vector" />
<ImageView <ImageView
@ -78,6 +86,7 @@
android:layout_width="@dimen/icon_size" android:layout_width="@dimen/icon_size"
android:layout_height="@dimen/icon_size" android:layout_height="@dimen/icon_size"
android:layout_weight="1" android:layout_weight="1"
android:contentDescription="@string/toggle_flash"
android:padding="@dimen/normal_margin" android:padding="@dimen/normal_margin"
android:src="@drawable/ic_flash_off_vector" /> android:src="@drawable/ic_flash_off_vector" />
@ -89,8 +98,8 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_above="@+id/btn_holder" android:layout_above="@+id/btn_holder"
android:layout_centerHorizontal="true" android:layout_centerHorizontal="true"
android:text="00:00"
android:textColor="@android:color/white" android:textColor="@android:color/white"
android:visibility="gone" /> android:visibility="gone"
tools:text="00:00" />
</RelativeLayout> </RelativeLayout>

View File

@ -24,6 +24,13 @@
<string name="photo_capture_failed">Photo capture failed</string> <string name="photo_capture_failed">Photo capture failed</string>
<string name="video_capture_insufficient_storage_error">Video recording failed due to insufficient storage</string> <string name="video_capture_insufficient_storage_error">Video recording failed due to insufficient storage</string>
<!--Camera Screen Icons Content Description-->
<string name="toggle_photo_video">Toggle photo/video mode</string>
<string name="change_resolution">Change Resolution</string>
<string name="view_last_media">View last captured media</string>
<string name="toggle_camera">Toggle front/back camera</string>
<string name="toggle_flash">Toggle the flashlight mode</string>
<!-- FAQ --> <!-- FAQ -->
<string name="faq_1_title">What photo compression quality should I set?</string> <string name="faq_1_title">What photo compression quality should I set?</string>
<string name="faq_1_text">It depends on your goal. For generic purposes most people advise using 75%-80%, when the image is still really good quality, but the file size is reduced drastically compared to 100%.</string> <string name="faq_1_text">It depends on your goal. For generic purposes most people advise using 75%-80%, when the image is still really good quality, but the file size is reduced drastically compared to 100%.</string>