diff --git a/app/src/main/java/com/simplemobiletools/camera/PhotoProcessor.kt b/app/src/main/java/com/simplemobiletools/camera/PhotoProcessor.kt index be2a7ad3..e8abda60 100644 --- a/app/src/main/java/com/simplemobiletools/camera/PhotoProcessor.kt +++ b/app/src/main/java/com/simplemobiletools/camera/PhotoProcessor.kt @@ -5,8 +5,8 @@ import android.os.AsyncTask import android.os.Environment import android.util.Log import com.simplemobiletools.camera.activities.MainActivity -import com.simplemobiletools.camera.extensions.getFileDocument -import com.simplemobiletools.camera.extensions.needsStupidWritePermissions +import com.simplemobiletools.filepicker.extensions.getFileDocument +import com.simplemobiletools.filepicker.extensions.needsStupidWritePermissions import java.io.* import java.lang.ref.WeakReference @@ -44,7 +44,7 @@ class PhotoProcessor(val activity: MainActivity, val uri: Uri?) : AsyncTask 0 && hasNavBar(res)) { - return res.getDimensionPixelSize(id) - } - - return 0 + return if (id > 0 && hasNavBar(res)) { + res.getDimensionPixelSize(id) + } else + 0 } fun hasNavBar(res: Resources): Boolean { @@ -103,20 +100,14 @@ class Utils { return id > 0 && res.getBoolean(id) } - fun hasCameraPermission(cxt: Context): Boolean { - return ContextCompat.checkSelfPermission(cxt, Manifest.permission.CAMERA) == PackageManager.PERMISSION_GRANTED - } + fun hasCameraPermission(context: Context) = ContextCompat.checkSelfPermission(context, Manifest.permission.CAMERA) == PackageManager.PERMISSION_GRANTED - fun hasStoragePermission(cxt: Context): Boolean { - return ContextCompat.checkSelfPermission(cxt, Manifest.permission.WRITE_EXTERNAL_STORAGE) == PackageManager.PERMISSION_GRANTED - } + fun hasStoragePermission(context: Context) = context.hasStoragePermission() - fun hasAudioPermission(cxt: Context): Boolean { - return ContextCompat.checkSelfPermission(cxt, Manifest.permission.RECORD_AUDIO) == PackageManager.PERMISSION_GRANTED - } + fun hasAudioPermission(cxt: Context) = ContextCompat.checkSelfPermission(cxt, Manifest.permission.RECORD_AUDIO) == PackageManager.PERMISSION_GRANTED - fun needsStupidWritePermissions(context: Context, path: String) = context.isPathOnSD(path) && context.isKitkat() + fun needsStupidWritePermissions(context: Context, path: String) = context.needsStupidWritePermissions(path) - fun getFileDocument(context: Context, path: String) = context.getFileDocument(path) + fun getFileDocument(context: Context, path: String, treeUri: String) = context.getFileDocument(path, treeUri) } } diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/activities/SettingsActivity.kt b/app/src/main/kotlin/com/simplemobiletools/camera/activities/SettingsActivity.kt index 8f1ee456..05fb9b32 100644 --- a/app/src/main/kotlin/com/simplemobiletools/camera/activities/SettingsActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/camera/activities/SettingsActivity.kt @@ -13,10 +13,10 @@ import android.widget.AdapterView import com.simplemobiletools.camera.Constants import com.simplemobiletools.camera.R import com.simplemobiletools.camera.dialogs.WritePermissionDialog -import com.simplemobiletools.camera.extensions.needsStupidWritePermissions import com.simplemobiletools.filepicker.dialogs.FilePickerDialog import com.simplemobiletools.filepicker.extensions.getBasePath import com.simplemobiletools.filepicker.extensions.getHumanReadablePath +import com.simplemobiletools.filepicker.extensions.needsStupidWritePermissions import kotlinx.android.synthetic.main.activity_settings.* import java.io.File @@ -100,9 +100,7 @@ class SettingsActivity : SimpleActivity() { path } - private fun getStorageName(basePath: String): String { - return getHumanReadablePath(basePath) + "/" - } + private fun getStorageName(basePath: String) = getHumanReadablePath(basePath) + "/" @TargetApi(Build.VERSION_CODES.KITKAT) override fun onActivityResult(requestCode: Int, resultCode: Int, resultData: Intent?) { diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/extensions/Context.kt b/app/src/main/kotlin/com/simplemobiletools/camera/extensions/Context.kt deleted file mode 100644 index afd36e14..00000000 --- a/app/src/main/kotlin/com/simplemobiletools/camera/extensions/Context.kt +++ /dev/null @@ -1,26 +0,0 @@ -package com.simplemobiletools.camera.extensions - -import android.content.Context -import android.net.Uri -import android.os.Build -import android.support.v4.provider.DocumentFile -import com.simplemobiletools.camera.Config -import com.simplemobiletools.filepicker.extensions.getSDCardPath - -fun Context.needsStupidWritePermissions(path: String) = isPathOnSD(path) && isKitkat() && !getSDCardPath().isEmpty() - -fun Context.isPathOnSD(path: String) = path.startsWith(getSDCardPath()) - -fun Context.isKitkat() = Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.KITKAT - -fun Context.getFileDocument(path: String): DocumentFile { - val relativePath = path.substring(getSDCardPath().length + 1) - var document = DocumentFile.fromTreeUri(this, Uri.parse(Config.newInstance(this).treeUri)) - val parts = relativePath.split("/") - for (part in parts) { - val currDocument = document.findFile(part) - if (currDocument != null) - document = currDocument - } - return document -}