diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt b/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt index 38e9ccc2..0940abf9 100644 --- a/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt +++ b/app/src/main/kotlin/com/simplemobiletools/camera/activities/MainActivity.kt @@ -14,7 +14,6 @@ import android.provider.MediaStore import android.view.* import android.widget.LinearLayout import androidx.appcompat.content.res.AppCompatResources -import androidx.constraintlayout.widget.ConstraintLayout import androidx.core.content.ContextCompat import androidx.core.view.* import androidx.transition.* @@ -38,10 +37,16 @@ import com.simplemobiletools.camera.views.FocusCircleView import com.simplemobiletools.commons.extensions.* import com.simplemobiletools.commons.helpers.* import com.simplemobiletools.commons.models.Release -import kotlinx.android.synthetic.main.activity_main.* -import kotlinx.android.synthetic.main.layout_flash.* -import kotlinx.android.synthetic.main.layout_top.* import java.util.concurrent.TimeUnit +import kotlinx.android.synthetic.main.activity_main.* +import kotlinx.android.synthetic.main.layout_flash.flash_auto +import kotlinx.android.synthetic.main.layout_flash.flash_off +import kotlinx.android.synthetic.main.layout_flash.flash_on +import kotlinx.android.synthetic.main.layout_flash.flash_toggle_group +import kotlinx.android.synthetic.main.layout_top.change_resolution +import kotlinx.android.synthetic.main.layout_top.default_icons +import kotlinx.android.synthetic.main.layout_top.settings +import kotlinx.android.synthetic.main.layout_top.toggle_flash class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, CameraXPreviewListener { private companion object { @@ -300,9 +305,8 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera } val marginBottom = safeInsetBottom + navigationBarHeight + resources.getDimensionPixelSize(R.dimen.bigger_margin) - (shutter.layoutParams as ConstraintLayout.LayoutParams).goneBottomMargin = marginBottom - video_rec_curr_timer.updateLayoutParams { + shutter.updateLayoutParams { bottomMargin = marginBottom } @@ -342,7 +346,7 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera mTimerHandler = Handler(Looper.getMainLooper()) setupPreviewImage(true) - val initialFlashlightState = FLASH_OFF + val initialFlashlightState = if (mIsInPhotoMode) config.flashlightState else FLASH_OFF mPreview!!.setFlashlightState(initialFlashlightState) updateFlashlightState(initialFlashlightState) initFlashModeTransitionNames() @@ -395,7 +399,7 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera } } - fun updateFlashlightState(state: Int) { + private fun updateFlashlightState(state: Int) { config.flashlightState = state val flashDrawable = when (state) { FLASH_OFF -> R.drawable.ic_flash_off_vector @@ -687,6 +691,7 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera shutter.isSelected = true toggle_camera.beInvisible() change_resolution.isEnabled = false + settings.isEnabled = false video_rec_curr_timer.beVisible() } @@ -696,6 +701,7 @@ class MainActivity : SimpleActivity(), PhotoProcessor.MediaSavedListener, Camera video_rec_curr_timer.text = 0.getFormattedDuration() video_rec_curr_timer.beGone() change_resolution.isEnabled = true + settings.isEnabled = true toggle_camera.beVisible() } diff --git a/app/src/main/kotlin/com/simplemobiletools/camera/helpers/ImageQualityManager.kt b/app/src/main/kotlin/com/simplemobiletools/camera/helpers/ImageQualityManager.kt index 9177c781..3792d261 100644 --- a/app/src/main/kotlin/com/simplemobiletools/camera/helpers/ImageQualityManager.kt +++ b/app/src/main/kotlin/com/simplemobiletools/camera/helpers/ImageQualityManager.kt @@ -64,6 +64,7 @@ class ImageQualityManager( .flatMap { it.qualities } .sortedByDescending { it.pixels } .distinctBy { it.getAspectRatio(activity) } + .sortedByDescending { it.getAspectRatio(activity).split(":").firstOrNull()?.toIntOrNull() } .filter { it.isSupported(fullScreenSize.isSixteenToNine()) } } diff --git a/app/src/main/res/drawable/ic_resolution_vector.xml b/app/src/main/res/drawable/ic_resolution_vector.xml deleted file mode 100644 index 5aa7aa03..00000000 --- a/app/src/main/res/drawable/ic_resolution_vector.xml +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/src/main/res/drawable/ic_settings.xml b/app/src/main/res/drawable/ic_settings.xml new file mode 100644 index 00000000..7e6bf97f --- /dev/null +++ b/app/src/main/res/drawable/ic_settings.xml @@ -0,0 +1,11 @@ + + + + + diff --git a/app/src/main/res/drawable/ic_video_vector.xml b/app/src/main/res/drawable/ic_video_vector.xml deleted file mode 100644 index 73731d90..00000000 --- a/app/src/main/res/drawable/ic_video_vector.xml +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml index d26a0659..50eb37ae 100644 --- a/app/src/main/res/layout/activity_main.xml +++ b/app/src/main/res/layout/activity_main.xml @@ -75,6 +75,21 @@ + + + + app:layout_constraintVertical_bias="1" /> - - diff --git a/app/src/main/res/layout/layout_top.xml b/app/src/main/res/layout/layout_top.xml index 0fa7f66e..7e671fbb 100644 --- a/app/src/main/res/layout/layout_top.xml +++ b/app/src/main/res/layout/layout_top.xml @@ -43,7 +43,7 @@ android:layout_weight="1" android:contentDescription="@string/settings" android:padding="@dimen/normal_margin" - app:icon="@drawable/ic_settings_cog_vector" + app:icon="@drawable/ic_settings" app:layout_constraintEnd_toEndOf="parent" app:layout_constraintStart_toEndOf="@id/change_resolution" app:layout_constraintTop_toTopOf="@id/toggle_flash" />