Issue #22: Fix compilation warnings

This commit is contained in:
Jakub Melka
2022-07-31 18:32:57 +02:00
parent b30150a503
commit e310efb763
70 changed files with 424 additions and 435 deletions

View File

@@ -142,11 +142,11 @@ QModelIndex DifferencesDockWidget::findResultIndex(size_t index) const
const int childCount = model->rowCount(parentIndex);
for (int j = 0; j < childCount; ++j)
{
QModelIndex childIndex = parentIndex.child(j, 0);
QVariant data = childIndex.data(Qt::UserRole);
if (data.isValid())
QModelIndex childIndex = model->index(j, 0, parentIndex);
QVariant childUserData = childIndex.data(Qt::UserRole);
if (childUserData.isValid())
{
if (data.toULongLong() == index)
if (childUserData.toULongLong() == index)
{
return childIndex;
}
@@ -294,11 +294,11 @@ void DifferencesDockWidget::onCurrentItemChanged(QTreeWidgetItem* current, QTree
}
pdf::PDFTemporaryValueChange guard(&m_disableChangeSelectedResultIndex, true);
QVariant data = current->data(0, Qt::UserRole);
QVariant childUserData = current->data(0, Qt::UserRole);
if (data.isValid())
if (childUserData.isValid())
{
m_diffNavigator->select(data.toULongLong());
m_diffNavigator->select(childUserData.toULongLong());
}
}

View File

@@ -149,7 +149,7 @@ MainWindow::MainWindow(QWidget* parent) :
ui->menuToolbars->addAction(toolbar->toggleViewAction());
}
connect(&m_mapper, QOverload<int>::of(&QSignalMapper::mapped), this, &MainWindow::onMappedActionTriggered);
connect(&m_mapper, &QSignalMapper::mappedInt, this, &MainWindow::onMappedActionTriggered);
QList<QAction*> actions = findChildren<QAction*>();
for (QAction* action : actions)