fenix/PDF4QT
1
0
Fork 0
mirror of https://github.com/JakubMelka/PDF4QT.git synced 2025-01-04 20:39:52 +01:00
Code Issues Packages Projects Releases Wiki Activity

Issue #222: UnitTests fails several tests

Browse Source
This commit is contained in:
Jakub Melka 2024-11-17 18:58:42 +01:00
parent 11780aff22
commit b290f61611
2 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASES.txt
View File

@ -1,4 +1,5 @@
CURRENT: CURRENT:
- Issue #222: UnitTests fails several tests
- Issue #207: Zoom to Cursor (Zoom Anchoring) - Issue #207: Zoom to Cursor (Zoom Anchoring)
- Issue #206: Name of the executable / command - Issue #206: Name of the executable / command
- Issue #205: Editor cannot create white, whitesmoke or transparent annotations - Issue #205: Editor cannot create white, whitesmoke or transparent annotations

35
UnitTests/tst_lexicalanalyzertest.cpp
View File

@ -221,7 +221,6 @@ void LexicalAnalyzerTest::test_invalid_input()
bigNumber.front() = '1'; bigNumber.front() = '1';
bigNumber.back() = 0; bigNumber.back() = 0;
QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("(\\9adoctalnumber)"));
QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("(\\)")); QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("(\\)"));
QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("123 456 +4-5")); QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("123 456 +4-5"));
QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("123 456 +")); QVERIFY_THROWS_EXCEPTION(pdf::PDFException, scanWholeStream("123 456 +"));
@ -1126,12 +1125,31 @@ void LexicalAnalyzerTest::testTokens(const char* stream, const std::vector<pdf::
scanned.emplace_back(analyzer.fetch()); scanned.emplace_back(analyzer.fetch());
} }
// Format error message QVERIFY(scanned.size() == tokens.size());
QString actual = getStringFromTokens(scanned);
QString expected = getStringFromTokens(tokens);
// Now, compare scanned tokens for (size_t i = 0; i < scanned.size(); ++i)
QVERIFY2(scanned == tokens, qPrintable(QString("stream: %1, actual = %2, expected = %3").arg(QString(stream), actual, expected))); {
const pdf::PDFLexicalAnalyzer::Token& scannedItem = scanned[i];
const pdf::PDFLexicalAnalyzer::Token& tokenItem = scanned[i];
if (scannedItem == tokenItem)
{
continue;
}
if (scannedItem.type == tokenItem.type && scannedItem.type == pdf::PDFLexicalAnalyzer::TokenType::Real)
{
if (qFuzzyCompare(scannedItem.data.toDouble(), tokenItem.data.toDouble()))
{
continue;
}
}
// Now, compare scanned tokens
QString actual = getStringFromTokens({ scannedItem });
QString expected = getStringFromTokens({ tokenItem });
QVERIFY2(scannedItem == tokenItem, qPrintable(QString("stream: %1, actual = %2, expected = %3").arg(QString(stream), actual, expected)));
}
} }
QString LexicalAnalyzerTest::getStringFromTokens(const std::vector<pdf::PDFLexicalAnalyzer::Token>& tokens) QString LexicalAnalyzerTest::getStringFromTokens(const std::vector<pdf::PDFLexicalAnalyzer::Token>& tokens)
@ -1149,6 +1167,11 @@ QString LexicalAnalyzerTest::getStringFromTokens(const std::vector<pdf::PDFLexic
{ {
stringTokens << tokenTypeAsString; stringTokens << tokenTypeAsString;
} }
else if (token.data.typeId() == QMetaType::Double)
{
const double value = token.data.toDouble();
stringTokens << QString("%1(%2)").arg(tokenTypeAsString, QString::number(value));
}
else else
{ {
stringTokens << QString("%1(%2)").arg(tokenTypeAsString, token.data.toString()); stringTokens << QString("%1(%2)").arg(tokenTypeAsString, token.data.toString());