From e71c7568c09bf8ad184753d3d0f14046f1e386d0 Mon Sep 17 00:00:00 2001
From: Fabio Di Stasio <fabio286@gmail.com>
Date: Sat, 29 May 2021 11:04:02 +0200
Subject: [PATCH] feat: option to set DATA tab page size

---
 src/renderer/components/ModalSettings.vue     | 26 +++++++++++++++++++
 .../components/WorkspaceQueryTable.vue        |  5 ++--
 src/renderer/i18n/en-US.js                    |  3 ++-
 src/renderer/store/modules/settings.store.js  |  9 ++++++-
 4 files changed, 39 insertions(+), 4 deletions(-)

diff --git a/src/renderer/components/ModalSettings.vue b/src/renderer/components/ModalSettings.vue
index cf355f69..5f5c1b9d 100644
--- a/src/renderer/components/ModalSettings.vue
+++ b/src/renderer/components/ModalSettings.vue
@@ -83,6 +83,27 @@
                                  </select>
                               </div>
                            </div>
+                           <div class="form-group">
+                              <div class="col-6 col-sm-12">
+                                 <label class="form-label">
+                                    {{ $t('message.dataTabPageSize') }}
+                                 </label>
+                              </div>
+                              <div class="col-6 col-sm-12">
+                                 <select
+                                    v-model="localPageSize"
+                                    class="form-select"
+                                    @change="changePageSize(+localPageSize)"
+                                 >
+                                    <option
+                                       v-for="size in pageSizes"
+                                       :key="size"
+                                    >
+                                       {{ size }}
+                                    </option>
+                                 </select>
+                              </div>
+                           </div>
                            <div class="form-group">
                               <div class="col-6 col-sm-12">
                                  <label class="form-label">
@@ -257,9 +278,11 @@ export default {
    data () {
       return {
          localLocale: null,
+         localPageSize: null,
          localTimeout: null,
          localEditorTheme: null,
          selectedTab: 'general',
+         pageSizes: [40, 100, 250, 500, 1000],
          editorThemes: [
             {
                group: this.$t('word.light'),
@@ -317,6 +340,7 @@ export default {
          appVersion: 'application/appVersion',
          selectedSettingTab: 'application/selectedSettingTab',
          selectedLocale: 'settings/getLocale',
+         pageSize: 'settings/getDataTabLimit',
          selectedAutoComplete: 'settings/getAutoComplete',
          selectedLineWrap: 'settings/getLineWrap',
          notificationsTimeout: 'settings/getNotificationsTimeout',
@@ -359,6 +383,7 @@ ORDER BY
    },
    created () {
       this.localLocale = this.selectedLocale;
+      this.localPageSize = this.pageSize;
       this.localTimeout = this.notificationsTimeout;
       this.localEditorTheme = this.editorTheme;
       this.selectedTab = this.selectedSettingTab;
@@ -371,6 +396,7 @@ ORDER BY
       ...mapActions({
          closeModal: 'application/hideSettingModal',
          changeLocale: 'settings/changeLocale',
+         changePageSize: 'settings/changePageSize',
          changeAutoComplete: 'settings/changeAutoComplete',
          changeLineWrap: 'settings/changeLineWrap',
          changeApplicationTheme: 'settings/changeApplicationTheme',
diff --git a/src/renderer/components/WorkspaceQueryTable.vue b/src/renderer/components/WorkspaceQueryTable.vue
index 7d3f4ff5..8ba0dc82 100644
--- a/src/renderer/components/WorkspaceQueryTable.vue
+++ b/src/renderer/components/WorkspaceQueryTable.vue
@@ -139,7 +139,8 @@ export default {
    },
    computed: {
       ...mapGetters({
-         getWorkspace: 'workspaces/getWorkspace'
+         getWorkspace: 'workspaces/getWorkspace',
+         pageSize: 'settings/getDataTabLimit'
       }),
       workspaceSchema () {
          return this.getWorkspace(this.connUid).breadcrumbs.schema;
@@ -157,7 +158,7 @@ export default {
          return this.fields.every(field => field.name);
       },
       isHardSort () {
-         return this.mode === 'table' && this.localResults.length === 1000;
+         return this.mode === 'table' && this.localResults.length === this.pageSize;
       },
       sortedResults () {
          if (this.currentSort && !this.isHardSort) {
diff --git a/src/renderer/i18n/en-US.js b/src/renderer/i18n/en-US.js
index 0402844d..005eb649 100644
--- a/src/renderer/i18n/en-US.js
+++ b/src/renderer/i18n/en-US.js
@@ -210,7 +210,8 @@ module.exports = {
       editSchema: 'Edit schema',
       deleteSchema: 'Delete schema',
       markdownSupported: 'Markdown supported',
-      plantATree: 'Plant a Tree'
+      plantATree: 'Plant a Tree',
+      dataTabPageSize: 'DATA tab page size'
    },
    faker: {
       address: 'Address',
diff --git a/src/renderer/store/modules/settings.store.js b/src/renderer/store/modules/settings.store.js
index 487efeb2..2069db47 100644
--- a/src/renderer/store/modules/settings.store.js
+++ b/src/renderer/store/modules/settings.store.js
@@ -19,10 +19,10 @@ export default {
    },
    getters: {
       getLocale: state => state.locale,
+      getDataTabLimit: state => state.data_tab_limit,
       getAllowPrerelease: state => state.allow_prerelease,
       getExplorebarSize: state => state.explorebar_size,
       getNotificationsTimeout: state => state.notifications_timeout,
-      getDataTabLimit: state => state.data_tab_limit,
       getAutoComplete: state => state.auto_complete,
       getLineWrap: state => state.line_wrap,
       getApplicationTheme: state => state.application_theme,
@@ -34,6 +34,10 @@ export default {
          i18n.locale = locale;
          persistentStore.set('locale', state.locale);
       },
+      SET_DATA_TAB_LIMIT (state, limit) {
+         state.data_tab_limit = limit;
+         persistentStore.set('data_tab_limit', state.data_tab_limit);
+      },
       SET_ALLOW_PRERELEASE (state, allow) {
          state.allow_prerelease = allow;
          persistentStore.set('allow_prerelease', state.allow_prerelease);
@@ -67,6 +71,9 @@ export default {
       changeLocale ({ commit }, locale) {
          commit('SET_LOCALE', locale);
       },
+      changePageSize ({ commit }, limit) {
+         commit('SET_DATA_TAB_LIMIT', limit);
+      },
       changeAllowPrerelease ({ commit }, allow) {
          commit('SET_ALLOW_PRERELEASE', allow);
       },