From dd5b41716a10cf9500f2c611b232f5b5b0756a68 Mon Sep 17 00:00:00 2001 From: Fabio Di Stasio Date: Sat, 9 Mar 2024 15:42:36 +0100 Subject: [PATCH] fix: CSV export does not escape strings when needed, fixes #770 --- commitlint.config.js | 9 +++++++++ src/renderer/libs/exportRows.ts | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/commitlint.config.js b/commitlint.config.js index 63855272..65d4ecd5 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -19,6 +19,15 @@ module.exports = { 'revert', 'perf' ] + ], + 'subject-case': [ + 2, + 'never', + [ + 'upper-case', + 'pascal-case', + 'start-case' + ] ] } }; diff --git a/src/renderer/libs/exportRows.ts b/src/renderer/libs/exportRows.ts index 431be522..b9ba6dc4 100644 --- a/src/renderer/libs/exportRows.ts +++ b/src/renderer/libs/exportRows.ts @@ -31,7 +31,7 @@ export const exportRows = (args: { const csv = []; const sd = args.csvOptions.stringDelimiter === 'single' ? '\'' - : args.csvOptions.stringDelimiter === 'single' + : args.csvOptions.stringDelimiter === 'double' ? '"' : '';