mirror of
https://github.com/wallabag/wallabag.git
synced 2024-12-16 10:22:14 +01:00
19d9efab32
graby will throw an Exception in some case (like a bad url, a restricted url or a secured pdf). Import doesn't handle that case and break the whole import. With that commit the import isn't stopped but the entry is just skipped. Also, as a bonus, I've added extra test on WallabagImportV2 when the json is empty.
187 lines
6.0 KiB
PHP
187 lines
6.0 KiB
PHP
<?php
|
|
|
|
namespace Tests\Wallabag\ImportBundle\Import;
|
|
|
|
use Wallabag\ImportBundle\Import\WallabagV2Import;
|
|
use Wallabag\UserBundle\Entity\User;
|
|
use Wallabag\CoreBundle\Entity\Entry;
|
|
use Monolog\Logger;
|
|
use Monolog\Handler\TestHandler;
|
|
|
|
class WallabagV2ImportTest extends \PHPUnit_Framework_TestCase
|
|
{
|
|
protected $user;
|
|
protected $em;
|
|
protected $logHandler;
|
|
protected $contentProxy;
|
|
|
|
private function getWallabagV2Import($unsetUser = false)
|
|
{
|
|
$this->user = new User();
|
|
|
|
$this->em = $this->getMockBuilder('Doctrine\ORM\EntityManager')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$this->contentProxy = $this->getMockBuilder('Wallabag\CoreBundle\Helper\ContentProxy')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$wallabag = new WallabagV2Import($this->em, $this->contentProxy);
|
|
|
|
$this->logHandler = new TestHandler();
|
|
$logger = new Logger('test', [$this->logHandler]);
|
|
$wallabag->setLogger($logger);
|
|
|
|
if (false === $unsetUser) {
|
|
$wallabag->setUser($this->user);
|
|
}
|
|
|
|
return $wallabag;
|
|
}
|
|
|
|
public function testInit()
|
|
{
|
|
$wallabagV2Import = $this->getWallabagV2Import();
|
|
|
|
$this->assertEquals('wallabag v2', $wallabagV2Import->getName());
|
|
$this->assertNotEmpty($wallabagV2Import->getUrl());
|
|
$this->assertEquals('import.wallabag_v2.description', $wallabagV2Import->getDescription());
|
|
}
|
|
|
|
public function testImport()
|
|
{
|
|
$wallabagV2Import = $this->getWallabagV2Import();
|
|
$wallabagV2Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2.json');
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->exactly(24))
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, true, false));
|
|
|
|
$this->em
|
|
->expects($this->any())
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
$this->contentProxy
|
|
->expects($this->exactly(2))
|
|
->method('updateEntry')
|
|
->willReturn(new Entry($this->user));
|
|
|
|
$res = $wallabagV2Import->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 22, 'imported' => 2], $wallabagV2Import->getSummary());
|
|
}
|
|
|
|
public function testImportAndMarkAllAsRead()
|
|
{
|
|
$wallabagV2Import = $this->getWallabagV2Import();
|
|
$wallabagV2Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2-read.json');
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->exactly(2))
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, false));
|
|
|
|
$this->em
|
|
->expects($this->any())
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
$this->contentProxy
|
|
->expects($this->exactly(2))
|
|
->method('updateEntry')
|
|
->willReturn(new Entry($this->user));
|
|
|
|
// check that every entry persisted are archived
|
|
$this->em
|
|
->expects($this->any())
|
|
->method('persist')
|
|
->with($this->callback(function ($persistedEntry) {
|
|
return $persistedEntry->isArchived();
|
|
}));
|
|
|
|
$res = $wallabagV2Import->setMarkAsRead(true)->import();
|
|
|
|
$this->assertTrue($res);
|
|
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 2], $wallabagV2Import->getSummary());
|
|
}
|
|
|
|
public function testImportBadFile()
|
|
{
|
|
$wallabagV1Import = $this->getWallabagV2Import();
|
|
$wallabagV1Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2.jsonx');
|
|
|
|
$res = $wallabagV1Import->import();
|
|
|
|
$this->assertFalse($res);
|
|
|
|
$records = $this->logHandler->getRecords();
|
|
$this->assertContains('WallabagImport: unable to read file', $records[0]['message']);
|
|
$this->assertEquals('ERROR', $records[0]['level_name']);
|
|
}
|
|
|
|
public function testImportUserNotDefined()
|
|
{
|
|
$wallabagV1Import = $this->getWallabagV2Import(true);
|
|
$wallabagV1Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2.json');
|
|
|
|
$res = $wallabagV1Import->import();
|
|
|
|
$this->assertFalse($res);
|
|
|
|
$records = $this->logHandler->getRecords();
|
|
$this->assertContains('WallabagImport: user is not defined', $records[0]['message']);
|
|
$this->assertEquals('ERROR', $records[0]['level_name']);
|
|
}
|
|
|
|
public function testImportEmptyFile()
|
|
{
|
|
$wallabagV2Import = $this->getWallabagV2Import();
|
|
$wallabagV2Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2-empty.json');
|
|
|
|
$res = $wallabagV2Import->import();
|
|
|
|
$this->assertFalse($res);
|
|
$this->assertEquals(['skipped' => 0, 'imported' => 0], $wallabagV2Import->getSummary());
|
|
}
|
|
|
|
public function testImportWithExceptionFromGraby()
|
|
{
|
|
$wallabagV2Import = $this->getWallabagV2Import();
|
|
$wallabagV2Import->setFilepath(__DIR__.'/../fixtures/wallabag-v2.json');
|
|
|
|
$entryRepo = $this->getMockBuilder('Wallabag\CoreBundle\Repository\EntryRepository')
|
|
->disableOriginalConstructor()
|
|
->getMock();
|
|
|
|
$entryRepo->expects($this->exactly(24))
|
|
->method('findByUrlAndUserId')
|
|
->will($this->onConsecutiveCalls(false, true, false));
|
|
|
|
$this->em
|
|
->expects($this->any())
|
|
->method('getRepository')
|
|
->willReturn($entryRepo);
|
|
|
|
$this->contentProxy
|
|
->expects($this->exactly(2))
|
|
->method('updateEntry')
|
|
->will($this->throwException(new \Exception()));
|
|
|
|
$res = $wallabagV2Import->import();
|
|
|
|
$this->assertTrue($res);
|
|
$this->assertEquals(['skipped' => 24, 'imported' => 0], $wallabagV2Import->getSummary());
|
|
}
|
|
}
|