mirror of
https://github.com/wallabag/wallabag.git
synced 2024-12-15 18:00:36 +01:00
Fix validateAndSetPreviewPicture
Which wasn't covered by a test!
This commit is contained in:
parent
a05b61159e
commit
d0ec2ddd23
@ -127,10 +127,7 @@ class ContentProxy
|
||||
|
||||
// if content is an image, define it as a preview too
|
||||
if (!empty($content['content_type']) && in_array($this->mimeGuesser->guess($content['content_type']), ['jpeg', 'jpg', 'gif', 'png'], true)) {
|
||||
$this->validateAndSetPreviewPicture(
|
||||
$entry,
|
||||
$content['url']
|
||||
);
|
||||
$this->updatePreviewPicture($entry, $content['url']);
|
||||
}
|
||||
|
||||
if (!empty($content['content_type'])) {
|
||||
|
@ -495,6 +495,41 @@ class ContentProxyTest extends \PHPUnit_Framework_TestCase
|
||||
$this->assertSame('1.1.1.1', $entry->getDomainName());
|
||||
}
|
||||
|
||||
public function testWithImageAsContent()
|
||||
{
|
||||
$tagger = $this->getTaggerMock();
|
||||
$tagger->expects($this->once())
|
||||
->method('tag');
|
||||
|
||||
$graby = $this->getMockBuilder('Graby\Graby')
|
||||
->setMethods(['fetchContent'])
|
||||
->disableOriginalConstructor()
|
||||
->getMock();
|
||||
|
||||
$graby->expects($this->any())
|
||||
->method('fetchContent')
|
||||
->willReturn([
|
||||
'html' => '<p><img src="http://1.1.1.1/image.jpg" /></p>',
|
||||
'title' => 'this is my title',
|
||||
'url' => 'http://1.1.1.1/image.jpg',
|
||||
'content_type' => 'image/jpeg',
|
||||
'status' => '200',
|
||||
'open_graph' => [],
|
||||
]);
|
||||
|
||||
$proxy = new ContentProxy($graby, $tagger, $this->getValidator(), $this->getLogger(), $this->fetchingErrorMessage);
|
||||
$entry = new Entry(new User());
|
||||
$proxy->updateEntry($entry, 'http://0.0.0.0');
|
||||
|
||||
$this->assertEquals('http://1.1.1.1/image.jpg', $entry->getUrl());
|
||||
$this->assertEquals('this is my title', $entry->getTitle());
|
||||
$this->assertContains('http://1.1.1.1/image.jpg', $entry->getContent());
|
||||
$this->assertSame('http://1.1.1.1/image.jpg', $entry->getPreviewPicture());
|
||||
$this->assertEquals('image/jpeg', $entry->getMimetype());
|
||||
$this->assertEquals('200', $entry->getHttpStatus());
|
||||
$this->assertEquals('1.1.1.1', $entry->getDomainName());
|
||||
}
|
||||
|
||||
private function getTaggerMock()
|
||||
{
|
||||
return $this->getMockBuilder(RuleBasedTagger::class)
|
||||
|
Loading…
Reference in New Issue
Block a user