devol
/
smalltalk-matrix
mirror of https://github.com/ouchadam/small-talk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoiding extra bitmap allocations when loading notification avatars

This commit is contained in:
Adam Brown 2022-05-08 14:21:44 +01:00
parent d78000061e
commit ea2a960a3d
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
domains/android/imageloader/src/main/kotlin/app/dapk/st/imageloader/ImageLoader.kt
View File

@ -1,12 +1,13 @@
package app.dapk.st.imageloader package app.dapk.st.imageloader
import android.content.Context import android.content.Context
import android.graphics.drawable.BitmapDrawable
import android.graphics.drawable.Drawable import android.graphics.drawable.Drawable
import android.graphics.drawable.Icon import android.graphics.drawable.Icon
import android.widget.ImageView import android.widget.ImageView
import androidx.core.graphics.drawable.toBitmap
import coil.imageLoader import coil.imageLoader
import coil.request.ImageRequest import coil.request.ImageRequest
import coil.request.ImageResult
import coil.transform.CircleCropTransformation import coil.transform.CircleCropTransformation
import coil.transform.Transformation import coil.transform.Transformation
import coil.load as coilLoad import coil.load as coilLoad
@ -14,7 +15,6 @@ import coil.load as coilLoad
interface ImageLoader { interface ImageLoader {
suspend fun load(url: String, transformation: Transformation? = null): Drawable? suspend fun load(url: String, transformation: Transformation? = null): Drawable?
} }
interface IconLoader { interface IconLoader {
@ -31,19 +31,24 @@ class CachedIcons(private val imageLoader: ImageLoader) : IconLoader {
override suspend fun load(url: String): Icon? { override suspend fun load(url: String): Icon? {
return cache.getOrPut(url) { return cache.getOrPut(url) {
imageLoader.load(url, transformation = circleCrop)?.toBitmap()?.let { imageLoader.load(url, transformation = circleCrop)?.asBitmap()?.let {
Icon.createWithBitmap(it) Icon.createWithBitmap(it)
} }
} }
} }
} }
private fun Drawable.asBitmap() = (this as? BitmapDrawable)?.bitmap
internal class CoilImageLoader(private val context: Context) : ImageLoader { internal class CoilImageLoader(private val context: Context) : ImageLoader {
private val coil = context.imageLoader private val coil = context.imageLoader
override suspend fun load(url: String, transformation: Transformation?): Drawable? { override suspend fun load(url: String, transformation: Transformation?): Drawable? {
return internalLoad(url, transformation).drawable
}
private suspend fun internalLoad(url: String, transformation: Transformation?): ImageResult {
val request = ImageRequest.Builder(context) val request = ImageRequest.Builder(context)
.data(url) .data(url)
.let { .let {
@ -53,7 +58,7 @@ internal class CoilImageLoader(private val context: Context) : ImageLoader {
} }
} }
.build() .build()
return coil.execute(request).drawable return coil.execute(request)
} }
} }