From 905abce8f778e9a3edbd69b9f3183c93d11edffa Mon Sep 17 00:00:00 2001 From: Jason Kim Date: Fri, 9 Apr 2021 00:10:27 -0700 Subject: [PATCH] refactor: drop teddit image redirect support No longer redirect image links for teddit instances. Add a comment detailing the two issues I found. Now, the feature should be stable. --- src/pages/background/background.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pages/background/background.js b/src/pages/background/background.js index 2534279..2047bfb 100644 --- a/src/pages/background/background.js +++ b/src/pages/background/background.js @@ -452,8 +452,12 @@ function redirectReddit(url, initiator, type) { if (redditInstance.includes("libredd")) { return `${redditInstance}/img${url.pathname}${url.search}`; } else if (redditInstance.includes("teddit")) { - let pathWithoutSlash = url.pathname.slice(1); - return `${redditInstance}/pics/w:null_${pathWithoutSlash}${url.search}` + // As of 2021-04-09, redirects for teddit images are nontrivial: + // - navigating to the image before ever navigating to its page causes + // 404 error (probably needs fix on teddit project) + // - some image links on teddit are very different + // Therefore, don't support redirecting image links for teddit. + return null; } else { return null; }