Fixing cookies #319 #323

src/assets/javascripts/general.js

@@ -44,6 +44,7 @@ async function initDefaults() {
                 "maps",
             ],
             autoRedirect: false,
+            firstPartyIsolate: false,
         }, () => resolve())
     )
 }

src/assets/javascripts/maps.js

@@ -46,6 +46,9 @@ init();
 browser.storage.onChanged.addListener(init)
 
 function redirect(url, initiator) {
+  if (disableMaps) return;
+  if (initiator && initiator.host === "earth.google.com") return;
+  if (!url.href.match(targets)) return;
   const mapCentreRegex = /@(-?\d[0-9.]*),(-?\d[0-9.]*),(\d{1,2})[.z]/;
   const dataLatLngRegex = /!3d(-?[0-9]{1,}.[0-9]{1,})!4d(-?[0-9]{1,}.[0-9]{1,})/;
   const placeRegex = /\/place\/(.*)\//;
@@ -67,7 +70,6 @@ function redirect(url, initiator) {
     traffic: "S", // not implemented on OSM, default to standard.
     bicycling: "C",
   };
-
   function addressToLatLng(address) {
     const xmlhttp = new XMLHttpRequest();
     xmlhttp.open("GET", `https://nominatim.openstreetmap.org/search/${address}?format=json&limit=1`, false);
@@ -85,10 +87,6 @@ function redirect(url, initiator) {
     console.info("Error: Status is " + xmlhttp.status);
   }
 
-  if (disableMaps) return;
-  if (initiator && initiator.host === "earth.google.com") return;
-  if (!url.href.match(targets)) return;
-
   let randomInstance;
   if (mapsFrontend == 'osm') randomInstance = utils.getRandomInstance(redirects.osm.normal);
   if (mapsFrontend == 'facil') randomInstance = utils.getRandomInstance([...facilNormalRedirectsChecks, ...facilNormalCustomRedirects]);

src/assets/javascripts/utils.js

@@ -283,78 +283,68 @@ async function testLatency(element, instances) {
     resolve(myList);
   })
 }
-
+// Complete on getting cookies working in Tor, maybe delete all the other same name cookies to prevent overlapping, see ya :)
 function copyCookie(frontend, targetUrl, urls, name) {
   return new Promise(resolve => {
+    browser.storage.local.get('firstPartyIsolate', r => {
+      console.log('r.firstPartyIsolate', r.firstPartyIsolate);
       let query;
-    if (window.chrome) query = { url: protocolHost(targetUrl), name: name }
+      if (!r.firstPartyIsolate) query = { url: protocolHost(targetUrl), name: name }
       else query = { url: protocolHost(targetUrl), name: name, firstPartyDomain: null }
       browser.cookies.getAll(
         query,
-      async cookies => {
+        cookies => {
-        function setCookie(url, name, value, expirationDate, firstPartyIsolate) {
+          for (const cookie of cookies)
-          return new Promise(resolve => {
+            if (cookie.name == name) {
-            let query;
+              for (const url of urls) {
-            if (window.chrome) query = {
+                let setQuery;
-              url: url, name: name, value: value, secure: true,
+                let removeQuery;
-              expirationDate: expirationDate,
+                if (!r.firstPartyIsolate) {
+                  removeQuery = { url: url, name: name };
+                  setQuery = {
+                    url: url, name: name, value: cookie.value, secure: true,
+                    expirationDate: cookie.expirationDate,
                   };
-            else query = {
+                }
-              url: url, name: name, value: value, secure: true,
+                else {
-              firstPartyDomain: firstPartyIsolate.value ? new URL(url).hostname : '',
+                  removeQuery = { url: url, name: name, firstPartyDomain: new URL(url).hostname };
-              expirationDate: firstPartyIsolate.value ? null : expirationDate,
+                  setQuery = {
+                    url: url, name: name, value: cookie.value, secure: true,
+                    firstPartyDomain: new URL(url).hostname,
                   };
-            browser.cookies.set(query, () => resolve())
+                }
+                browser.cookies.remove(removeQuery, () => {
+                  browser.cookies.set(setQuery, () => {
+                    browser.storage.local.set({ [`${frontend}_${name}`]: cookie }, () => resolve())
                   })
-        }
-        if (window.chrome) {
-          for (const cookie of cookies)
-            if (cookie.name == name) {
-              console.log('cookie', cookie);
-              for (const url of urls) await setCookie(url, cookie.name, cookie.value, cookie.expirationDate)
-              browser.storage.local.set({ [`${frontend}_${name}`]: cookie }, () => resolve())
-              break;
-            }
-          resolve();
-        } else {
-          browser.privacy.websites.firstPartyIsolate.get({},
-            async firstPartyIsolate => {
-              for (const cookie of cookies)
-                if (cookie.name == name) {
-                  console.log('cookie', cookie);
-                  for (const url of urls) await setCookie(url, cookie.name, cookie.value, cookie.expirationDate, firstPartyIsolate)
-                  browser.storage.local.set({ [`${frontend}_${name}`]: cookie }, () => resolve())
-                  break;
-                }
-              resolve();
-            }
-          )
-        }
                 });
+              }
+              break;
+            }
+          resolve();
+        }
+      );
+    })
   })
 }
 
 function getCookiesFromStorage(frontend, urls, name) {
   let key = `${frontend}_${name}`;
-  browser.storage.local.get(
+  browser.storage.local.get([key, 'firstPartyIsolate'], r => {
-    key,
-    r => {
     const cookie = r[key];
-      if (cookie !== undefined)
+    if (cookie === undefined) return;
-        browser.privacy.websites.firstPartyIsolate.get({},
+    let query;
-          firstPartyIsolate => {
+    if (!r.firstPartyIsolate) query = {
-            for (const url of urls)
+      url: url, name: cookie.name, value: cookie.value, secure: true,
-              browser.cookies.set({
+      expirationDate: cookie.expirationDate,
-                url: url,
+    };
-                name: cookie.name,
+    else query = {
-                value: cookie.value,
+      url: url, name: cookie.name, value: cookie.value, secure: true,
-                secure: true,
+      expirationDate: null,
-                expirationDate: firstPartyIsolate.value ? null : cookie.expirationDate,
+      firstPartyDomain: new URL(url).hostname,
-                firstPartyDomain: firstPartyIsolate.value ? new URL(url).hostname : '',
-              })
-          })
     }
-  )
+    for (const url of urls) browser.cookies.set(query)
+  })
 }
 
 function copyRaw(test, copyRawElement) {

src/manifest.json

@@ -25,7 +25,6 @@
     "storage",
     "unlimitedStorage",
     "cookies",
-    "privacy",
     "clipboardWrite",
     "contextMenus",
     "<all_urls>"

src/pages/options/index.html

@@ -67,6 +67,10 @@
             <option value="dark" data-localise="__MSG_dark__">Dark</option>
           </select>
         </div>
+        <div class="some-block option-block">
+          <h4>First-party isolation (Enable for Tor)</h4>
+          <input id="firstPartyIsolate" type="checkbox">
+        </div>
         <div class="some-block option-block">
           <h4 data-localise="__MSG_autoRedirect__"></h4>
           <input id="auto-redirect" type="checkbox">

src/pages/options/index.js

@@ -1,12 +1,3 @@
-import youtubeHelper from "../../assets/javascripts/youtube/youtube.js";
-import twitterHelper from "../../assets/javascripts/twitter.js";
-import redditHelper from "../../assets/javascripts/reddit.js";
-import searchHelper from "../../assets/javascripts/search.js";
-import translateHelper from "../../assets/javascripts/translate/translate.js";
-import wikipediaHelper from "../../assets/javascripts/wikipedia.js";
-import tiktokHelper from "../../assets/javascripts/tiktok.js";
-
-
 for (const a of document.getElementById('links').getElementsByTagName('a')) {
     a.addEventListener('click', e => {
         const path = a.getAttribute('href').replace('#', '');

src/pages/options/widgets/general.js

@@ -176,16 +176,21 @@ for (const frontend of generalHelper.allPopupFrontends)
     }
   )
 
+const firstPartyIsolate = document.getElementById('firstPartyIsolate');
+firstPartyIsolate.addEventListener("change", () => browser.storage.local.set({ firstPartyIsolate: firstPartyIsolate.checked }))
 
 browser.storage.local.get(
   [
     'theme',
     'autoRedirect',
-    'exceptions'
+    'exceptions',
+    'firstPartyIsolate'
   ],
   r => {
     autoRedirectElement.checked = r.autoRedirect;
     themeElement.value = r.theme;
+    firstPartyIsolate.checked = r.firstPartyIsolate;
+
     instanceTypeElement.addEventListener("change",
       event => {
         instanceType = event.target.options[instanceTypeElement.selectedIndex].value

src/pages/options/widgets/general.pug

@@ -10,6 +10,10 @@ section#general_page.option-block
             option(value="light" data-localise="__MSG_light__") Light
             option(value="dark" data-localise="__MSG_dark__") Dark
 
+    .some-block.option-block
+        h4() First-party isolation (Enable for Tor)
+        input#firstPartyIsolate(type="checkbox")
+
     .some-block.option-block
         h4(data-localise="__MSG_autoRedirect__")
         input#auto-redirect(type="checkbox")