devol/libredirect
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: drop teddit image redirect support

Browse Source 
No longer redirect image links for teddit instances.  Add a comment
detailing the two issues I found.  Now, the feature should be stable.
This commit is contained in:
Jason Kim 2021-04-09 00:10:27 -07:00
parent e86895b008
commit 905abce8f7
No known key found for this signature in database
GPG Key ID: E1FDF0CB573FE944
1 changed files with 6 additions and 2 deletions

8
src/pages/background/background.js

@ -452,8 +452,12 @@ function redirectReddit(url, initiator, type) {
if (redditInstance.includes("libredd")) {
return `${redditInstance}/img${url.pathname}${url.search}`;
} else if (redditInstance.includes("teddit")) {
let pathWithoutSlash = url.pathname.slice(1);
return `${redditInstance}/pics/w:null_${pathWithoutSlash}${url.search}`
// As of 2021-04-09, redirects for teddit images are nontrivial:
// - navigating to the image before ever navigating to its page causes
// 404 error (probably needs fix on teddit project)
// - some image links on teddit are very different
// Therefore, don't support redirecting image links for teddit.
return null;
} else {
return null;
}