From 66e94471b8b9a2427c7d4eba431dcfbee4e2ba43 Mon Sep 17 00:00:00 2001 From: Tom Delmas Date: Thu, 21 Feb 2019 23:16:42 +0100 Subject: [PATCH 1/2] Better message when version doesn't match --- .../exodusprivacy/adapters/ApplicationListAdapter.java | 4 ++++ app/src/main/res/values-ar/strings.xml | 2 +- app/src/main/res/values-de/strings.xml | 2 +- app/src/main/res/values-es/strings.xml | 2 +- app/src/main/res/values-fr/strings.xml | 2 +- app/src/main/res/values-it/strings.xml | 2 +- app/src/main/res/values/strings.xml | 2 +- 7 files changed, 10 insertions(+), 6 deletions(-) diff --git a/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java b/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java index aa7990e..e7311d8 100644 --- a/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java +++ b/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java @@ -219,8 +219,12 @@ public class ApplicationListAdapter extends RecyclerView.Adapter { appItemBinding.appTrackerNb.setBackgroundResource(R.drawable.square_red); if(versionName != null && !report.version.equals(data.versionName)) { + String string = context.getString(R.string.tested,versionCode,report.versionCode); + appItemBinding.otherVersion.setText(string); appItemBinding.otherVersion.setVisibility(View.VISIBLE); } else if (versionName == null && report.versionCode != versionCode) { + String string = context.getString(R.string.tested,String.valueOf(versionCode),String.valueOf(report.versionCode)); + appItemBinding.otherVersion.setText(string); appItemBinding.otherVersion.setVisibility(View.VISIBLE); } diff --git a/app/src/main/res/values-ar/strings.xml b/app/src/main/res/values-ar/strings.xml index 5970a03..47103a8 100644 --- a/app/src/main/res/values-ar/strings.xml +++ b/app/src/main/res/values-ar/strings.xml @@ -12,7 +12,7 @@ النسخة المُجرَّبة: لم نعثر على أي متعقِّب قمنا بتجريبه هذا التطبيق لا يتطلب أية تصريحات - ليس هناك أي تقرير عن النسخة المثبة، إنّ البيانات المعروضة تتعلق بنسخة قديمة لنفس التطبيق. + %1$s%2$sليس هناك أي تقرير عن النسخة المثبة، إنّ البيانات المعروضة تتعلق بنسخة قديمة لنفس التطبيق. لم يتم بعد فحص هذا التطبيق بواسطة Exodus Privacy يبدو أنّ نظام جهازك لا يسمح بالوصول إلى قائمة التطبيقات المثبة. يبدو أنّك لم تقم بتثبيت أي تطبيق مِن المصدر الذي نقوم بفحصه (متجر جوجل للتطبيقات). diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index e815c87..898d9cb 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -12,7 +12,7 @@ Getestete Version: Es wurden keine Tracker gefunden Diese App braucht keine Berechtigungen - Es gibt keinen Bericht für die installierte Version, die gezeigte Informationen basieren auf eine andere (wahrscheinlich ältere) Version + Es gibt keinen Bericht für die installierte Version (%1$s), die gezeigte Informationen basieren auf eine andere (%2$s) Version Diese App wurde von Exodus noch nicht analysiert Ihr System scheint den Zugriff auf die Appliste nicht zu erlauben. Es scheint, dass keine App aus der Quelle, die wir prüfen (Google Play Store), installiert ist. diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index eda5e6b..5f72df6 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -12,7 +12,7 @@ Versión verificada: Ningún rastreador verificado ha sido encontrado Esta applicación no requiere autorizaciones - No existe informe para la versión instalada, las informaciones mostradas se basan en otra versión (seguramente más antigua) + No existe informe para la versión instalada (%1$s), las informaciones mostradas se basan en otra versión (%2$s) Esta applicación aún no ha sido analizada por Exodus Privacy. Parece que tu sistema no autoriza el acceso a la lista de aplicaciones instaladas. Parece que no tienes ninguna aplicación de la plataforma que analizamos (Google Play). diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index fd8f55e..22bf788 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -12,7 +12,7 @@ Version testée : Aucun pisteur testé n\'a été trouvé Aucune autorisation n\'est demandée par cette application - Il n\'y a pas de rapport pour la version installée, les informations affichées sont basées sur une autre version (vraisemblablement plus ancienne) + Il n\'y a pas de rapport pour la version installée (%1$s), les informations affichées sont basées sur une autre version (%2$s) Cette application n\'a pas encore été analysée par Exodus Privacy. Votre système semble ne pas donner accès aux applications installées. Vous semblez n\'avoir aucune application installée par la source que nous recherchons (Google Play). diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index 47a591f..af4d1ae 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -12,7 +12,7 @@ Versione testata: Nessun tracciatore testato trovato Nessuna autorizzazione richiesta dall\'applicazione - Non ci sono report per la versione installata, le informazioni mostrate sono basate su un\'altra (presumibilmente più vecchia) versione + Non ci sono report per la versione installata (%1$s), le informazioni mostrate sono basate su un\'altra (%2$s) versione Questa app non è ancora stata analizzata da Exodus Privacy. Sembra che il tuo sistema non permetta l\'accesso all\'elenco di app installate. Sembra che tu non abbia alcuna app installa dalla fonte che testiamo (Google Play store). diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 577f292..6a76a8c 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -12,7 +12,7 @@ Tested Version: No tested trackers were found No permissions are requested by this application - There\'s no report for the installed version, the information displayed is based on another (presumably older) version + There\'s no report for the installed version (%1$s), the information displayed is based on another (%2$s) version This app hasn\'t been analysed by Exodus Privacy yet. It appears that your system doesn\'t allow access to the list of installed apps. It appears that you don\'t have any apps installed from the source we test (Google Play store). From 913bad937fa71559de15aa8d65737ad8d789be4a Mon Sep 17 00:00:00 2001 From: Tom Delmas Date: Thu, 21 Feb 2019 23:37:43 +0100 Subject: [PATCH 2/2] Fix --- .../exodusprivacy/adapters/ApplicationListAdapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java b/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java index e7311d8..8ee4804 100644 --- a/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java +++ b/app/src/main/java/org/eu/exodus_privacy/exodusprivacy/adapters/ApplicationListAdapter.java @@ -219,7 +219,7 @@ public class ApplicationListAdapter extends RecyclerView.Adapter { appItemBinding.appTrackerNb.setBackgroundResource(R.drawable.square_red); if(versionName != null && !report.version.equals(data.versionName)) { - String string = context.getString(R.string.tested,versionCode,report.versionCode); + String string = context.getString(R.string.tested,versionName,report.version); appItemBinding.otherVersion.setText(string); appItemBinding.otherVersion.setVisibility(View.VISIBLE); } else if (versionName == null && report.versionCode != versionCode) {