Commit Graph

322 Commits

Author SHA1 Message Date
Meitar M 4e4f981b8c
Fix bug where some pages where not shown as tiles.
This commit refactors the `tiles.html` include file so that when the
`site.tiles-source` is pages, pages with `show_tile: false` set in their
Front Matter are not counted as having been shown. Prior to this commit,
such pages were iterated over in the `for` loop, consuming a loop
iteration from the `site.tiles-count` counter.

Put another way, say you have set `tiles-count` to 6, and you have a
total of 10 pages. Of these ten pages, six have `show_tile` set to
`false`. The natural expectation would be that the home page layout
would display four tiles (10 - 6 = 4), but in fact, the exact number of
page tiles shown would depend on the specific lexicographical ordering
of the `site.html_pages` array, which could result in fewer than four
page tiles being shown.

This commit fixes the issue by excluding pages with `show_tile` set to
`false` first, and only then iterating over the remaining pages.
2020-01-31 14:21:40 -05:00
Meitar M 8c70ecf005
Fix invalid HTML caused by doubly-nested `<p>` element. 2020-01-31 13:27:27 -05:00
Meitar M b8721c353e
Fix relative paths to images when a permalink is used.
This commit uses the Jekyll `link` tag to correctly construct the URL to
images with otherwise relative paths. Without this logic, the images
would only load when the landing page's permalink was not altered by the
user. For example, if the permalink is changed to `get-started` in the
Jekyll Front Matter, the relative URLs would become:

    get-started/assets/images/pic08.jpg

However, since the `get-started` path doesn't really exist, this would
fail to load the image.

As of Jekyll 4.0, the `link` tag is safe to use without prepending
`site.baseurl`, so this code works in all situations.
2020-01-31 13:01:47 -05:00
Meitar M 033cfa2c44
Add page titles to `<title>` element. 2020-01-30 19:20:58 -05:00
Andrew Banchich 04f5e6f9f6 Update .gitlab-ci.yml 2020-01-13 01:46:18 +00:00
Andrew Banchich 17d8fd9a3f Update forty_jekyll_theme.gemspec 2020-01-13 01:46:04 +00:00
Andrew Banchich 5a2002e002 Update .gitlab-ci.yml 2020-01-13 01:42:32 +00:00
Andrew Banchich da9962859b Merge branch 'bugfix' into 'master'
Fix bug causing non-HTML pages to be displayed in tiles.

Closes #22

See merge request andrewbanchich/forty-jekyll-theme!6
2020-01-13 01:36:21 +00:00
Andrew Banchich 49ab386a3d Fix bug causing non-HTML pages to be displayed in tiles. 2020-01-12 20:31:35 -05:00
Andrew Banchich 2a58340b3a Update forty_jekyll_theme.gemspec 2019-09-15 18:52:07 +00:00
Andrew Banchich 8f27899858 Merge branch 'patch-1' into 'master'
Fixed a typo

See merge request andrewbanchich/forty-jekyll-theme!5
2019-06-15 12:03:35 +00:00
Louis da38a9ffe6 Fixed a typo 2019-06-13 02:38:58 +00:00
Andrew Banchich 4f5766eee6 Fix #8 2018-09-09 17:13:48 +00:00
Andrew Banchich 10a9b45f6e Add flexibility to end tiles 2018-09-09 17:04:43 +00:00
Andrew Banchich 548b8385f2 Fix Home, All Posts, and 404 pages displaying in tiles 2018-09-09 16:53:34 +00:00
Andrew Banchich 9ecf46b951 Update README.md 2018-08-25 16:36:16 +00:00
Andrew Banchich f5dc35bb82 Update README.md 2018-08-25 16:32:13 +00:00
Andrew Banchich 4d47ba1447 Update README.md 2018-08-25 16:26:03 +00:00
Andrew Banchich a6259c1274 Bugfix for 404 page showing in All Pages list 2018-08-05 14:35:00 -04:00
Andrew Banchich 2738786514 Update 404.md 2018-07-02 23:29:54 +00:00
Andrew Banchich 989a40ea5a Update 404.md 2018-07-02 23:26:08 +00:00
Andrew Banchich f906852f59 Update 404.md 2018-07-02 23:23:26 +00:00
Andrew Banchich 0362606c9f Add new file 2018-07-02 23:22:49 +00:00
Andrew Banchich 0ef4ba8785 Update _config.yml 2018-03-16 22:09:25 +00:00
Andrew Banchich 855234aa3d Update _config.yml 2018-03-16 22:06:33 +00:00
Andrew Banchich 9f1b902c04 Update footer.html 2017-07-05 22:13:04 +00:00
Andrew Banchich daf7251b02 Update footer.html 2017-07-05 22:09:33 +00:00
Andrew Banchich 82d7650720 Update footer.html 2017-07-05 22:00:34 +00:00
Andrew Banchich 7083911f0a Update all_posts.md 2017-07-05 21:55:02 +00:00
Andrew Banchich a62f33addf Update elements.md 2017-07-05 21:54:43 +00:00
Andrew Banchich 868e0cb0da Update header.html 2017-07-05 21:50:45 +00:00
Andrew Banchich a72185abbe fixes images not resizing 2017-05-24 21:58:12 -04:00
Andrew Banchich 6014a0b026 fixes 2017-05-16 20:33:56 -04:00
Andrew Banchich 7f3d42b344 scss fixes and header text wrapping goodness 2017-05-16 20:28:50 -04:00
Andrew Banchich 63334bd3f3 Delete CHANGELOG.md 2017-04-23 01:18:36 +00:00
Andrew Banchich a2c41000d8 fixes landing page 2017-04-22 21:11:19 -04:00
Andrew Banchich 24ab415c94 Merge branch 'master' of https://github.com/andrewbanchich/forty-jekyll-theme 2017-04-22 21:03:01 -04:00
Andrew Banchich 4f3384d2a3 fixes some bugs in landing template. will fix the rest asap 2017-04-22 21:02:18 -04:00
Andrew Banchich a747ae12f2 Update header.html 2017-04-22 20:45:51 -04:00
Andrew Banchich 663d94403b Merge pull request #20 from daudi/all_posts
Added layout and page for All posts
2017-04-22 20:42:11 -04:00
David Whiting b05018909f Wrapped if statement around post.date 2017-04-22 12:01:45 +01:00
David Whiting 0d6e5bcddd Added layout and page for All posts 2017-04-17 16:16:02 +01:00
Andrew Banchich 2da3764cd5 Update .gitlab-ci.yml 2017-03-02 18:58:37 +00:00
Andrew Banchich 1c6441dd1f Update .gitlab-ci.yml 2017-03-01 00:50:04 +00:00
Andrew Banchich e46e46fdeb Update .gitlab-ci.yml 2017-03-01 00:14:47 +00:00
Andrew Banchich 25fe79db25 Update .gitlab-ci.yml 2017-02-11 03:38:31 +00:00
Andrew Banchich 2048dd40d6 Update .gitlab-ci.yml 2017-02-11 03:31:58 +00:00
Andrew Banchich 6376927a18 fixes path issues 2017-02-05 15:25:48 -05:00
Andrew Banchich 752c7b2c61 fixes path issues 2017-02-05 15:24:50 -05:00
Andrew Banchich 9e22d5263d removes url setting from config 2017-02-05 15:13:03 -05:00