vaultwarden
/
bitwarden-estensione-browser
mirror of https://github.com/bitwarden/browser
1
0
Fork 0
Code Issues 1 Releases Wiki Activity
bitwarden-estensione-browser/apps/browser
History
Daniel James Smith ec19fc7225
[PS-2072] Browser Badge fixes (#4363) 
* Force update of badge icon and text on all windows

Affects MV2 and MV3
No longer pass in tab and windowId to setLoggedOut and setLocked

When the vault is locked or the user logs out, all open windows/tabs need to be updated

Iterating over all active tabs like in 2022.10.1 was missing:

488734577f/apps/browser/src/background/main.background.ts (L859-L867)

Create clearBadgeText function to take care of it.

* Only try to retrieve tab in unlocked state

* Remove lock icon when unlocking on all windows

* Only use windowId to retrieve tab when defined

In MV2 the `windowId` isn't passed into updateBage and fails to retrieve the correct tab to update.

This resorted in the badge not showing a match count in another window.

Fixes #4260

Ensure in MV3 that all listener pass on the windowId if present.

* Fix Firefox private mode

Only pass on the windowId if defined and within Firefox

In private mode the main.background bootstrap-method passes in the windowId

Do not refreshBadge when in private mode

Previously 488734577f/apps/browser/src/background/main.background.ts (L575-L586) setIcon would skip in private mode. Calling refreshBadge without this would update the badge on all windows (normal and private ones)
 		2023-01-03 18:06:21 +01:00
..
.vscode Multi root workspace tweaks (#2858) 2022-06-13 21:39:36 -05:00
config Use settings in base.json and merge config keys (#3804) 2022-10-18 12:00:40 +10:00
src [PS-2072] Browser Badge fixes (#4363) 2023-01-03 18:06:21 +01:00
store Autosync the updated translations (#4310) 2022-12-23 01:24:59 +01:00
.gitignore Simplify our gitignore files (#2925) 2022-06-17 15:33:51 +02:00
README.md Update urls to match the contributing docs (#4192) 2022-12-06 11:20:27 +01:00
crowdin.yml Fix Crowdin Pull workflow (#2667) 2022-05-10 10:20:32 -04:00
gulpfile.js [PS-1184] Remove specific keyboard shortcut logic (#3173) 2022-09-08 14:48:45 +02:00
jest.config.js [EC-423] Fix unit tests (#3265) 2022-08-11 11:35:08 +10:00
package.json Bumped browser version to 2022.12.1 (#4280) 2022-12-20 10:21:21 -05:00
test.setup.ts PS-1133 Feature/mv3 browser observable memory caching (#3245) 2022-08-16 07:05:03 -05:00
tsconfig.json [SM-252] Enable strict templates (#3601) 2022-11-28 18:59:46 +01:00
tsconfig.spec.json [EC-423] Fix unit tests (#3265) 2022-08-11 11:35:08 +10:00
webpack.config.js [PS-1829] Fix Service Worker Startup in MV3 (#4000) 2022-11-17 15:15:34 -05:00

README.md

Github Workflow build browser on master Crowdin Join the chat at https://gitter.im/bitwarden/Lobby

Bitwarden Browser Extension

The Bitwarden browser extension is written using the Web Extension API and Angular.

My Vault

Documentation

Please refer to the Browser section of the Contributing Documentation for build instructions, recommended tooling, code style tips, and lots of other great information to get you started.