Merge a5ad899fcb into a4f1a3f13d

Use unique port names for derived states (#8938 )
use platformUtilsService.isDev instead of process.env.ENV
2024-04-26 14:26:23 -04:00 · 2024-04-26 16:17:34 +00:00 · 2024-04-25 17:14:03 -04:00 · 2024-04-25 17:11:47 -04:00
2 changed files with 6 additions and 5 deletions
--- a/apps/browser/src/background/runtime.background.ts
+++ b/apps/browser/src/background/runtime.background.ts
@ -318,9 +318,10 @@ export default class RuntimeBackground {

      if (this.onInstalledReason != null) {
        if (this.onInstalledReason === "install") {
-          // FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
-          // eslint-disable-next-line @typescript-eslint/no-floating-promises
-          BrowserApi.createNewTab("https://bitwarden.com/browser-start/");
+          if (!this.platformUtilsService.isDev()) {
+            void BrowserApi.createNewTab("https://bitwarden.com/browser-start/");
+          }
+
          await this.autofillSettingsService.setInlineMenuVisibility(
            AutofillOverlayVisibility.OnFieldFocus,
          );
--- a/apps/browser/src/platform/state/background-derived-state.provider.ts
+++ b/apps/browser/src/platform/state/background-derived-state.provider.ts
@ -18,12 +18,12 @@ export class BackgroundDerivedStateProvider extends DefaultDerivedStateProvider
    dependencies: TDeps,
    storageLocation: [string, AbstractStorageService & ObservableStorageService],
  ): DerivedState<TTo> {
-    const [cacheKey, storageService] = storageLocation;
+    const [location, storageService] = storageLocation;
    return new BackgroundDerivedState(
      parentState$,
      deriveDefinition,
      storageService,
-      cacheKey,
+      deriveDefinition.buildCacheKey(location),
      dependencies,
    );
  }
Author	SHA1	Message	Date
Jonathan Prusik	bf06c88fcb	Merge `a5ad899fcb` into `a4f1a3f13d`	2024-04-26 14:26:23 -04:00
Matt Gibson	a4f1a3f13d	Use unique port names for derived states (#8938 )	2024-04-26 16:17:34 +00:00
Jonathan Prusik	a5ad899fcb	use platformUtilsService.isDev instead of process.env.ENV	2024-04-25 17:14:03 -04:00
Jonathan Prusik	54eb4885e1	suppress welcome window on install when extension is in dev mode	2024-04-25 17:11:47 -04:00