Commit Graph

57 Commits

Author SHA1 Message Date
Addison Beck bb7dce031c
[fix] Force send attachment to always download and never open (#2908)
* [refactor] Introduce a file download service

* [refactor] Point platformUtilsService.saveFile() callers to fileDownloadService.download() instead

* [refactor] Remove platformUtilsService.saveFile()

* [fix] Force send attachments to always download and never open

* [fix] Remove the window property from FileDownloadRequest

* [fix] Move FileDownloadRequest to /abstractions/fileDownload

* [fix] Simplify FileDownloadRequest to a type

* [fix] Move BrowserApi.saveFile logic into BrowserFileDownloadService

* [fix] Use proper blob types for file downloads

* [fix] forceDownload -> downloadMethod on FileDownloadRequest

* [fix] Remove fileType from FileDownloadRequest

* [fix] Make fileType private
2022-06-29 17:15:29 -04:00
Patrick H. Lauke 3ae30d866c
[PS-1030] Desktop: suppress `user-select` for most interface elements (#2650)
* Desktop: suppress user-select for most interface elements

* Better way to target .box-footer

make it non-selectable everywhere (to avoid missing stragglers) but explicitly make it selectable in the `app-vault-view` (so we can select the "Updated: ..." footer text)

* Prettier

* Remove orphaned jslibs
2022-06-29 21:13:20 +02:00
github-actions[bot] d71161be3b
Bumped desktop version to 2022.6.0 (#3005)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-29 11:24:14 -05:00
Matt Gibson 399b8c2b34
PS-813 Add memory storage to state service (#2892)
* Use abstract methods and generics in StorageService

* Prepend `Abstract` to abstract classes

* Create session browser storage service

* Use memory storage service for state memory

* Inject memory storage service

* Maintain filename extensions to help ide formatting

* Preserve state if it's still in memory

* Use jslib's memory storage service

* linter

* Create prototypes on stored objects

* standardize package scripts

* Add type safety to `withPrototype` decorators

* webpack notify manifest version

* Fix desktop

* linter

* Fix script

* Improve prototye application

* do not change prototype if it already matches desired
* fix error with object values prototype application

* Handle null state

* Apply prototypes to browser-specific state

* Add angular language server to recommended extensions

* Improve browser state service tests

* Start testing state Service

* Fix abstract returns

* Move test setup files to not be picked up by default glob matchers

* Add key generation service

* Add low-dependency encrypt service

* Back crypto service with encrypt service.

We'll want to work items that don't require state over to encrypt service

* Add new storage service and tests

* Properly init more stored values

* Fix reload issues when state service is recovering state from session storage

Co-authored-by: Thomas Avery <Thomas-Avery@users.noreply.github.com>
Co-authored-by: Justin Baur <admin@justinbaur.com>

* Simplify encrypt service

* Do not log mac failures for local-backed session storage

* `content` changed to `main` in #2245

* Fix CLI

* Remove loggin

* PR feedback

* Merge remote-tracking branch 'origin/master' into add-memory-storage-to-state-service

* Fix desktop

* Fix decrypt method signature

* Minify if not development

* Key is required

Co-authored-by: Thomas Avery <Thomas-Avery@users.noreply.github.com>
Co-authored-by: Justin Baur <admin@justinbaur.com>
2022-06-27 12:38:12 -05:00
Robyn MacCallum c044c5c770
Use ngSwitchDefault so that ‘singleOrgPolicy’ affected users see org filter (#2975) 2022-06-27 09:09:51 -04:00
github-actions[bot] ce707d2e05
Autosync the updated translations (#2968)
Co-authored-by: github-actions <>
2022-06-24 13:21:07 +02:00
Addison Beck e00fe8edae
[fix] Unsubscribe from activeAccount in AppComponent (#2960) 2022-06-23 09:38:12 -04:00
Addison Beck 57b8144013
[refactor] Introduce ThemingService (#2943)
* [refactor] Introduce ThemingService

* [refactor] Implement ThemingService for web

* [refactor] Implement ThemingService on browser

* [refactor] Implement ThemingService for desktop

* [refactor] Remove deprecated platformUtils.service theme methods

* [fix] Move ThemingService from libs/common to libs/angular

* [fix] Simplify ThemeBuilder's constructor

* [fix] Dont notify subscribers of null values from theme$

* [fix] Always notify PaymentComponent of theme changes
2022-06-23 07:36:05 -04:00
Andreas Coroiu fd69e163ff
[PS-683] Update negative copy (#2912)
* feat(browser): Update auto biometrics copy

* refactor(common): remove TotpService.isAutoCopyEnabled and use state directly

The TotpService was just taking the value from StateService and forwarding it, making it depend on state service.
All services that depended on the TotpService.isAutoCopyEnable flag also depended on StateService.
This therefore simplifies things by using StateService directly.

* feat(browser): update auto totp copy

* feat(browser): update add login notification copy

* feat(browser): update change password notification copy

* feat(browser): update context menu copy

* feat(browser): update show cards current tab copy

* feat(browser): update show identities current tab copy

* feat(browser): update enable favicon copy

* feat(browser): update badge counter copy

* feat(browser): update auto-fill copy

* feat(desktop): update auto biometrics prompt copy

* feat(desktop): update favicon copy

* feat(desktop): adjust copy

* feat(web): update favicons copy

* feat(web): adjust copy

* feat(web): update preference settings to sentence case

* feat(browser): update settings and options page to sentence case

* feat(desktop): update settings to sentence case

* feat(web): update copy

* feat(desktop): update copy
2022-06-23 09:53:42 +02:00
Vince Grassia fdc1ecef98
Update Plist files for MAS (#2951) 2022-06-22 15:10:21 -04:00
Oscar Hinton 19caa7bfe0
Simplify our gitignore files (#2925) 2022-06-17 15:33:51 +02:00
github-actions[bot] e817d68e6a
Autosync the updated translations (#2920)
Co-authored-by: github-actions <>
2022-06-17 09:53:49 +02:00
Jake Fink ba0e33881f
center hcaptcha in connector and fix formatting on desktop (#2911) 2022-06-16 09:53:18 -04:00
Oscar Hinton bc639688e8
Use NPM workspace (#2874) 2022-06-14 17:10:53 +02:00
Matt Gibson c4ff8f99dc
Multi root workspace tweaks (#2858)
* Ignore jest for workspaces without tests (for now)

* Add jest as recommended extension

* Set eslint and prettier file paths

We can't do this on a multi-folder workspace level because the
path depths are not identical between folders

* fix tsconfig extends for

* Simplify bitwarden-licensed web tsconfig

This tsconfig isn't needed to build, since we do that through webpack
and the web client. It's only needed as hints to IDEs

* Remove unintended change

* linter
2022-06-13 21:39:36 -05:00
Robyn MacCallum e8a1c60ed5
Fix filter ‘No Folder’ check (#2895) 2022-06-13 07:16:04 -04:00
Thomas Rittson 3b857345bb
Update README and CONTRIBUTING to point to contributing.bitwarden.com (#2771)
Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
2022-06-13 17:34:07 +10:00
github-actions[bot] 4c1ecc5bdf
Autosync the updated translations (#2890)
Co-authored-by: github-actions <>
2022-06-10 16:12:40 +02:00
github-actions[bot] 378a1d5a73
Autosync the updated translations (#2883)
Co-authored-by: github-actions <>
2022-06-10 10:54:00 +02:00
Jake Fink c1b559f2b0
[PS-526] Allow loading accessibility cookie on desktop (#2709)
* add accessibility cookie page

* linting

* add accessibility button to captcha

* add message descriptions and reactive forms

* prettier
2022-06-09 08:14:31 -04:00
github-actions[bot] 656d40a2ca
Bumped desktop version to 2022.5.2 (#2866)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-08 14:51:27 -04:00
github-actions[bot] 3a334156cd
Bumped desktop version to 2022.5.1 (#2862)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-08 10:58:02 -04:00
Vince Grassia 3d4c5fea4d
Add NSIS custom installer script for UAC fix on Windows (#2856) 2022-06-08 08:47:10 -04:00
github-actions[bot] c139ff3963
Autosync the updated translations (#2851)
Co-authored-by: github-actions <>
2022-06-07 15:55:49 +02:00
Michał Chęciński bd6cdf3aa3
Devops 829 Add electron beta channels (#2838)
* Add option for beta channels in package.json for electron

* Change placement of build settings

* Add version

* Revert "Add version"

This reverts commit 2e09cc7d5e.

* Add electron version to package.json

* Move build to higher level

* Add upload beta autoupdate

* Revert version

* Updating the release workflow with the new channels

* restrict GitHub Release to only 'latest'

* fixing electron-builder configuration

* version bump test

* fixing words

* Commenting out the npm cache in the windows build job

* Adding back in the caching for the future

* Revert "version bump test"

This reverts commit b732d00841.

Co-authored-by: Joseph Flinn <joseph.s.flinn@gmail.com>
2022-06-07 15:44:25 +02:00
github-actions[bot] c8ef4d168e
Autosync the updated translations (#2818)
Co-authored-by: github-actions <>
2022-06-07 14:54:13 +02:00
Oscar Hinton 5780bf85e7
Add support for migrated jslib (#2826) 2022-06-03 18:01:07 +02:00
github-actions[bot] 0254a838eb
Bumped desktop version to 2022.5.0 (#2777)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-02 13:18:50 -04:00
github-actions[bot] 4ce84cad4f
Bumped desktop version to 2022.05.0 (#2773)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-06-02 09:48:08 -04:00
Oscar Hinton 12c4a3e7f8
[EC-236] Move dependencies to root package.json (#2720) 2022-06-02 15:18:29 +02:00
Jake Fink f57f97fcdc
show error when trying to enable browser integration on desktop (#2754) 2022-05-31 10:10:34 -04:00
Gbubemi Smith ccfcb36f1c
sync jslib master with client (#2753) 2022-05-27 19:09:01 +01:00
Thomas Rittson 6a861d4fcd
Update jslib (#2751) 2022-05-27 13:11:45 +10:00
Thomas Rittson 8519decb7c
[EC-177] Update Key Connector error handling (#2748)
* Update jslib, deps and messages.json
2022-05-26 11:16:05 +10:00
CarleyDiaz-Bitwarden 60b39bc211
Clearing the search bar when switching accounts (#2685)
* Clearing the search bar when switching accounts

* Fixing Lint Issues and Prettier

* Updating the message to use switchAccount instead of a new message name "clearSearchBarText"

* Updating to use Observable on activeAccount

* adding back line

* adding back line

* Adding OnInit OnDestroy
2022-05-23 14:04:19 -04:00
Robyn MacCallum b19fa11591
Fix 'Add Send' button being outside section (#2706) 2022-05-19 17:10:10 -04:00
Addison Beck 39af27da3f
[fix] Pass deleted param to CiphersComponent.reload() (#2703) 2022-05-18 16:37:24 -04:00
Patrick H. Lauke eb7586c09a
Custom webkit scrollbar styles for `.vault-filters` (#2694) 2022-05-18 12:00:58 -04:00
Addison Beck 141a54dbbe
[fix] Be more precise about what is reloaded in the vault on sync complete (#2701) 2022-05-18 10:46:50 -04:00
Addison Beck ee43ef9ba1
[fix] Prefill add cipher form from filter data (#2700) 2022-05-18 10:36:33 -04:00
Patrick H. Lauke c4fe38d493
Fix styling for vault cipher list scroller (#2693)
- following recent change in structure, with `<app-vault-ciphers>`, the flex styles were one level too high. retargets the selector to the first child `<div>`
2022-05-18 09:56:26 -04:00
Addison Beck 06e25147cd
[fix] Reload organization filter options on sync complete (#2696)
* [fix] Reload organization filter options on sync complete

* [dep] Update jslib
2022-05-17 21:08:29 -04:00
Addison Beck 7af2e9aa31
[fix] Truncate text buttons on overflow (#2695) 2022-05-17 15:42:37 -04:00
CarleyDiaz-Bitwarden f66129e076
[PS-124] Update so the image for the clear search button is visible in all themes (#2639)
* Update so the image for the clear search button is visible in all themes

* Whitespace updates

* changes from master

* Revert "changes from master"

This reverts commit 33ccee3d9181b9442000a22dfc17d1422a4948d9.

* fixing linting issue with header.scss
2022-05-16 17:09:54 -04:00
Kyle Spearrin 4f0e5a8592
remove hostname from simplelogin. update jslib (#2680)
* remove hostname from simplelogin. update jslib

* remove root jslib
2022-05-13 12:24:50 -04:00
Thomas Rittson 2a11b2c534
Update jslib (#2677) 2022-05-11 12:10:04 +10:00
Vince Grassia c260464f96
Fix Crowdin Pull workflow (#2667) 2022-05-10 10:20:32 -04:00
Vince Grassia 7873d4c030
Update bitwarden.nuspec (#2668) 2022-05-10 09:13:47 -04:00
Oscar Hinton c402adeec5
[EC-193] Remove the symlink scripts (#2644) 2022-05-09 18:09:02 +02:00
Oscar Hinton 560fbee16e
Update repo urls for desktop, remove download-legacy-safari (#2664) 2022-05-09 17:49:59 +02:00