Commit Graph

54 Commits

Author SHA1 Message Date
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Kyle Spearrin bf081e0322
username generator (#2468)
* username generator

* pass usernameWebsite

* update jslib ref

* update jslib ref

* update jslib ref

* update jslib ref

* Update jslib to point to jslib master

* Updated package-lock.json after running npm i

* add missing translations

* pr feedback

Co-authored-by: Daniel James Smith <djsmith@web.de>
2022-03-30 17:59:58 -04:00
Vincent Salucci ebbf1d8b90
[Help] Update links to new pattern (#2324)
* [Help] Update links to new pattern

* Update jslib
2022-02-08 17:44:56 -06:00
Vincent Salucci 9c60563939
[Icons] FF - requested icon changes (#2306)
* [Icons] Remove FA

* Icon changes
2022-02-03 10:25:38 -06:00
Vincent Salucci 33314869f0
[Icons] Update Font Sheet (#2272)
* [Icons] Update Font Sheet

* Prettier updates

* Updated refresh -> generate

* Updated closed folder icon

* Reverted to using a base class

* Update jslib

* Removed unused import

* Updated eye/eye-slash icon references

* Update jslib

* Updating fallback image for cipher icon

* Update jslib

* Removed duplicate icon base class

* Update jslib

* Prettier

Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-28 04:53:06 -06:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Patrick H. Lauke 6e050349e4 Add aria-pressed attribute to all toggleVisibility buttons
Closes https://github.com/bitwarden/browser/issues/2228
2021-12-18 20:22:11 +00:00
Patrick H. Lauke 1916136f4c Merge branch 'master' into patrickhlauke-issue1987 2021-12-13 17:37:42 +00:00
Thomas Rittson cf28435ce3
[Key Connector] Add support for key connector and OTP (#2156)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2021-11-09 18:59:51 +01:00
Thomas Rittson 2113c709a4
[Linked fields] Add Linked Field as a custom field type (#1963)
* Proof of concept for Linked custom field type

* Linked Fields for all cipher types, use dropdown

* Fix linked icon alignment

* Tweak linked icon alignment and style

* Move add-edit custom fields to own component

* Disable copy for linked field

* Use Field.LinkedId to store linked field info
2021-11-04 07:40:42 +10:00
Patrick H. Lauke c8fc7ee6fc Add basic heading markup 2021-11-02 22:41:17 +00:00
Patrick H. Lauke f359a1c2be Merge branch 'master' into patrickhlauke-a11y-patch2 2021-09-28 19:50:11 +01:00
Thomas Rittson 10734fc024
Move custom fields to separate components (#2072)
* Move add-edit custom fields to own component

* Fix linting and mistakes

* Update directive

* Removed linked fields work

* Move view custom fields to own component

* Remove unnecessary imports

* Wrap template in ng-container

* Update jslib

* Fix imports
2021-09-21 10:49:05 +10:00
Patrick H. Lauke d528d72b4d Change links to buttons
- more semantically accurate, will expose these as buttons to assistive technologies
- note: while having block-level elements like `<div>` inside a `<button>` is an html validation error, it does not affect functionality as long as there's no more structure inside it
2021-07-31 20:50:46 +01:00
Oscar Hinton 78b1ae9a6a
Add reprompt help link (#1908) 2021-06-21 20:55:39 +02:00
Thomas Rittson d4055a7613 Only show autofill options if enabled 2021-05-17 13:46:39 +10:00
Thomas Rittson 13b0e09c2c Merge branch 'master' into feature-aopl-options 2021-05-14 10:55:14 +10:00
Oscar Hinton cdc71dd661
Password reprompt (#1784)
* Add support for password reprompt

* Rename passwordPrompt to reprompt.

* Move showPasswordDialog to paltformutils

* Fix swal2 validation error styling

* Group imports

* Update src/_locales/en/messages.json

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2021-05-03 20:56:38 +02:00
Thomas Rittson 89dd393c32 Update UI 2021-04-07 10:45:12 +10:00
Thomas Rittson 4956cf9d8d Fix linting 2021-03-15 12:35:23 +10:00
Tom Rittson 384b352a97 add UI warnings for new autofill on page load 2021-03-12 11:51:13 +10:00
Tom Rittson de809136a2 add UI for new autofill on page load options 2021-03-12 11:51:13 +10:00
Thomas Rittson 092110fd5f Close popout instead of navigating, style fixes 2021-01-15 16:04:35 +10:00
Thomas Rittson 3844fdb959 Pop out attachments page on Firefox and Safari 2021-01-14 14:03:59 +10:00
Vincent Salucci 8af54375f3
[Policy] Personal Ownership banner (#1523)
* Initial commit of ownership banner

* updated capitlization
2021-01-05 17:34:00 -06:00
Matt Gibson 0cd6efd67f
Move share from edit to view. Fix animations (#1497)
* Move share from edit to view. Fix animations

Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.

Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme

* Update jslib reference
2020-12-17 11:06:31 -06:00
Vincent Salucci a1542f050d
[Policy] Personal Ownership (#1481)
* Initial commit for personal ownership

* Removed TODO // Updated allowPersonalOwnership logic to include necessary org/user checks

* Fixed import order

* Updated jslib (dcbd09e -> 72bf18f)

* Fixed casing for error message
2020-12-09 14:11:25 -06:00
Anthony Garera d111a01b49
Updated expiration year placeholder text to be dynamic (#1272)
* Updated Example text to be dynamic to current year using New Date(); and then a Date pipe to display properly in the UI

* Removed change in the add-edit.component.ts file because it is now made in jslib
2020-07-03 22:46:42 -04:00
Kyle Spearrin 29b370961e
Cleanup current uris selection list (#1294) 2020-06-12 12:50:39 -04:00
Melanie Kanavakatini 32db40ec7f
persist browser context on popout, add uri options input & toggle (#1290)
* persist browser context on popout, add uri options input & toggle

* pass tab array to ngOptions, add null check
2020-06-12 11:01:08 -04:00
hinton d88ed609aa Disable TOTP field, disable edit and show of hidden fields. 2020-06-03 21:25:55 +02:00
hinton 5e4259db38 Add support for hidden password 2020-05-24 19:59:49 +02:00
Vincent Salucci 7d93ebe732
Added missing attachments conditional (#1145) 2020-02-19 14:00:37 -06:00
Vincent Salucci c57340c4f3
Implement personal item cloning capability (#1129)
* Initial pass of clone item

* Updated npm sub:pull script to include target branches

* Made requested changes

* Formatting changes

* Fixed lint warnings
2020-02-04 16:08:13 -05:00
Kyle Spearrin 60f6863e4f a11y work 2019-10-08 17:04:44 -04:00
Kyle Spearrin db83b042ff fix no collections padding 2019-06-24 20:38:26 -04:00
Kyle Spearrin 3fa7e976fb drag n drop adjustments 2019-03-28 16:28:04 -04:00
Kovah bca12e8fbd Drag n drop sorting for custom fields (#906)
* Try to fix some security vulnerabilities present in used packages

(Ran npm audit fix, solved some of the issues)

* Implement custom field ordering with new handle placement

(WIP, as an update for the jslib is needed to work correctly)

* Update reference for jslib

* Restore original state of package-lock.json

* Downgrade node sass package
2019-03-28 16:15:47 -04:00
Kyle Spearrin 44af1ccc45 format html files 2019-02-21 16:53:57 -05:00
ShirokaiLon d980f274e3 Add trackBy option (#853) 2019-02-02 22:32:18 -05:00
Kyle Spearrin 3d50bf88d0 share on create 2018-10-23 16:39:06 -04:00
Kyle Spearrin 80e71d4923 collection management 2018-10-23 12:16:27 -04:00
Kyle Spearrin 3d5ed8f66a make sure it has not been already shared 2018-10-23 10:37:56 -04:00
Kyle Spearrin db5855aa4b fixes and move to jslib share component 2018-10-23 10:29:05 -04:00
Cory ce7930bcc4 Added share functionality to cipher add-edit component (#758) 2018-10-23 09:25:44 -04:00
Kyle Spearrin 975913fee0 cant download attachments on edge 2018-07-24 23:23:44 -04:00
Kyle Spearrin f14b4b89b9 toggle card code on add/edit 2018-06-18 17:25:22 -04:00
Kyle Spearrin 0fc5982f26 use true false value directive for boolean field 2018-06-06 14:30:26 -04:00
Kyle Spearrin 73013d51e0 input verbatim 2018-04-25 17:53:51 -04:00
Kyle Spearrin cfcb8653f7 edge browser adjustments 2018-04-14 14:56:30 -04:00