Commit Graph

28 Commits

Author SHA1 Message Date
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Vincent Salucci 33314869f0
[Icons] Update Font Sheet (#2272)
* [Icons] Update Font Sheet

* Prettier updates

* Updated refresh -> generate

* Updated closed folder icon

* Reverted to using a base class

* Update jslib

* Removed unused import

* Updated eye/eye-slash icon references

* Update jslib

* Updating fallback image for cipher icon

* Update jslib

* Removed duplicate icon base class

* Update jslib

* Prettier

Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-28 04:53:06 -06:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Patrick H. Lauke c733f2def6 A11y: make expandable box headers actual buttons, expose state with aria-expanded
Closes https://github.com/bitwarden/browser/issues/1983
2021-12-19 17:26:57 +00:00
Patrick H. Lauke c8fc7ee6fc Add basic heading markup 2021-11-02 22:41:17 +00:00
Thomas Rittson 56e127d20c Merge branch 'master' into feature-aopl-options 2021-05-18 10:11:40 +10:00
Thomas Rittson 655877f75f reorder UI 2021-05-14 11:26:16 +10:00
Thomas Rittson 998f633210 Update UI per Options page redesign 2021-05-14 11:23:46 +10:00
Thomas Rittson af61732800 Copy TOTP after all autofills, remove old UI 2021-05-14 10:04:08 +10:00
Thomas Rittson 8c29cf7f33 Organize Options page and add headings 2021-05-05 13:57:50 +10:00
Thomas Rittson 0da4f7df73
Merge branch 'master' into copy-totp-on-auto-fill 2021-05-05 12:23:37 +10:00
Tomer Shvueli efd224d380 fix: Updated UI so option is no longer nested, added proper description 2021-04-30 10:48:20 -04:00
Tomer Shvueli 6eb7106bc5 fix: Nest sub option in Options page, tie auto fill & auto copy features together 2021-03-04 09:58:22 -05:00
Vlad eb59c9e692 browser version of 287 issue
added condition when badge should set text based on setting
2021-02-22 01:35:14 +03:00
Tomer Shvueli 72d0a439d2 feat: Add option to auto-copy TOTP code when page auto fills credentials 2021-02-20 14:48:54 -05:00
Oscar Hinton 3e79dd245b
Safari Web Extension Port from App Extension (#1531) 2021-02-03 20:36:05 +01:00
Chad Scharf 336f8f3117
Revert "Safari Web Extension Port from App Extension" 2021-01-13 17:08:33 -05:00
Hinton 7b5ec47ba5 Cleanup a few more safari things 2020-12-09 13:18:29 +01:00
Kyle Spearrin 60f6863e4f a11y work 2019-10-08 17:04:44 -04:00
Kyle Spearrin 9e24616bf9 dont show clear clipboard options for safari 2019-03-05 09:26:57 -05:00
Kyle Spearrin 5ae81b197a clear clipboard setting 2019-02-27 11:07:54 -05:00
Kyle Spearrin 44af1ccc45 format html files 2019-02-21 16:53:57 -05:00
Kyle Spearrin b6705bc338 remove analytics settings 2019-01-15 11:08:25 -05:00
Kyle Spearrin 2a3beacbe0 default match detection setting 2019-01-09 11:59:14 -05:00
Kyle Spearrin f043010067 option to not show cards/identities on current tab list 2018-11-21 14:31:34 -05:00
Kyle Spearrin 4076247908 option to disable change password notification 2018-07-31 23:48:11 -04:00
Kyle Spearrin 344cd2ac40 add theme support to browser extension 2018-05-30 17:26:43 -04:00
Kyle Spearrin 5bf7faa09a settings -> options page 2018-04-13 14:19:33 -04:00