Commit Graph

15 Commits

Author SHA1 Message Date
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
Patrick H. Lauke 58b39c613e
Remove unnecessary `role="button"` on `<button>` elements (#2514) 2022-04-21 14:33:20 +02:00
Vincent Salucci 33314869f0
[Icons] Update Font Sheet (#2272)
* [Icons] Update Font Sheet

* Prettier updates

* Updated refresh -> generate

* Updated closed folder icon

* Reverted to using a base class

* Update jslib

* Removed unused import

* Updated eye/eye-slash icon references

* Update jslib

* Updating fallback image for cipher icon

* Update jslib

* Removed duplicate icon base class

* Update jslib

* Prettier

Co-authored-by: Hinton <oscar@oscarhinton.com>
2022-01-28 04:53:06 -06:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Patrick H. Lauke 6e050349e4 Add aria-pressed attribute to all toggleVisibility buttons
Closes https://github.com/bitwarden/browser/issues/2228
2021-12-18 20:22:11 +00:00
Patrick H. Lauke c8fc7ee6fc Add basic heading markup 2021-11-02 22:41:17 +00:00
Patrick H. Lauke 6b0167a098
Merge branch 'master' into patrickhlauke-a11y-patch2 2021-09-18 17:47:59 +01:00
Vincent Salucci bb99af6e24
[SSO/Auto Enroll] Fix type for banner (#2073) 2021-09-16 23:00:40 -05:00
Vincent Salucci d7754441d3
[SSO/Auto Enroll] Set Password banner (#2050)
* [SSO/Auto Enroll] Set Password banner

* Fix merge conflict

* Add missing string/style

* Update jslib
2021-09-07 12:06:43 -05:00
Vincent Salucci 1c7504a691
[Callout] Update UI structure (#2020)
* [Callout] Update UI structure

* Update jslib
2021-08-27 17:04:45 -05:00
Patrick H. Lauke d528d72b4d Change links to buttons
- more semantically accurate, will expose these as buttons to assistive technologies
- note: while having block-level elements like `<div>` inside a `<button>` is an html validation error, it does not affect functionality as long as there's no more structure inside it
2021-07-31 20:50:46 +01:00
Kyle Spearrin b795f0e587
Fix CryptoFunctionService and implement syncLoading (#1371)
* Fix things and implement syncLoading

* feedback
2020-08-31 14:21:59 -04:00
Matt Smith 7c4ef9d8fc Modified correct file for feedback 2020-08-28 11:52:24 -05:00
Matt Smith b65d6582be Fixed ordering. Removed commented out code. 2020-08-25 11:08:35 -05:00
Matt Smith 91ce6527c0 Added set password flow to browser based SSO 2020-08-25 09:49:24 -05:00