Upgrade Electron to version 24, node to 18 and npm to 9. Electron changed to using node 18 in 23, with node 18 using npm 9 as default.
There doesn't seem to be any breaking changes except the deprecation of Windows 7, 8.1, and Server 2012. A somewhat undocumented breaking change was that elements in the title bar are now draggable which broke the account switching selector. Resolved by adding a no-drag css rule.
- electronjs.org/blog/electron-22-0
- electronjs.org/blog/electron-23-0
- electronjs.org/blog/electron-24-0
The importers recently got extracted from libs/common. As the import functionality is currently limited to the web and cli, there is no need to build browser and desktop as there won't be any changes.
This will free up some runners for other workflows (GH actions) to get faster builds that actually impact browser and desktop.
Another benefit is faster feedback on the PR-checks for those two
* Add tests step to build pipelines
* RUn tests for safari
* Remove tests step to build pipelines
* Run tests on root dir on pr
* Revert "Remove tests step to build pipelines"
This reverts commit 497bd86620.
* CHange name
* Remove working directory
* Add manual trigger
* Comment out cache
* Try to fix
* Revert "Try to fix"
This reverts commit 93d404b7d5.
* Disable failing test
* Add trigger when browser build completes
* Download artifacts from workflow run trigger
* Fix branch quotes
* Remove workflow run event trigger
* Add trigger step for desktop build
* Add current branch name for test purposes
* Change the branch name
* Add token retrieval from KeyVault
* Revert "Change the branch name"
This reverts commit 696157dc81.
* Fix json in request
* Add printing variables
* Change way of creating json string
* Change name of kv secret
Oscar Hinton
Michał Chęciński
Daniel James Smith
Opeyemi
Vince Grassia
Matt Gibson
Michał Chęciński
Joseph Flinn
Oscar Hinton