* Make <content> element explicitly non-focusable
Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.
* Change `<content>` to `<main>`
More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312
* Update scss to target `main` instead of `content`
* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly
Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
- more semantically accurate, will expose these as buttons to assistive technologies
- note: while having block-level elements like `<div>` inside a `<button>` is an html validation error, it does not affect functionality as long as there's no more structure inside it
* Move share from edit to view. Fix animations
Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.
Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme
* Update jslib reference
* Add autofill button to View cipher screen in Vault
* Add Autofill and Save button to View screen in Vault
* disable Vault Autofill buttons in popout
* tidy up 'autofill from vault' features as per feedback in PR #1367
Includes:
- remove duplicate code
- better handling of error and success messages
Patrick H. Lauke
Thomas Rittson
Melanie Kanavakatini
Vincent Salucci
Oscar Hinton
Matt Gibson
Thomas Rittson
Kyle Spearrin
K. Sasa
Matt Smith
Addison Beck
Hinton
Chad Scharf
Veit-Hendrik Schlenker
Kyle Spearrin