Commit Graph

352 Commits

Author SHA1 Message Date
Matt Gibson d4ff3ceb3b Skip unlocking unless locked, not only biometric locked (#2350)
(cherry picked from commit 45ed645cea)
2022-02-11 04:45:44 -05:00
Daniel James Smith 5cfb6619fc Fixing some regression issues (#2325)
* Pull jslib

* Extend vaultTimeoutServiceCallbacks to use userId

* Remove redundant call to tokenService.clear
2022-02-09 17:57:17 -05:00
addison 3dc763005e [bug] Dont block redirecting on logout 2022-02-08 10:10:46 -05:00
addison 036bade54d [bug] Clean state service on logout 2022-02-07 15:24:52 -05:00
addison 00fba252ce Update jslib 2022-02-03 14:17:40 -05:00
addison c4844b9943 [style] Ran prettier 2022-01-31 14:48:52 -05:00
addison 4f9a741278 [style] Lint fixes 2022-01-31 14:46:04 -05:00
addison f6e274a9a0 [chore] Update jslib 2022-01-31 14:21:06 -05:00
Daniel James Smith bd770c90ed
[Account Switching] Base changes for account switching (#2250)
* Pull in jslib

* Create new state models

* Create browser specific stateService

* Remove registration deprecated services, register stateService

* Replace usage of deprecated services (user, constants)

* Add missing properties to BrowserGroupingsComponentState

* Remove StorageService from initFactory

* Clear the correct state

* Add null check when restoring send-grouping state

* add remember email

* Initialize stateservice in services.module

* Fix 'lock now' not working

* Comment to remove setting defaults on install

* Pull jslib

* Remove setting defaults on install

* Bump jslib

* Pass the current userId to services when logging out

* Bump jslib

* Override vaultTimeout default on account addition

* Pull latest jslib

* Retrieve vaultTimeout from stateService

* Record activity per Account

* Add userId to logout and add fallback if not present

* Register AccountFactory

* Pass userId in messages

* Base changes for account switching di fixes (#2280)

* [bug] Null checks on Account init

* [bug] Use same stateService instance for all operations

We override the stateService in browser, but currently don't pull the background service into popup and allow jslib to create its own instance of the base StateService for jslib services.
This causes a split in in memory state between the three isntances that results in many errors, namely locking not working.

* [chore] Update jslib

* Pull in jslib

* Pull in jslib

* Pull in latest jslib to multiple stateservice inits

* Check vault states before executing processReload

* Adjust iterator

* Update native messaging to include the userId (#2290)

* Re-Add UserVerificationService

* Fix email not being remembered by base component

* Improve readability of reloadProcess

* Removed unneeded null check

* Fix constructor dependency (stateService)

* Added missing await

* Simplify dependency registration

* Fixed typos

* Reverted back to simple loop

* Use vaultTimeoutService to retrieve Timeout

Co-authored-by: Addison Beck <abeck@bitwarden.com>
Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-01-27 22:22:51 +01:00
Daniel James Smith aa8fe04a28
[UX] Change menu items for unauthed and locked vault (#2285)
* Change menu items for unauthed and locked vault

* Use 'Log in' instead of 'Login'
2022-01-25 08:17:01 +01:00
Daniel James Smith 71913a5eb5
Update badge number when saving a new entry (#2284)
* Rename message to changePasswordMessage

* Rename message variable to addLoginMessage

* Add early return and remove unneeded if below

* Update badge and menu after adding an entry

* Adjusted casing of enum properties

* Add explicit check for queueMessageType

* Turn NotificationQueueMessageType into simple enum
2022-01-25 08:16:36 +01:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Daniel James Smith 0174d239ca
Fix save prompt showing when disabled by user 2021-12-15 19:04:47 +01:00
Daniel James Smith ec502c06a5
Merge pull request #2180 from bitwarden/fix/save-when-locked
Don't save passwords if user is logged out
2021-11-17 20:33:02 +01:00
Daniel James Smith daf20bbf57
Do not prompt for new login if user is not logged in 2021-11-16 13:34:06 +01:00
Thomas Rittson f85a6958bc
Update jslib and service dependencies (#2179)
* Update service deps

* Fix linting

* Update jslib
2021-11-16 20:50:58 +10:00
Thomas Rittson 7b3f8d4223 Don't save passwords if user is logged out 2021-11-16 14:14:48 +10:00
Thomas Rittson cf28435ce3
[Key Connector] Add support for key connector and OTP (#2156)
Co-authored-by: Hinton <oscar@oscarhinton.com>
2021-11-09 18:59:51 +01:00
Kyle Spearrin 0039d4aaea
url encode data from msg_handler content script (#2170) 2021-11-09 12:26:17 -05:00
Daniel James Smith f3ed0329a8
Changed param of arrow function for check of CipherRepromptType 2021-11-09 09:43:11 +01:00
Daniel James Smith d448c402dc
Filter ciphers that have password reprompt set when using unlock on autofill via contextMenu 2021-11-05 14:18:59 +01:00
Thomas Rittson 2113c709a4
[Linked fields] Add Linked Field as a custom field type (#1963)
* Proof of concept for Linked custom field type

* Linked Fields for all cipher types, use dropdown

* Fix linked icon alignment

* Tweak linked icon alignment and style

* Move add-edit custom fields to own component

* Disable copy for linked field

* Use Field.LinkedId to store linked field info
2021-11-04 07:40:42 +10:00
Daniel James Smith dd7bfcdc12
Removed unnecessary brackets 2021-11-02 10:09:44 +01:00
Daniel James Smith 9d79bae1c8
When vault is locked also check for personal ownership policy 2021-10-29 18:50:55 +02:00
Daniel James Smith 439b1f52c0
Merge pull request #2132 from bitwarden/unlock-on-autofill
Unlock on autofill (shortcut and contextMenu)
2021-10-22 13:49:13 +02:00
Daniel James Smith f394cbf57f
Revert "Remove check for isVivaldi"
This reverts commit c318b58185.
2021-10-22 10:01:18 +02:00
Oscar Hinton ce2e6c3cb4
Remove empty catch blocks and remove allow-empty-catch tslint rule (#2136) 2021-10-21 11:10:46 +02:00
Daniel James Smith c318b58185
Remove check for isVivaldi 2021-10-20 17:52:10 +02:00
Daniel James Smith 39a189e7b3
Fixed formatting 2021-10-20 17:49:58 +02:00
Daniel James Smith fd9455873d
Add literal for noopCommand suffix 2021-10-20 17:45:19 +02:00
Daniel James Smith 6a02487778
Merge pull request #2134 from jesseliu612/master
solved a casing issue that may lead to build fail
2021-10-20 15:47:05 +02:00
Liu Junqi 75c0680968 solved a casing issue that may lead to build fail 2021-10-20 21:11:46 +08:00
Daniel James Smith d96b19b9fc
Merge branch 'master' of https://github.com/bitwarden/browser into reduce-binking-of-notificationBar 2021-10-19 18:55:47 +02:00
Daniel James Smith ec13cfd70c
Pick first cipher matching url as no specific cipher was selected by the user when vault is locked 2021-10-19 16:11:48 +02:00
Daniel James Smith de1d26bd8d
Add messageListener for unlockCompleted 2021-10-19 16:10:43 +02:00
Daniel James Smith 0e832ee435
Remove noop - openPopup and use promptForLogin instead when vault is locked 2021-10-19 16:09:50 +02:00
Daniel James Smith 0f000731b9
Pass tab onto getClickedElement, no need to look up the current tab 2021-10-19 16:04:32 +02:00
Daniel James Smith 421ab36215
Pass tab onto cipherAction, no need to look up the current tab 2021-10-19 16:03:39 +02:00
Daniel James Smith fc0c7a04b7
Add types for contextMenus.background 2021-10-19 16:00:38 +02:00
Daniel James Smith c793552dfd
Enable unlock on autofill via keyboard shortcut 2021-10-19 15:55:36 +02:00
Daniel James Smith 86e3b9e423
Add missing types 2021-10-19 14:15:15 +02:00
Daniel James Smith 3bb58baf45
Add types for addLogin and changePassword runtime messages 2021-10-19 12:10:31 +02:00
Daniel James Smith d4e91a81f9
Capitalize class name: LockedVaultPendingNotificationsItem 2021-10-19 11:20:55 +02:00
Daniel James Smith bed17673a8
Reduce blinking of notificationBar when other tabs update 2021-10-18 18:03:46 +02:00
Daniel James Smith 06e47dea17
Added types: Use chrome.tabs instead of any 2021-10-18 18:02:19 +02:00
Daniel James Smith 2299abe7a6
Make linter happy 2021-10-18 16:47:14 +02:00
Daniel James Smith 95e9387314
Remove logic out of notification content scripts 2021-10-18 16:42:32 +02:00
Daniel James Smith fd8de4ca0c
Use messages/events instead of main.unlockCompleted 2021-10-18 16:41:42 +02:00
Daniel James Smith 2699e0f5a0
Add types for common browser functions 2021-10-18 16:34:14 +02:00
Daniel James Smith 1bf7a7cad6
Perform null check on chrome.runtime 2021-10-18 16:31:59 +02:00