Several refactors were done on the data storage layer of jslib to support Account Switching for desktop.
These changes have been implemented here for parity across clients, improved readability, and to make it easier
to add Account Switching to other clients later if desired.
* The UserService was removed, and so all references have been replaced with the new access points for that data (activeAccount and organizationService most often)
* The StorageService is now considered a "global" scope, where as we have a new "account" scope to consider. Any "account" scope storage items I have moved to saving with
an ActiveAccountService instance instead of a StorageService instance.
* ConstantsServices have been removed and replaced with a StorageKey enum that holds keys that were in ConstantServices and in other feature scoped services.
* Move share from edit to view. Fix animations
Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.
Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme
* Update jslib reference
* Add autofill button to View cipher screen in Vault
* Add Autofill and Save button to View screen in Vault
* disable Vault Autofill buttons in popout
* tidy up 'autofill from vault' features as per feedback in PR #1367
Includes:
- remove duplicate code
- better handling of error and success messages
Robyn MacCallum
addison
Oscar Hinton
Thomas Rittson
Matt Gibson
Thomas Rittson
Vincent Salucci
Chad Scharf
Kyle Spearrin
Kyle Spearrin