Commit Graph

18 Commits

Author SHA1 Message Date
Robyn MacCallum 42bb8cd5f8 Run prettier 2021-12-21 14:48:22 -05:00
addison 2e793a31dd [style] Fix lint complaints 2021-12-17 14:53:21 -05:00
Robyn MacCallum 3fd627a67b Merge remote-tracking branch 'origin/master' into account-switching_refactor_implement-service-changes 2021-11-15 15:03:56 -05:00
Robyn MacCallum d476d4961a Initial swap from activeAccount to stateService 2021-11-12 16:11:38 -05:00
Oscar Hinton ce2e6c3cb4
Remove empty catch blocks and remove allow-empty-catch tslint rule (#2136) 2021-10-21 11:10:46 +02:00
Thomas Rittson 82138a08ff
[Refactor] Use rxjs first instead of unsubscribe from queryParams (#2112)
* Use rxjs first instead of unsubscribe

* Update jslib
2021-10-15 07:58:59 +10:00
addison 85e3436de6 [refactor] Replace references to deprecated services
Several refactors were done on the data storage layer of jslib to support Account Switching for desktop.
These changes have been implemented here for parity across clients, improved readability, and to make it easier
to add Account Switching to other clients later if desired.

* The UserService was removed, and so all references have been replaced with the new access points for that data (activeAccount and organizationService most often)
* The StorageService is now considered a "global" scope, where as we have a new "account" scope to consider. Any "account" scope storage items I have moved to saving with
an ActiveAccountService instance instead of a StorageService instance.
* ConstantsServices have been removed and replaced with a StorageKey enum that holds keys that were in ConstantServices and in other feature scoped services.
2021-10-11 10:42:31 -04:00
Oscar Hinton 4e1958f417
Add jslib as a "real" dependency (#1876)
* Support split jslib

* Fix tests

* Bump jslib
2021-06-07 19:25:37 +02:00
Vincent Salucci 61d7fcfc85
Fixed lint warnings (#1655) 2021-03-02 12:31:52 -06:00
Matt Gibson 0cd6efd67f
Move share from edit to view. Fix animations (#1497)
* Move share from edit to view. Fix animations

Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.

Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme

* Update jslib reference
2020-12-17 11:06:31 -06:00
Kyle Spearrin bbd32ed79d timeout of 200 ms before going back after share 2019-11-22 10:09:12 -05:00
Kyle Spearrin db43e247b9 optimizations 2019-05-10 14:10:40 -04:00
Kyle Spearrin aa290c50ec call init functions rather than super 2019-03-06 14:31:50 -05:00
Kyle Spearrin 7653ce2234 null checks on query param sub 2019-01-16 23:30:39 -05:00
Kyle Spearrin fd5d47da7c unsub from queryParams observable 2018-12-20 10:20:57 -05:00
Kyle Spearrin b83188993f go back to view after sharing 2018-10-23 16:17:30 -04:00
Kyle Spearrin db5855aa4b fixes and move to jslib share component 2018-10-23 10:29:05 -04:00
Cory ce7930bcc4 Added share functionality to cipher add-edit component (#758) 2018-10-23 09:25:44 -04:00