Commit Graph

68 Commits

Author SHA1 Message Date
Robyn MacCallum 42bb8cd5f8 Run prettier 2021-12-21 14:48:22 -05:00
Robyn MacCallum 40cbf61ab7 Merge remote-tracking branch 'origin/master' into account-switching_refactor_implement-service-changes 2021-12-21 14:44:09 -05:00
Robyn MacCallum 33bdef2114 Merge remote-tracking branch 'origin/master' into account-switching_refactor_implement-service-changes 2021-12-21 10:27:50 -05:00
Oscar Hinton 8fe821b9a3
Apply Prettier (#2238) 2021-12-21 15:43:35 +01:00
Patrick H. Lauke 6e050349e4 Add aria-pressed attribute to all toggleVisibility buttons
Closes https://github.com/bitwarden/browser/issues/2228
2021-12-18 20:22:11 +00:00
addison 2e793a31dd [style] Fix lint complaints 2021-12-17 14:53:21 -05:00
Robyn MacCallum a49f9fad06 extend state service 2021-12-16 09:39:46 -05:00
Robyn MacCallum f7d2e9c6a4 Merge remote-tracking branch 'origin/master' into account-switching_refactor_implement-service-changes
# Conflicts:
#	src/background/main.background.ts
#	src/background/notification.background.ts
#	src/popup/accounts/lock.component.ts
#	src/popup/accounts/login.component.ts
#	src/popup/services/services.module.ts
#	src/popup/settings/excluded-domains.component.ts
#	src/popup/settings/settings.component.ts
2021-12-13 14:15:23 -05:00
Patrick H. Lauke 1916136f4c Merge branch 'master' into patrickhlauke-issue1987 2021-12-13 17:37:42 +00:00
Oscar Hinton e4aaf81816
Replace toaster library (#2210) 2021-12-07 20:42:18 +01:00
Thomas Rittson adb95e76f4
[Key Connector] Hide "Master Pass On Restart" prompt when setting pin (#2186)
* Disable Master Pass on Restart for Key Connector

* Update jslib
2021-11-18 21:38:47 +10:00
Oscar Hinton 378e6433be
Update export design (#2184) 2021-11-17 20:31:35 +01:00
Robyn MacCallum 3fd627a67b Merge remote-tracking branch 'origin/master' into account-switching_refactor_implement-service-changes 2021-11-15 15:03:56 -05:00
Robyn MacCallum d476d4961a Initial swap from activeAccount to stateService 2021-11-12 16:11:38 -05:00
Patrick H. Lauke c8fc7ee6fc Add basic heading markup 2021-11-02 22:41:17 +00:00
Thomas Rittson 5f9541b1cf
Fixes for dynamic modal a11y (#2116)
* Add modal-dismiss, remove tabindex from modals

* Remove modal-dismiss styles

* Update jslib

* remove cdkTrapFocus etc
2021-10-22 07:42:30 +10:00
Thomas Rittson 6ff7112bb7
Add type="button" to button elements (#2131)
* Add type="button" to button elements

* Add  type="button" to button elements in notificationBar
2021-10-20 07:52:12 +10:00
addison 85e3436de6 [refactor] Replace references to deprecated services
Several refactors were done on the data storage layer of jslib to support Account Switching for desktop.
These changes have been implemented here for parity across clients, improved readability, and to make it easier
to add Account Switching to other clients later if desired.

* The UserService was removed, and so all references have been replaced with the new access points for that data (activeAccount and organizationService most often)
* The StorageService is now considered a "global" scope, where as we have a new "account" scope to consider. Any "account" scope storage items I have moved to saving with
an ActiveAccountService instance instead of a StorageService instance.
* ConstantsServices have been removed and replaced with a StorageKey enum that holds keys that were in ConstantServices and in other feature scoped services.
2021-10-11 10:42:31 -04:00
Patrick H. Lauke f389ea2951 Change links to buttons in new components/fragments that appeared after latest merge 2021-09-18 17:55:18 +01:00
Patrick H. Lauke 6b0167a098
Merge branch 'master' into patrickhlauke-a11y-patch2 2021-09-18 17:47:59 +01:00
Thomas Rittson 8f700b0b45
Use a modal to set the unlock pin (#2060)
* Use separate modal for set pin

* Fix modal style and layout

* Minor fixes

* Remove incorrect label

* Fix initial focus and tab a11y

* Fix unrelated linting

* Update jslib
2021-09-16 05:56:29 +10:00
Oscar Hinton a1f7e07f09
Add password show/hide to reprompt (#1902)
Co-authored-by: Addison Beck <abeck@bitwarden.com>
2021-08-27 15:27:22 +02:00
Thomas Rittson 69c892807c
Use custom virtual scroll strategy (#2002)
* update jslib

* Use custom virtual scroll strategy
2021-08-11 12:52:44 +10:00
Patrick H. Lauke d528d72b4d Change links to buttons
- more semantically accurate, will expose these as buttons to assistive technologies
- note: while having block-level elements like `<div>` inside a `<button>` is an html validation error, it does not affect functionality as long as there's no more structure inside it
2021-07-31 20:50:46 +01:00
Matt Gibson 2be717d0fb
Redefine cipher "share" to "move to organization" (#1903)
* Redefine cipher "share" to "move to organization"

* PR review

* update jslib
2021-06-22 15:44:06 -05:00
Thomas Rittson 57e34dc6e8 Merge remote-tracking branch 'origin' into cdk-virtual-scroll 2021-06-09 10:07:35 +10:00
Oscar Hinton 4e1958f417
Add jslib as a "real" dependency (#1876)
* Support split jslib

* Fix tests

* Bump jslib
2021-06-07 19:25:37 +02:00
Thomas Rittson f2977aab0c remove ciphers-list.component 2021-05-21 14:16:18 +10:00
Thomas Rittson 94ee6c1ab7 fix linting and style 2021-05-21 13:03:05 +10:00
Thomas Rittson 8151d5bcac Revert changes to original ciphers-list.component 2021-05-21 12:58:48 +10:00
Thomas Rittson 6b954df58c Refactor to use virtual-scroll more selectively 2021-05-21 12:42:56 +10:00
Thomas Rittson 9e5869773d Basic proof of concept for cdk-virtual-scroll 2021-05-21 12:42:21 +10:00
Oscar Hinton 6e9e0445de
Fix password re-prompt triggering on non-reprompt items (#1817)
* Fix password re-prompt triggering on non-reprompt items
2021-05-04 19:04:18 +02:00
Oscar Hinton cdc71dd661
Password reprompt (#1784)
* Add support for password reprompt

* Rename passwordPrompt to reprompt.

* Move showPasswordDialog to paltformutils

* Fix swal2 validation error styling

* Group imports

* Update src/_locales/en/messages.json

Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2021-05-03 20:56:38 +02:00
Oscar Hinton 44463e7bc0
Remove dead code (#1787)
* Remove dead analytics code
2021-04-14 23:43:09 +02:00
Vincent Salucci e17649d869
[Send] Enterprise policy enforcement (#1637) 2021-02-24 16:03:44 -06:00
Vincent Salucci 8d2e436a05
[Send] Type component (#1608)
* Initial commit of send type component

* Update jslib (ee164be -> 0951424)

* Update constructor for new jslib
2021-02-12 16:28:31 -06:00
Vincent Salucci 0d6e212463
[Send] Groupings component (#1605)
* Initial commit of groupings component

* Update jslib ee164be

* Updated send-list item icons

* Requested changes

* Removed obsolete safari hacks
2021-02-10 10:16:34 -06:00
Oscar Hinton 3e79dd245b
Safari Web Extension Port from App Extension (#1531) 2021-02-03 20:36:05 +01:00
Thomas Rittson ea1a1cc99b Use consistent naming convention for launchCipher 2021-01-28 07:45:54 +10:00
Thomas Rittson 4045ce2d15 Pass launchCipher down to grandchild for reuse 2021-01-27 15:34:14 +10:00
Chad Scharf 336f8f3117
Revert "Safari Web Extension Port from App Extension" 2021-01-13 17:08:33 -05:00
Hinton db59f2791a Merge branch 'master' of github.com:bitwarden/browser into feature/safari-webext
# Conflicts:
#	src/browser/safariApp.ts
#	src/safari/safari/SafariExtensionViewController.swift
#	src/services/browserPlatformUtils.service.ts
2021-01-13 14:21:45 +01:00
Hinton b1e376ce66 Fix action buttons not working when TOTP is not available 2021-01-08 15:48:48 +01:00
Matt Gibson 0cd6efd67f
Move share from edit to view. Fix animations (#1497)
* Move share from edit to view. Fix animations

Editing and Sharing a cipher simultaneously results in lost edits. Move
share button to the view page to resolve this confusion.

Previous routing caused the share form to be animated again on
submition, resulting in a stuttering page load. This method correctly
animates all transitions with the concession that the share page
always takes you back to the view page. This is not necessarily the current
behavior, but it is the most likely behavior in the current scheme

* Update jslib reference
2020-12-17 11:06:31 -06:00
Matt Gibson 29c624e37b
Add totp copy to clipboard button to cipher view (#1493)
* Add totp copy to clipboard button to cipher view

* Hide quick-copy rather than disable if no totp

* Revert to disabled TOTP button

* Enforce premium access to TOTPs

* Update jslib reference
2020-12-15 10:26:01 -06:00
Hinton 0f2c4b4a59 Remove more old safari app extension logic 2020-12-09 18:23:44 +01:00
K. Sasa 4a35930e2d
Consistent: Replaced the clipboard icon with a clone icon to improve UX (#1344)
* Replace clone item button fa-clone to fa-files-o

* Replace copy value button fa-clipboard to fa-clone
2020-07-27 13:22:56 -04:00
hinton 5e4259db38 Add support for hidden password 2020-05-24 19:59:49 +02:00
Kyle Spearrin 60f6863e4f a11y work 2019-10-08 17:04:44 -04:00