Commit Graph

11629 Commits

Author SHA1 Message Date
Patrick H. Lauke 0396d682b1
Change links to buttons, expose `aria-pressed` for toggles, add `aria-expanded` to send view's "Options" (#1437)
* Change links to buttons, expose `aria-pressed` for toggles

- also make existing `<a routerLink...>` type controls keyboard focusable with the addition of `tabindex="0"`

* Correctly set aria-pressed

now that I have a working build environment, could verify correct way to set this with my limited Angular knowledge

* Change more links to buttons, initial style changes

* Fix layout of <button> elements with .box-content-row

* Update jslib submodule

* Add `aria-expanded` to the send view's "Show options" expand/collapse control

* Fix position of "Edit" pencil when hovering over folders

* Update jslib

* Change sends list links to buttons

* Add `aria-pressed` to vault and send list buttons

Programmatically denote which of the buttons is currently active/shown in the right-most panel

* Fix incorrect "Options" expand/collapse button in add-edit view

Currently, that buttons lacks an accName because the "Options" text is outside of it.

* Add `aria-pressed` to the send left-hand column filters

* Simplify base, list, and vault styles

Since links are now buttons, no need to double up selectors for both types of elements. No need to double-up theming in base, as this also causes incorrect "x" in toasts.

* Remove unnecessary `position:relative`

Fixes issue with cut-off focus outlines, has no other adverse effect

* Fix styling for last child of action buttons

Old approach of making right padding smaller results in unsightly, off-center icon (noticeable when focus outline is visible). This visually remains the same, but reduces right-hand margin instead.
2022-04-30 16:09:41 +02:00
Thomas Rittson 446f2027b4
[PS-74] Fix user authentication state checks (#1632)
* Update to use new authStatus method

* Delete unused services and import

* update jslib
2022-04-30 10:51:33 +10:00
Thomas Rittson ef60112855
[PS-74] Fix user authentication state checks (#1464)
* Use new authStatus method, clean up account switcher

* Update naming

* update jslib
2022-04-30 09:16:46 +10:00
Federico Maccaroni 1f0d496f21
PS-79 Updated two-factor component to to align to jslib change to send the deviceId on 2fa email resend code (#1624) 2022-04-29 13:05:05 -03:00
Thomas Rittson 2e2849b4de
[PS-74] Fix user authentication state checks (#721)
* Create authService.authStatus, refactor isLocked checks

* Rename authStatus -> getAuthStatus
2022-04-29 21:33:38 +10:00
Thomas Rittson b467206448
[EC-156] [BEEEP] Remove factory providers in Angular DI (#1496)
* Use tokens

* Use initService

Co-authored-by: Oscar Hinton <oscar@oscarhinton.com>
2022-04-29 17:48:44 +10:00
Thomas Rittson 2b03162bfd
[EC-154] [BEEEP] Remove factory providers in Angular DI (#1609)
* use InjectionTokens

* Use InitService
2022-04-29 09:45:47 +02:00
Thomas Rittson d7e554653a
[EC-154] [BEEEP] Add token for localesDirectory (#783)
* Add token for localesDirectory

* Add token for SYSTEM_LANGUAGE
2022-04-29 17:28:38 +10:00
Patrick H. Lauke 7b12868c70
[PS-497] Change `<content>` to `<main>`, make it explicitly non-focusable (#2245)
* Make <content> element explicitly non-focusable

Some browsers (Firefox, upcoming versions of Chrome https://bugs.chromium.org/p/chromium/issues/detail?id=585413) make containers with `overflow: auto` / `overflow: scroll` (and the `-x` / `-y` variants) keyboard-focusable. This leads to a very awkward experience for assistive technology users navigating through the extension window, as for every view, the entire `<content>` container receives focus (and screen readers try to announce all its content in one go) before you reach the actual first control. To counteract this behaviour, this adds an explicit `tabindex="-1"` to these elements.

* Change `<content>` to `<main>`

More semantically accurate. See https://github.com/bitwarden/browser/pull/2245#issuecomment-1104553312

* Update scss to target `main` instead of `content`

* Change the previously existing `<main>` to generic `<div>`, tweak styles accordingly

Can't have two separate `<main>` elements, especially not nested ones. The original `<main>` was really just a handy wrapper for the component, but semantically should be neutral
2022-04-29 10:06:33 +10:00
github-actions[bot] f586359610
Bumped version to 2.28.1 (#1629)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-28 11:50:04 -07:00
Patrick H. Lauke 9df22d3601
[PS-329] A11y: make view, copy, etc controls for ciphers/items keyboard focusable/operable, add screen reader improvements (#2507) 2022-04-28 18:24:13 +02:00
Federico Maccaroni e4687b4cc6
PS-302 Added DeviceId to the 2FA email request and set it when calling the endpoint that's needed to see if it's a 2FA email because of a new device (#782) 2022-04-28 13:18:26 -03:00
Matt Gibson 96641cf195
[PS-301] Load OssModule from BitwardenLicense (#1626) 2022-04-28 07:39:59 -05:00
dwbit 572758c598
Add description for reports message (#1600)
Add "Vault Health Reports can be used to evaluate the security of your Bitwarden Personal or Organization Vault" description to the source string, "Identify and close security gaps in your online accounts by clicking the reports below."
2022-04-27 17:06:50 -04:00
dwbit df7db8ad07
Add description for the A-Z & a-z items (#1615) 2022-04-27 17:06:16 -04:00
dwbit 0439d37c14
Contribution Documentation edits (#1599)
Making corrections to the mobile contributions doc:

    Update Crowdin contact from Kyle to dwbit.
    Update 'User-to-User Support' forum category to 'Ask the Bitwarden Community'
2022-04-27 17:05:30 -04:00
Nils Fahldieck 55b301c267
Widen the sidebar to 600px max (#1503)
This implements the suggestion by MrBlack of the community forums in: https://community.bitwarden.com/t/manually-resizable-sidebar-columns-in-bitwarden-desktop-app/31909/3
2022-04-27 22:10:11 +02:00
Kyle Spearrin fe65a337c8
Forwarded email alias generation (#772)
* generate forwarded alias with SL and AD

* added forwarded email to type list

* add ApiService dep

* ApiServiceAbstraction

* use proper status codes

* only generate on button press

* reset username to `-`

* reset username when forwarded

* Authorization header for anonaddy

* use proper anonaddy json path

* firefox relay support

* update description for firefox

* log username generation errors
2022-04-27 10:08:46 -04:00
Matt Gibson 97f38aa654
Fix login sponsorship redirect (#1620) 2022-04-27 08:09:38 -05:00
Thomas Rittson 17c3fdd68b
[EC-157] [BEEEP] Remove factory providers in Angular DI (#2516)
* Use initService

* Use InjectionTokens

* Update to use new locked and logout callbacks
2022-04-27 09:11:39 +10:00
Thomas Rittson e40e7de808
[EC-159] [BEEEP] Remove factory providers in Angular DI (#775) 2022-04-26 07:28:43 +10:00
github-actions[bot] a5ebb9fb52
Bumped version to 1.33.1 (#1502)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 11:40:39 -07:00
Oscar Hinton 5c88dcf0cc
[BEEEP] Add banner component (#759) 2022-04-25 18:02:09 +02:00
github-actions[bot] c4d586509a
Bumped version to 1.22.1 (#528)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 08:03:03 -07:00
Joseph Flinn 510c841359
Merge pull request #2520 from bitwarden/version_bump_1.58.0
Bump version to 1.58.0
2022-04-25 08:02:36 -07:00
github-actions[bot] 2764c9610b
Bumped version to 1.33.0 (#1501)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2022-04-25 08:02:04 -07:00
github-actions[bot] cc6c51dfb1 Bumped version to 1.58.0 2022-04-25 15:00:35 +00:00
Oscar Hinton 241e08b7ff
[EC-166] Move electron metadata to separate file (#1498)
* Move electron metadata to separate file

* Replace yml with json

* Update build script
2022-04-25 15:54:08 +02:00
Oscar Hinton 0444b78ad1
[EC-143] [BEEEP] Allow linking to ciphers (#1579)
Co-authored-by: Matt Gibson <mgibson@bitwarden.com>
2022-04-25 15:41:44 +02:00
Daniel James Smith 705251fbe2
Add aria attributes to password gen options (#1611) 2022-04-22 17:58:42 +02:00
Oscar Hinton 865e92c94c
Improve reorganization note (#1497) 2022-04-22 17:13:06 +02:00
Patrick H. Lauke c3d0a529fb
[CP-92] Add new more understandable labels to password generator checkboxes (#1461) 2022-04-22 15:26:38 +02:00
Oscar Hinton baa0a5b3a2
Add reorganization notice (#526) 2022-04-22 14:38:13 +02:00
Oscar Hinton 6ad7f5a30a
Add reorganization notice (#2517) 2022-04-22 14:25:11 +02:00
Oscar Hinton 27853481d8
Add reorganization notice (#1610) 2022-04-22 14:25:02 +02:00
Oscar Hinton 3b8ea9f97d
Add reorganization notice (#776)
* Add reorganization notice
2022-04-22 14:24:52 +02:00
Oscar Hinton 1315b3c6cd
Add reorganization notice (#1494) 2022-04-22 09:51:13 +02:00
Kyle Spearrin b475f911b6
fix disabling of generate type (#2515) 2022-04-21 17:20:47 -04:00
Dave Nicolson 9f77dd9d09
[CP-96] Capitalize menu items consistently (#1489) 2022-04-21 19:44:53 +02:00
Thomas Rittson 5082c7708a
[PS-211] [PS-212] Make Generator page accessible (#1493)
* Fix radiobutton names

* Add role=radiogroup

* Add aria-labelledby
2022-04-21 09:51:37 -04:00
Thomas Rittson c0511f25ca
[PS-211] [PS-212] Make Generator page accessible (#1607)
* Fix grouping of radiobutton inputs

* Add role=radiogroup

* Add aria-labelledBy to radio button groups
2022-04-21 09:51:00 -04:00
Thomas Rittson 4ed74416f4
[PS-211] [PS-212] Make Generator page accessible (#2513)
* Fix name attributes for radiobuttons in the same group

* Add role=radiogroup

* Add aria-labelledby

* Fix name
2022-04-21 09:49:13 -04:00
Patrick H. Lauke 58b39c613e
Remove unnecessary `role="button"` on `<button>` elements (#2514) 2022-04-21 14:33:20 +02:00
dwbit 10d35d863b
Contribution Documentation edits (#1486)
Making corrections to the mobile contributions doc:

Update Crowdin contact from Kyle to dwbit.
Update 'User-to-User Support' forum category to 'Ask the Bitwarden Community category'
2022-04-21 08:02:41 -04:00
dwbit 796cc88b46
Merge pull request #2503 from bitwarden/dwbit-patch-1
Contribution Documentation edits
2022-04-21 08:02:05 -04:00
Oscar Hinton 1be62ac222
[EC-161] Bump braintree (#1606) 2022-04-20 20:51:33 +02:00
Kyle Spearrin caafbc2b73
fix disabling of generate type (#1491) 2022-04-20 11:46:12 -04:00
Oscar Hinton 366d9b3c63
Remove userId from data models (#771) 2022-04-20 15:59:51 +02:00
Oscar Hinton f6e3481fe9
[BEEEP] Allow linking to ciphers (#760) 2022-04-20 11:15:58 +02:00
Patrick H. Lauke 2cafed758f
[PS-266] A11y: change tabbed interface to toggle buttons, correctly announce currently active tab as pressed (#2505)
* Change routerLink links to button elements

* Set aria-pressed attribute on button depending on routerLinkActive

* Change base styles to apply to tabs that use `<button>` instead of `<a>`
2022-04-20 14:25:44 +10:00